simple_action 1.2.0 → 1.3.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTQ2ZmIwMzQxMjdiYTA3YmRjMzhkNTQ1ODBmNjNhNjgyNjM2YmRhMw==
+    YTkwMTRjNjg4Y2ZjNGIzZDMzNzU3ZWY0ZDMwNTU3OGRiNjc0MTgyZQ==
   data.tar.gz: !binary |-
-    Zjg2OGQ0ZjI1MDc0NzA4YmY2NGQzZjU5NTYyNzc1NTIwYTUxYTNhMg==
+    YjA0Yzk4NDk5ZTgyZTEwM2RjZWI5MDgyZTQxZTQzMzZhMTllMjMwMQ==
 SHA512:
   metadata.gz: !binary |-
-    NTg2ZWRmNmI5YzM0OTBjNzdhYTdhZTkwMTNlNzc2ZjcyZWI4ZTJiMTBlODM2
-    NzYzNDRkZDdiY2IxOTA3ZTRjMWE1ZDE4MjQ4NTAyNTU2YTgxYWE5YjhhNWQ0
-    YjhiNzRlNTFkMzAwOTYwMmExMTM4N2ZhYzQ2ZjE0NTdjODZhM2Y=
+    NjRkOWFjZWI5ODYwZGFmZjBiMDU0YjJlMDRmNmM3YzYyMjhjNTczOThkYmE5
+    NTNhM2VjZTY0NWI1MTZmOGZjMjBhM2UyZTZlODMxNjljMDI3OTJlZDc5Njg3
+    YWY3ZTU0YTIxZjgwZmVlYmQ2Yjc3Mjc5MzgwYzY2YjQ2YzZiOTU=
   data.tar.gz: !binary |-
-    MTU0YmM0NzZkNmU5ZTU3OWZiNzlhMjY1MGNlNGM1NzA2MTIxN2Y5YzdlMWU5
-    NjA2YjMxODBmYTdiNzgyNGRmNTBhNDhkYzk1ZjhmOGViYzUwODBlYjVmYjM5
-    MzUyZTFkYWMyOWEzMzg0MmMzYTJlNDhkZTE1YTRlMDRlNjk2MzQ=
+    ODUzOGQ2YzZiZTdhNzA1ZDU2ZGIzOTI1YmFlNGIyNDJiMzAzNWUxYTUyZGFi
+    MjE5ODBkYzI0MzI0YmI5YmVlMDEzODk0N2I3OTY1NjBkMjM3OTEzNWJhZWFm
+    YTM2NDE5MzkwZGE1MDhkZjBlNThlYTIxOWVlYmU3NjVlNzg3NGI=

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    simple_action (1.1.1)
-      simple_params (>= 1.1.2, < 2.0)
+    simple_action (1.2.0)
+      simple_params (>= 1.3, < 2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -48,7 +48,7 @@ GEM
     rspec-mocks (2.99.3)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
-    simple_params (1.1.2)
+    simple_params (1.3.0)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_action/concerns/delegates_to_params.rb

@@ -14,16 +14,62 @@ module SimpleAction
       super(sym, *args, &block)
     end
 
+
+      # # Overriding this method to allow for non-strict enforcement!
+      # def method_missing(method_name, *arguments, &block)
+      #   if strict_enforcement?
+      #     raise SimpleParamsError, "parameter #{method_name} is not defined."
+      #   else
+      #     if @original_params.include?(method_name.to_sym)
+      #       value = @original_params[method_name.to_sym]
+      #       if value.is_a?(Hash)
+      #         define_anonymous_class(method_name, value)
+      #       else
+      #         Attribute.new(self, method_name).value = value
+      #       end
+      #     end
+      #   end
+      # end
+
+      # def respond_to?(method_name, include_private = false)
+      #   if strict_enforcement?
+      #     super
+      #   else
+      #     @original_params.include?(method_name.to_sym) || super
+      #   end
+      # end
+
+
     private
     def pass_sym_to_params?(sym)
       params.present? &&
-      params_accessor?(sym) &&
+      delegatable_params_method?(sym) &&
       params.respond_to?(sym)
     end
 
+    def delegatable_params_method?(sym)
+      params_accessor?(sym) ||
+      attributes_method?(sym) ||
+      build_method?(sym)
+    end
+
     def params_accessor?(sym)
       stripped = sym.to_s.gsub('=', '').to_sym
       params.attributes.include?(stripped)
     end
+
+    def attributes_method?(sym)
+      sym.to_s.gsub('=', '').end_with?('_attributes')
+    end
+
+    def build_method?(sym)
+      sym.to_s.gsub('=', '').start_with?('build_')
+    end
+
+    module ClassMethods
+      def reflect_on_association(sym)
+        params_class.reflect_on_association(sym)
+      end
+    end
   end
 end

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/simple_action.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "simple_params", ">= 1.2", "< 2.0"
+  spec.add_dependency "simple_params", ">= 1.3", "< 2.0"
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.6"

data/spec/acceptance_spec.rb

@@ -7,6 +7,11 @@ describe "SimpleAction acceptance spec" do
       param :date_of_birth, type: :date, optional: true
       validate :name_has_vowels, if: :name
 
+      #TODO: Must fix this error in SimpleParams!!
+      nested_hash :address, default: {} do
+        param :street, optional: true
+      end
+
       def name_has_vowels
         unless name.scan(/[aeiou]/).count >= 1
           errors.add(:name, "must contain at least one vowel")
@@ -26,18 +31,51 @@ describe "SimpleAction acceptance spec" do
     end
   end
 
-  describe "#model_name" do
+  describe "#model_name", model_name: true do
     it "equals class name" do
       SimpleActionAcceptance.model_name.should eq("SimpleActionAcceptance")
     end
   end
 
-  describe "params #model_name" do
+  describe "params #model_name", params_model_name: true do
     it "equals class name::Params" do
       SimpleActionAcceptance.new.params.model_name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams")
     end
   end
 
+  describe "params accessors", params: true do
+    let(:instance) { SimpleActionAcceptance.new }
+
+    it "allows setters and getters on param vars" do
+      instance.name = "Bob"
+      expect(instance.name).to eq("Bob")
+    end
+
+    it "allows setters and getters on nested_hash" do
+      instance.address = { street: "1 Main St." }
+      expect(instance.address.street).to eq("1 Main St.")
+    end
+
+    it "allows setters and getters on nested_hash using _attributes" do
+      instance.address_attributes = { street: "1 Main St." }
+      expect(instance.address.street).to eq("1 Main St.")
+    end
+
+    it "responds to build_ methods" do
+      address = instance.build_address
+      address.class.name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
+    end
+  end
+
+  describe "class methods", class_methods: true do
+    describe "reflect_on_association", reflect_on_association: true do
+      it "returns Address class for :address" do
+        address_klass = SimpleActionAcceptance.reflect_on_association(:address)
+        address_klass.klass.should eq(SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
+      end
+    end
+  end
+
   describe "outcome" do
     context "with nil params" do
       let(:params) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - brycesenz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-28 00:00:00.000000000 Z
+date: 2015-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_params
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'