simple_action 0.0.1.pre4 → 0.0.1.pre5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODdhYTRmMjQ0MjU4OTU0MjBkYmYyNjA1MzQ4MWE0NzY1MzI2MGZiMQ==
+    OTQzNmQyZDBjOGVlZThkYmJmNWU3MzJjODA4N2Q2MzI3MTk3MWQ1MA==
   data.tar.gz: !binary |-
-    ZTllZjRiZDEzNmJjNThiOGRkOWRjY2Q0NDAzZDNlYzRkMWJiN2IzZg==
+    OTQ1MDM0ZTAxN2IyOWNhMjIyZjg3MzBkOTZiYTBlZjRkNWMwZDFmYw==
 SHA512:
   metadata.gz: !binary |-
-    NTZiZmViMDgzZmQxYTBmMDQ0NWEzZGU5MmU4ZDg2ZmM1M2M0Yzc1YzAzZTk5
-    NWEyNjJlOGJhYzY2YTM0NGYxOTY0YWJiMmMwNWQ5ZDkyZDUyOTI3ODk0ZjQw
-    ZmJhOWUwNTBjOWNhYzE2NDczYThmYTBjNWExYWZmMjdkZDgxMWY=
+    OTE1N2ZiNjhhODc0OWUzYmVmODE2NDlmNWUwZWRiMzRmNTc0OWM2OTNkYmMy
+    NzEyNTQ4NGNkZWNhYjcwNTgwZWNiNWNlNTVmYzgwNDA2MTBiZWU4NjRkMzk5
+    YWIxOTFhY2M1MWEzY2RlZTk0ZTc0OTY2OGQxZWI3MGQ5NTVmMjE=
   data.tar.gz: !binary |-
-    OGJhOGMyNmVlNzRiN2Q5NGIyMzE5M2Y1MTQ4N2I4YmFjNjMzNzY4ZWQ5NjNi
-    M2Y4MmRjNTY1YjdkM2I3N2ZiNmUxMjBhY2U5ODAwODg0ZWExOGJlMmU1MjJm
-    ZmUxYWY2ODc3Y2M2NDc3Nzk3NDZkZTg2YTQ1ZGM3ZWQ1YzA0MjE=
+    MzY4MWRiOWY5ZDA0YTAwN2RiYjc1NWU2NzI2ODA2NDYwYTE3MWM0NTRhNjU1
+    NGEzNzFiMzE1MGUxODIwMjdiNDg2YTAyNjBjNmE2YzVlMTQ1NGQ1YThlM2Q2
+    MjQzZThmNDdhYjM5Y2E0MzhkYWNjZTViYWExYzVlMDQ4NGU4OTQ=

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    simple_action (0.0.1.pre3)
-      simple_params (>= 0.0.5, < 1.0)
+    simple_action (0.0.1.pre4)
+      simple_params (>= 0.0.3, < 1.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/simple_action/service.rb

@@ -30,7 +30,6 @@ module SimpleAction
     def initialize(params={})
       @raw_params = params
       @params = self.class.params_class.new(params)
-      @validity = nil
     end
 
     def params
@@ -38,12 +37,7 @@ module SimpleAction
     end
 
     def valid?
-      # Doing this to avoid re-running @params.valid? every time.
-      if @validity.nil?
-        @validity = @params.valid?
-      else
-        @validity
-      end
+      @params.valid?
     end
 
     def errors

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "0.0.1.pre4"
+  VERSION = "0.0.1.pre5"
 end

data/simple_action.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "simple_params", ">= 0.0.5", "< 1.0"
+  spec.add_dependency "simple_params", ">= 0.0.3", "< 1.0"
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.6"

data/spec/acceptance_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+describe "SimpleAction acceptance spec" do
+  class SimpleActionAcceptance < SimpleAction::Service
+    params do
+      param :name, type: :string
+      validate :name_has_vowels, if: :name
+
+      def name_has_vowels
+        unless name.scan(/[aeiou]/).count >= 1
+          errors.add(:name, "must contain at least one vowel")
+        end
+      end
+    end
+
+    def execute
+      name.upcase
+    end
+  end
+
+  context "with nil params" do
+    let(:params) do
+      {
+        name: nil
+      }
+    end
+
+    describe "outcome" do
+      subject { SimpleActionAcceptance.run(params) }
+
+      it { should_not be_valid }
+      it { should_not be_success }
+
+      it "should have name error" do
+        subject.errors[:name].should eq(["can't be blank"])
+      end
+    end
+
+    describe "result" do
+      subject { SimpleActionAcceptance.run(params).result }
+
+      it { should be_nil }
+    end
+  end
+
+  context "with invalid params" do
+    let(:params) do
+      {
+        name: "sdfg"
+      }
+    end
+
+    describe "outcome" do
+      subject { SimpleActionAcceptance.run(params) }
+
+      it { should_not be_valid }
+      it { should_not be_success }
+
+      it "should have name error" do
+        subject.errors[:name].should eq(["must contain at least one vowel"])
+      end
+    end
+
+    describe "result" do
+      subject { SimpleActionAcceptance.run(params).result }
+
+      it { should be_nil }
+    end
+  end
+
+  context "with valid params" do
+    let(:params) do
+      {
+        name: "billy"
+      }
+    end
+
+    describe "outcome" do
+      subject { SimpleActionAcceptance.run(params) }
+
+      it { should be_valid }
+      it { should be_success }
+    end
+
+    describe "result" do
+      subject { SimpleActionAcceptance.run(params).result }
+
+      it { should eq("BILLY") }
+    end
+  end
+end

data/spec/service_spec.rb

@@ -35,7 +35,7 @@ describe SimpleAction::Service do
           outcome.should be_success
         end
 
-        it "has result equal to output of execute" do
+        it "has result equal to output of execute", failing: true do
           outcome.result.should eq(41)
         end
 

data/spec/spec_helper.rb

@@ -5,6 +5,8 @@ require 'pry'
 
 Dir[File.join('.', 'spec', 'support', '**', '*.rb')].each {|f| require f}
 
+# I18n.config.enforce_available_locales = true
+
 RSpec.configure do |config|
   config.mock_with :rspec
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 0.0.1.pre4
+  version: 0.0.1.pre5
 platform: ruby
 authors:
 - brycesenz
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.5
+        version: 0.0.3
     - - <
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.5
+        version: 0.0.3
     - - <
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -111,6 +111,7 @@ files:
 - lib/simple_action/service.rb
 - lib/simple_action/version.rb
 - simple_action.gemspec
+- spec/acceptance_spec.rb
 - spec/fixtures/dummy_service_object_class.rb
 - spec/fixtures/params_spec_class.rb
 - spec/fixtures/service_spec_class.rb
@@ -143,6 +144,7 @@ signing_key:
 specification_version: 4
 summary: A DSL for specifying services objects, including parameters and execution
 test_files:
+- spec/acceptance_spec.rb
 - spec/fixtures/dummy_service_object_class.rb
 - spec/fixtures/params_spec_class.rb
 - spec/fixtures/service_spec_class.rb