simplabs-excellent 1.4.1 → 1.4.2

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 1
 :minor: 4
-:patch: 1
+:patch: 2

data/lib/simplabs/excellent.rb

@@ -9,7 +9,7 @@ module Simplabs #:nodoc:
 
   module Excellent #:nodoc:
 
-    VERSION = '1.4.1'
+    VERSION = '1.4.2'
 
   end
 

data/lib/simplabs/excellent/rake/excellent_task.rb

@@ -4,37 +4,29 @@ module Simplabs
 
   module Excellent
 
-    module Rake
+    module Rake #:nodoc:
 
-      # A custom rake task for Excellent.
+      # A special rake task for Excellent.
       class ExcellentTask < ::Rake::TaskLib
 
-        # The Name of the task, defaults to :excellent.
+        # The Name of the task, defaults to <tt>:excellent</tt>.
         attr_accessor :name
 
-        # The format to use for the output. This is either html:<filename> or nothing
-        attr_reader :format
+        # Specifies whether to output HTML; defaults to false. Assign a file name to output HTML to that file.
+        attr_accessor :html
 
-        # The paths to process (specify file names or directories; will recursively process all ruby files if a directory are given).
-        attr_reader :paths
+        # The paths to process (specify file names or directories; will recursively process all ruby files if a directory is given).
+        attr_accessor :paths
 
         # Initializes an ExcellentTask with the name +name+.
         def initialize(name = :excellent)
-          @name   = name
-          @paths  = nil || []
-          @format = nil
+          @name  = name
+          @paths = nil || []
+          @html  = false
           yield self if block_given?
           define
         end
 
-        def format=(format) #:nodoc:
-          if format =~ /html:[^\s]+/
-            @format = format 
-          else
-            raise ArgumentError.new("Invalid format #{format}; only 'html:<filename>' is currently supported!")
-          end
-        end
-
         def paths=(paths) #:nodoc:
           if paths.is_a?(String)
             @paths = [paths] 
@@ -45,16 +37,19 @@ module Simplabs
           end
         end
 
-        def define
-          unless ::Rake.application.last_comment
-            desc 'Analyse the code with Excellent'
-          end
-          task name do
-            paths = @paths.join(' ')
-            system("excellent #{@format} #{paths}")
-            $stdout.puts("Wrote result to #{@format.split(':').last}") unless @format.blank?
+        private
+
+          def define
+            unless ::Rake.application.last_comment
+              desc 'Analyse the code with Excellent'
+            end
+            task name do
+              paths = @paths.join(' ')
+              format = @html ? " html:#{@html}" : ''
+              system("excellent#{format} #{paths}")
+              $stdout.puts("\nWrote Excellent result to #{@html}\n\n") if @html
+            end
           end
-        end
 
       end
 

data/lib/simplabs/excellent/runner.rb

@@ -82,7 +82,7 @@ module Simplabs
       #
       # ==== Parameters
       #
-      # * <tt>paths</tt> - The paths to process (specify file names or directories; will recursively process all ruby files if a directory are given).
+      # * <tt>paths</tt> - The paths to process (specify file names or directories; will recursively process all ruby files if a directory is given).
       # * <tt>formatter</tt> - The formatter to use. If a formatter is specified, its +start+, +file+, +warning+ and +end+ methods will be called
       def check_paths(paths, formatter = nil)
         formatter.start if formatter

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: simplabs-excellent
 version: !ruby/object:Gem::Version 
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors: 
 - Marco Otte-Witte