simpal 0.1.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc8c9ae515061413bcdfdf60dd4a8cb0393683ec6266c2cdcc062471e9e39768
-  data.tar.gz: c98b37a5a25403c0f360404d21f4f7edd9ac343cb861b9e2a7b91b1f61ad39bc
+  metadata.gz: ff9bd39a1b3bf614656ba4aa4db6bda6de2ce675e2d429d705f00737e02fa324
+  data.tar.gz: 3d3b24a4727dc9321d37ffb10cc502a7141e759453cf42c6c5ee13728b308994
 SHA512:
-  metadata.gz: 2eb6cafb908711a15ae7260a759475ab7c97e1695c3ef6c884aa1c7e51261b9d2283d35c3b5597d560b8368e25eec931b311e198625f9675599a289d3f5da590
-  data.tar.gz: 999703680296aa07aa79a57eae18732179733acfcf88c0721fb9af2c7c45ec59cf02ebad7167a265f17fdc3fe5bd53d8da489c6da4b9d63be09015b1fd1cf481
+  metadata.gz: 6af06ce6dbfb1b8a6151894089b00642e0f8b221edf1f04e1b8d63b041226794ffcf04cc807d5980a4cd1f605c248cde3bc7e240a5c64340541ef744ee97e9f9
+  data.tar.gz: fd272791debd28b4896bdb8fd1391dbdbcf8f9adc43322b9c9db81bf8675d055e53bde820b1725e3808ca75bfc639b5e24b813baa16952ca342d9629e1dfa37a

data/.rubocop.yml

@@ -11,8 +11,18 @@ Layout/LineLength:
 
 Metrics/BlockLength:
   Exclude:
+    - '**/*.gemspec'
     - 'spec/**/*'
 
+Metrics/ClassLength:
+  Exclude:
+    - 'spec/support/fake_*.rb'
+
+Metrics/MethodLength:
+  Max: 40
+  Exclude:
+    - 'spec/support/fake_*.rb'
+
 Metrics/AbcSize:
   Max: 40
 
@@ -22,8 +32,5 @@ Metrics/CyclomaticComplexity:
 Metrics/PerceivedComplexity:
   Max: 20
 
-Metrics/MethodLength:
-  Max: 40
-
 Naming/VariableNumber:
   EnforcedStyle: snake_case

data/Guardfile

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
+
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_files)
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+
+  # Ruby library files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/lib/simpal/api/payments/authorizations.rb

@@ -54,12 +54,12 @@ module Simpal
         # @param  id      [String]         The ID of an authorized payment.
         # @param  headers [Hash]           The custom headers to add to the request.
         # @param  client  [Simpal::Client] The API client to make the request with.
-        # @return         [Hash]           An empty hash.
+        # @return         [Boolean]        `true` when the authorization has been voided, `false` otherwise.
         #
         def self.void(id, headers: {}, client: nil)
           client = Simpal.client_for(client)
           response = client.connection.post("/v2/payments/authorizations/#{id}/void", nil, headers)
-          response.body
+          response.success?
         end
       end
     end

data/lib/simpal/client.rb

@@ -51,12 +51,15 @@ module Simpal
     #
     def connection
       @connection ||= Faraday.new(service_url, headers: headers) do |connection|
-        connection.use Faraday::Response::RaiseError
+        connection.request :json
+
+        connection.response :raise_error
+        connection.response :json
+
         connection.use Simpal::Middleware::Headers
-        connection.use FaradayMiddleware::EncodeJson
-        connection.use FaradayMiddleware::ParseJson
         connection.use Simpal::Middleware::Authorization, self
-        connection.adapter Faraday.default_adapter
+
+        connection.adapter :net_http
       end
     end
   end

data/lib/simpal/constants.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Simpal
-  VERSION = '0.1.3'
+  VERSION = '1.0.0'
 end

data/lib/simpal/middleware/authorization.rb

@@ -42,10 +42,12 @@ module Simpal
 
       def connection
         @connection ||= Faraday.new(client.service_url, headers: client.headers) do |connection|
-          connection.use Faraday::Request::UrlEncoded
-          connection.use Faraday::Response::RaiseError
-          connection.use FaradayMiddleware::ParseJson
-          connection.request(:basic_auth, client.client_id, client.client_secret)
+          connection.request :url_encoded
+
+          connection.response :raise_error
+          connection.response :json
+
+          connection.request :authorization, :basic, client.client_id, client.client_secret
         end
       end
 

data/lib/simpal/payment/authorization.rb

@@ -50,11 +50,10 @@ module Simpal
       # @param  id      [String]         The ID of an authorized payment.
       # @param  headers [Hash]           The custom headers to add to the request.
       # @param  client  [Simpal::Client] The API client to make the request with.
-      # @return         [Boolean]        `true` if the authorization was voided, else an exception is raised.
+      # @return         [Boolean]        `true` when the authorization has been voided, `false` otherwise.
       #
       def self.void(id, headers: {}, client: nil)
         API::Payments::Authorizations.void(id, headers: headers, client: client)
-        true
       end
     end
   end

data/lib/simpal/payment/capture.rb

@@ -28,7 +28,7 @@ module Simpal
       # @return         [Simpal::PayPalObject] An object representing the refunded payment.
       #
       def self.refund(id, params = {}, headers: {}, client: nil)
-        resource = API::Payments::Captures.refund(id, params, headers: headers, client: client)
+        resource = API::Payments::Captures.capture(id, params, headers: headers, client: client)
         PayPalObject.new(resource)
       end
     end

data/lib/simpal.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'faraday'
-require 'faraday_middleware'
 require 'json'
 require 'singleton'
 require 'time'

data/simpal.gemspec

@@ -27,13 +27,16 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'faraday', '~> 1.4'
-  spec.add_dependency 'faraday_middleware', '~> 1.0'
+  spec.add_dependency 'faraday', '~> 2.0'
 
+  spec.add_development_dependency 'guard', '~> 2.18'
+  spec.add_development_dependency 'guard-rspec', '~> 4.7'
   spec.add_development_dependency 'pry', '~> 0.14.1'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 1.7'
   spec.add_development_dependency 'rubocop-rake', '~> 0.5.1'
   spec.add_development_dependency 'rubocop-rspec', '~> 2.3'
+  spec.add_development_dependency 'sinatra', '~> 2.1'
+  spec.add_development_dependency 'webmock', '~> 3.14'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simpal
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Nialto Services
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-03-14 00:00:00.000000000 Z
+date: 2022-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -16,28 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
+        version: '2.18'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.18'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '4.7'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +136,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
+- !ruby/object:Gem::Dependency
+  name: sinatra
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.14'
 description:
 email:
 - support@nialtoservices.co.uk
@@ -136,6 +178,7 @@ files:
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Guardfile
 - LICENSE
 - README.md
 - Rakefile