similar_models 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad504d7a2e4aff75dc1c3ff6d48162110aaedcad
-  data.tar.gz: 38cbf0ecea5b020f118845b893d59ab7bdb508c9
+  metadata.gz: b55aa8e2b833092a963b70b211ff10f0ee78ead0
+  data.tar.gz: 264b408ebdb78c40b31a1c7f37c99cf6a0360c76
 SHA512:
-  metadata.gz: aebcd2acdddd464feedfc604300daf67add8022fa18920305f2849a31489f1dc8534ffe6eb21e02061be09ac89984194347f2997e496cd031a997b6988388864
-  data.tar.gz: aacfe230c5415df95ef1f4253cb837b53d559b5e770ceafaea9794611f3733fdb9219886c3ce6ae4053a70cc40f1531babd464483d22f69dd870340183f2e2ba
+  metadata.gz: b81bfa56e0a7cfad7ca1c2e3e00d67645dcf18ef2c0e1726d8f23905ffceda65e1ee7d8a617f5e1af136c62a36cb0f20b85f6e9cac5a5792423c06d277e812c6
+  data.tar.gz: b2a2d671129e2bdc1498296b8ce299d599132f96751bb5227fa5a35458026b4fb6c13e01710a29502e047f0632a8484df506fbef0f29fb21e40cd85d11857652

data/README.md

@@ -70,6 +70,12 @@ Note multiple associations do not work with sqlite.
 
 Because of the use of `group`, pagination is not supported.
 
+## In conjunction with acts-as-taggable-on
+
+If you use https://github.com/mbleigh/acts-as-taggable-on/#usage and want to find related users say across multiple contexts:
+
+    user.similar_users.where(taggings: { context: %w(skills interests) })
+
 ## Contributing
 
 1. Fork it

data/lib/similar_models.rb

@@ -25,14 +25,12 @@ module SimilarModels
 
       scope = self.class.select("#{table_name}.*, count(#{primary_key_ref}) AS #{as}_model_count").
         where.not(primary_key => self.id).order("#{as}_model_count DESC")
-      group_by_clause = primary_key
+      group_by_clause = self.class.column_names.map { |column| "#{table_name}.#{column}"}.join(', ')
 
       # if there is only one many-to-many association no need to use UNION sql syntax
       if association_scopes.one?
         scope.merge(association_scopes.first).group(group_by_clause)
       else
-        group_by_clause = self.class.column_names.join(', ')
-
         # see http://blog.ubersense.com/2013/09/27/tech-talk-unioning-scoped-queries-in-rails/
         scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) AS #{table_name}").group(group_by_clause)
       end

data/lib/similar_models/version.rb

@@ -1,3 +1,3 @@
 module SimilarModels
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: similar_models
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jolyon Pawlyn