signet 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9d9e93e57fb53fc7a45b67134f7974e11f15b5c7ea0c6807f0a4cd068964a51
-  data.tar.gz: b9a0806442f9e6fc2a6b68fa8e4e247125dd029335a2a729bdfd8fcc73a7cf96
+  metadata.gz: d922c22c4140c29169cf488634119b758c31ac62770d7125e3cb28de71c7ffe4
+  data.tar.gz: c4ff15f7c7aa2947d0d82dc57baff5b7bfd3b774c46193cc6e5b9b1a989f241f
 SHA512:
-  metadata.gz: 7655de7dfd4f1cec0bc59ea8347188ba36181735007b9dfd9a3d8daa70ee5db7804d03bbdc89a57ddfdfe53b6e0a56fa75d7b7f13d40419a7620e2e39731cda7
-  data.tar.gz: fa9fbc85f62b104703192145af6512053b53e75508e1d0b813cd43e0e10728113617baf93e31e4338128fea998810a0f0228ab8b51d53aeb5ef7496bdcda16ff
+  metadata.gz: a0d67014fbcedddc4cd64b3cdba4d4f694e044d20dbe97d92edb1c707dd7adbffbb26fcef483e07b9c9a82b36111b120166553536c0e0bc8912a32a8c96ce4a9
+  data.tar.gz: 431881775a6acb40631aeb05de74c25d8967a70f19e301471de648c290ece266bddc6548f1f4ebb552776706faee7cc6f61f6a2794dea3b4b3ca0e3a30de1a28

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-## 0.9.0 (2018-08-16)
+## 0.9.1 (2018-08-29)
+* Warn on EOL ruby versions.
+* Fix DateTime normalization.
+
+## 0.9.0 (2018-08-20)
 * Add RemoteServerError class for 5xx level errors.
 * Allow to_json to be called with arguments
 * Expires_in now sets and reflects current expires_at value

data/README.md

@@ -57,3 +57,12 @@ client.fetch_access_token!
 `gem install signet`
 
 Be sure `https://rubygems.org` is in your gem sources.
+
+## Supported Ruby Versions
+This library is currently supported on Ruby 1.9+.  
+However, Ruby 2.4 or later is strongly recommended, as earlier releases have
+reached or are nearing end-of-life. After March 31, 2019, Google will provide
+official support only for Ruby versions that are considered current and
+supported by Ruby Core (that is, Ruby versions that are either in normal
+maintenance or in security maintenance).
+See https://www.ruby-lang.org/en/downloads/branches/ for further details.

data/lib/signet/oauth_2/client.rb

@@ -19,6 +19,7 @@ require 'signet'
 require 'signet/errors'
 require 'signet/oauth_2'
 require 'jwt'
+require 'date'
 
 module Signet
   module OAuth2

data/lib/signet/version.rb

@@ -18,10 +18,71 @@ unless defined? Signet::VERSION
     module VERSION
       MAJOR = 0
       MINOR = 9
-      TINY  = 0
+      TINY  = 1
       PRE   = nil
 
       STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
+
+      # On March 31, 2019, set supported version to 2.4 and recommended to 2.6.
+      # Thereafter, follow the MRI support schedule: supported means non-EOL,
+      # and recommended means in normal (rather than security) maintenance.
+      # See https://www.ruby-lang.org/en/downloads/branches/
+      ##
+      # Minimum "supported" Ruby version (non-EOL)
+      # @private
+      #
+      SUPPORTED_VERSION_THRESHOLD = '1.9'.freeze
+      ##
+      # Minimum "recommended" Ruby version (normal maintenance)
+      # @private
+      #
+      RECOMMENDED_VERSION_THRESHOLD = '2.4'.freeze
+      ##
+      # Check Ruby version and emit a warning if it is old
+      # @private
+      #
+      def self.warn_on_old_ruby_version
+        return if ENV['GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS']
+        cur_version = Gem::Version.new RUBY_VERSION
+        if cur_version < Gem::Version.new(SUPPORTED_VERSION_THRESHOLD)
+          warn_unsupported_ruby cur_version, RECOMMENDED_VERSION_THRESHOLD
+        elsif cur_version < Gem::Version.new(RECOMMENDED_VERSION_THRESHOLD)
+          warn_nonrecommended_ruby cur_version, RECOMMENDED_VERSION_THRESHOLD
+        end
+      rescue ArgumentError
+        'Unable to determine current Ruby version.'
+      end
+
+      ##
+      # Print a warning for an EOL version of Ruby
+      # @private
+      #
+      def self.warn_unsupported_ruby cur_version, recommended_version
+        "WARNING: You are running Ruby #{cur_version}, which has reached" + 
+        " end-of-life and is no longer supported by Ruby Core.\n" + 
+        'Signet works best on supported versions of' + 
+        ' Ruby. It is strongly recommended that you upgrade to Ruby' + 
+        " #{recommended_version} or later. \n" +
+        'See https://www.ruby-lang.org/en/downloads/branches/ for more' +
+        " info on the Ruby maintenance schedule.\n" + 
+        'To suppress this message, set the' + 
+        ' GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS environment variable.'
+      end
+
+      ##
+      # Print a warning for a supported but nearing EOL version of Ruby
+      # @private
+      #
+      def self.warn_nonrecommended_ruby cur_version, recommended_version
+        "WARNING: You are running Ruby #{cur_version}, which is nearing" + 
+        " end-of-life.\n" + 
+        'Signet works best on supported versions of' +
+        " Ruby. Consider upgrading to Ruby #{recommended_version} or later.\n" +
+        'See https://www.ruby-lang.org/en/downloads/branches/ for more' +
+        " info on the Ruby maintenance schedule.\n" +
+        'To suppress this message, set the' + 
+        ' GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS environment variable.'
+      end
     end
   end
 end

data/signet.gemspec

@@ -35,4 +35,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'launchy', '~> 2.4'
   s.add_development_dependency 'kramdown', '~> 1.5'
   s.add_development_dependency 'simplecov', '~> 0.9'
+
+  s.post_install_message = Signet::VERSION::warn_on_old_ruby_version
 end

data/spec/signet/oauth_2/client_spec.rb

@@ -15,6 +15,7 @@ require 'spec_helper'
 require 'signet/oauth_2/client'
 require 'openssl'
 require 'jwt'
+require 'date'
 
 conn = Faraday.default_connection
 
@@ -442,6 +443,18 @@ describe Signet::OAuth2::Client, 'configured for Google userinfo API' do
     expect(@client).to_not be_expired
   end
 
+  it 'should normalize values of expires_at to instances of time' do
+    time_formats = [DateTime.new, "12:00", 100, Time.new]
+    normalized_time_formats = []
+    time_formats.each do |time|
+      @client.expires_at = time
+      normalized_time_formats << @client.expires_at
+    end
+    normalized_time_formats.each do |time|
+      expect(time).to be_an_instance_of(Time)
+    end
+  end
+
   it 'should set expires_in when expires_at is set' do
     issued_at = Time.now
     expires_at = Time.now+100

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: signet
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Bob Aman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-20 00:00:00.000000000 Z
+date: 2018-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable