signed_form-activeadmin 0.1.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6affe6000a6841d3a2714fa0cb042f33d48f5e7
-  data.tar.gz: 66bf4fcc7eed2e518579886e09c70a966c604cf7
+  metadata.gz: 5f68587a74084f6a79fa4cdcd6b49f369556f7c2
+  data.tar.gz: 7e0100570ee59e625a4a560622a69b8afe11bd0a
 SHA512:
-  metadata.gz: 0a59063cf1908248e33d680c02c1db880be7cc4922c7ed4548e3af25e657a060d69fcb48435955e441d24534f76cdcb40017c5f329252c2b7cd0bd4504cc5425
-  data.tar.gz: a11742def7ba3df63a70a20ee7e6897fc554f61a01df81d44d606330196878a3a353c0edf0c4b6fb790f22d0fd40006fb296240a0f3b443377fad098db2b52ab
+  metadata.gz: 09c1a2b36f7f8808659594a27f2a0becacb1df6668acb36caa115c67b93fd2b2b26bd4a81fb9cae4f98c2b0a14902f7ba3b03f33398d1709d96c96759478469c
+  data.tar.gz: bc5d41d583b159b6db43e9aa1daa6b471580fa7a306e7d32ca59f94dcddfe53115a1fc620f52af99186545a2587f662ec1938ccc74fa702131f10b82c5fde093

data/.travis.yml

@@ -5,6 +5,7 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.2.0
   - ruby-head
 
 env:
@@ -13,4 +14,5 @@ env:
   - RAILS_VERSION=3-2-stable AA_VERSION=master
   - RAILS_VERSION=4-0-stable AA_VERSION=master
   - RAILS_VERSION=4-1-stable AA_VERSION=master
+  - RAILS_VERSION=4-2-stable AA_VERSION=master
 #  - RAILS_VERSION=master AA_VERSION=master

data/README.md

@@ -14,3 +14,10 @@ Active Admin forms in the generated Active Admin controllers.
 ## Usage
 
     gem 'signed_form-activeadmin'
+
+## Caveat
+
+Formtastic uses the `check_box_tag` helper and not `check_box` for boolean fields, so they are not caught by SignedForm.
+This gem will thus sign every formtastic boolean input if SignedForm is used in the containing form and does not limit
+this to Active Admin. If you use formtastic to add boolean fields to signed forms, you probably *want* them to be signed
+as other types are automatically, so this should not be an issue.

data/lib/signed_form-activeadmin/version.rb

@@ -2,8 +2,8 @@ module SignedForm
   module ActiveAdmin
     class Version
       MAJOR = 0
-      MINOR = 1
-      PATCH = 3
+      MINOR = 3
+      PATCH = 0
 
       def self.to_s
         "#{MAJOR}.#{MINOR}.#{PATCH}"

data/lib/signed_form-activeadmin.rb

@@ -18,6 +18,19 @@ module SignedForm
             end
           end
         end
+
+        module ::Formtastic
+          module Inputs
+            class BooleanInput
+              orig_check_box_html = instance_method :check_box_html
+
+              define_method :check_box_html do
+                builder.try :add_signed_fields, method
+                orig_check_box_html.bind(self).call
+              end
+            end
+          end
+        end
       end
     end
   end

data/spec/spec.rb

@@ -26,46 +26,70 @@ end
 
 require 'minitest/autorun'
 
-describe ActiveAdmin::ViewHelpers::FormHelper do
-  describe 'active_admin_form_for tag' do
-    include ActionView::Helpers
-    include ActionView::Context if defined? ActionView::Context
-    include SignedForm::ActionView::FormHelper
-    include Formtastic::Helpers::FormHelper
-    include ActiveAdmin::ViewHelpers::FormHelper
-
-    def polymorphic_path(*)
-      '/users'
-    end
+class AASFTest < Minitest::Spec
+  include ActionView::Helpers
+  include ActionView::Context if defined? ActionView::Context
+  include SignedForm::ActionView::FormHelper
+  include Formtastic::Helpers::FormHelper
+  include ActiveAdmin::ViewHelpers::FormHelper
 
-    def protect_against_forgery?
-      false
-    end
+  def user_path(*)
+    '/user'
+  end
 
-    it 'should build a form with signature' do
-      SignedForm.secret_key = 'abc123'
-      SignedForm.options[:digest] = false
+  def polymorphic_path(*)
+    '/users'
+  end
 
-      content = active_admin_form_for(User.new) do |f|
-        f.text_field :name
-      end
+  def protect_against_forgery?
+    false
+  end
 
-      regex = '<form.*>.*<input type="hidden" name="form_signature" ' \
-              'value="\w+={0,2}--\w+".*/>.*' \
-              '<input.*name="user\[name\]".*/>.*' \
-              '</form>'
+  def assigns(*)
+    {}
+  end
+
+  SignedForm.secret_key = 'abc123'
+  SignedForm.options[:digest] = false
+end
 
-      content.must_match Regexp.new(regex, Regexp::MULTILINE)
+class FormHelperTest < AASFTest
+  it 'builds a form with signature' do
+    content = active_admin_form_for(User.new) do |f|
+      f.text_field :name
     end
+
+    regex = '<form.*>.*<input type="hidden" name="form_signature" ' \
+            'value="\w+={0,2}--\w+".*/>.*' \
+            '<input.*name="user\[name\]".*/>.*' \
+            '</form>'
+
+    content.must_match Regexp.new(regex, Regexp::MULTILINE)
   end
 end
 
 describe ActiveAdmin::BaseController do
-  it 'should include SignedForm::ActionController::PermitSignedParams' do
+  it 'includes SignedForm::ActionController::PermitSignedParams' do
     ActiveAdmin::BaseController.included_modules.must_include SignedForm::ActionController::PermitSignedParams
   end
 
-  it 'must include app helpers' do
+  it 'includes app helpers' do
     ActiveAdmin::BaseController._helpers.included_modules.must_include TestHelper
   end
 end
+
+class BooleanInputTest < AASFTest
+  it 'signs boolean field automatically' do
+    semantic_form_for(User.new, signed: true) do |f|
+      f.input :name
+      f.instance_variable_get(:@signed_attributes_context).must_equal [:name]
+    end
+  end
+
+  it 'works with non signed_form builders' do
+    semantic_form_for(User.new) do |f|
+      f.input :name
+      f.instance_variable_get(:@signed_attributes_context).must_equal nil
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: signed_form-activeadmin
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Christopher Schramm
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2015-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -135,9 +135,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Integrates signed_form into activeadmin forms.
 test_files: []
-has_rdoc: