signaling 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d14361be16dd1b4ac9b0bc4fd47b0047f5ea65e
-  data.tar.gz: 30251856a6de2d3c88a13e20cb4cd51c0571c592
+  metadata.gz: 6aa420bd52662a47fe9b029fde67c52523d8b6f3
+  data.tar.gz: d07a6b76e61582ab251e792dcde5e6c96fef948e
 SHA512:
-  metadata.gz: ad3998edffe0846b29c69d8f2a5773701eacdb5ce55866f37bdd61db6106e5619e21cdd9190aae6e8fad0a9defab000ba8c86088e640c542d9e14f2e2ce6de76
-  data.tar.gz: f2be136ba6a2d370c19a1e73371fef7c479f013d566434df899ae439065aa9805cb344717363b0d4804beb71c9c2df241090b5700ce39b02a8b132388d44790b
+  metadata.gz: 449ea04532a91de15a945a5fbc280eb4743de3160d304942cbae9872f2f51beeee05585bf24a98fec7a245589b81724923cf2aac929a3580c923c3b96f33a9b2
+  data.tar.gz: a7f512c76f4ac4489b746a8e664096b0df0ae10f1101e3f41538dc5f38c127d0a5d1012ca69e12fc41bf081cfb8202c3eed1addf1c51b3e8983bb877323c1b38

data/README.md

@@ -170,6 +170,14 @@ Then you can use:
     # GET /accounts/123/item_lists.json
 
 
+### Query parameters
+
+signaling allows sending parameters to remote service:
+
+    > ItemList.all(account_id: '123')
+    # GET /item_lists.json?account_id=123
+
+
 ## Contributing
 
 1. Fork it

data/lib/signaling/base/http.rb

@@ -20,9 +20,8 @@ module Signaling::Base::Http
       http_method = http_method_for(action)
       path_params, body_params = split_params(action, params)
       path = path_for(action, path_params)
-      body = scope_params(body_params)
 
-      response = connection.send(http_method, path, body)
+      response = connection.send(http_method, path, body_params)
 
       block ? block.call(response.body) : response.body
     end
@@ -89,20 +88,10 @@ module Signaling::Base::Http
       method || raise(UndefinedAction, action)
     end
 
-    def scope_params(params)
-      key = params.is_a?(Array) ? param_key.pluralize : param_key
-
-      { key => to_params(params, true) }
-    end
-
     def route_key
       ActiveModel::Naming.route_key(self).pluralize
     end
 
-    def param_key
-      ActiveModel::Naming.param_key(self)
-    end
-
     # changes attribtue names to param names (defined by ":param_name")
     def set_param_names(params)
       HashWithIndifferentAccess.new.tap do |result|

data/lib/signaling/base/persistence.rb

@@ -3,7 +3,7 @@ module Signaling::Base::Persistence
 
   module ClassMethods
     def create(params)
-      from_response(request(:create, params))
+      from_response(request(:create, scope_params(params)))
     rescue Signaling::Error::UnprocessableEntity => e
       from_response(e.response[:body])
     end
@@ -12,6 +12,15 @@ module Signaling::Base::Persistence
       from_response(request(:destroy, id: id))
     end
 
+    def scope_params(params)
+      key = params.is_a?(Array) ? param_key.pluralize : param_key
+
+      { key => to_params(params, true) }
+    end
+
+    def param_key
+      ActiveModel::Naming.param_key(self)
+    end
   end
 
   def new?
@@ -45,13 +54,15 @@ module Signaling::Base::Persistence
   private
 
   def update(params = attributes)
-    self.class.request(:update, params.merge(id: self.id)) do |response|
+    params = self.class.scope_params(params).merge(id: self.id)
+    self.class.request(:update, params) do |response|
       self.attributes = response
     end
   end
 
   def create
-    self.class.request(:create, attributes.except(:id)) do |response|
+    params = self.class.scope_params(attributes.except(:id))
+    self.class.request(:create, params) do |response|
       self.attributes = response
     end
   end

data/lib/signaling/version.rb

@@ -1,3 +1,3 @@
 module Signaling
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/integration/readme_features/query_parameters_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe "README features" do
+  describe "Query parameters" do
+    before do
+      stub_request(:get, expected_item_lists_path)
+    end
+
+    specify "are sent to remote service" do
+      ExampleCom::ItemList.all(account_id: '123')
+      expect_request(:get, path: expected_item_lists_path)
+    end
+
+    def expected_item_lists_path
+      example_com_build_url('item_lists.json?account_id=123')
+    end
+
+  end
+end
+
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: signaling
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Neer Friedman
@@ -210,6 +210,7 @@ files:
 - spec/integration/readme_features/custom_action_path_spec.rb
 - spec/integration/readme_features/errors_spec.rb
 - spec/integration/readme_features/nested_models_spec.rb
+- spec/integration/readme_features/query_parameters_spec.rb
 - spec/spec_helper.rb
 - spec/support/example_com.rb
 - spec/support/example_com/item.rb
@@ -248,6 +249,7 @@ test_files:
 - spec/integration/readme_features/custom_action_path_spec.rb
 - spec/integration/readme_features/errors_spec.rb
 - spec/integration/readme_features/nested_models_spec.rb
+- spec/integration/readme_features/query_parameters_spec.rb
 - spec/spec_helper.rb
 - spec/support/example_com.rb
 - spec/support/example_com/item.rb