signaling 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca19fc3b658bd738c01325701134017ced13e62c
-  data.tar.gz: 8085032158fb6309eb198105fae4d8610b5b9f07
+  metadata.gz: 7d14361be16dd1b4ac9b0bc4fd47b0047f5ea65e
+  data.tar.gz: 30251856a6de2d3c88a13e20cb4cd51c0571c592
 SHA512:
-  metadata.gz: 4f0242e051f363d0c4547d821b0774fccd073eb1856651881bd136e428d279c326a7aa0568341e8cbaee0ffde3d2761abcbe9192839636f15b268798999775a4
-  data.tar.gz: 76a065116c5c79a40b6468330ec4195b0513eb7beb31f2f9a87a8af9b4d10e5210f43bb973a3ced442127470b31f9aa004682fc75dd9ef70c64f54d4ba251dac
+  metadata.gz: ad3998edffe0846b29c69d8f2a5773701eacdb5ce55866f37bdd61db6106e5619e21cdd9190aae6e8fad0a9defab000ba8c86088e640c542d9e14f2e2ce6de76
+  data.tar.gz: f2be136ba6a2d370c19a1e73371fef7c479f013d566434df899ae439065aa9805cb344717363b0d4804beb71c9c2df241090b5700ce39b02a8b132388d44790b

data/README.md

@@ -151,6 +151,25 @@ Then signaling will load these errors to the `ItemList` models
 This file serves as a reference implementation for a controller and as a guide
 to make sure Signaling follows it's main goal.
 
+
+### Custom action paths
+
+To change the URL of a specific action:
+
+    module ExampleCom
+      class ItemList < Signaling::Base
+        use_api ExampleCom::Api
+
+        define_action :index, method: :get, path: 'accounts/:account_id/item_lists.json'
+      end
+    end
+
+Then you can use:
+
+    > lists = ExampleCom::ItemList.all(account_id: '123')
+    # GET /accounts/123/item_lists.json
+
+
 ## Contributing
 
 1. Fork it

data/lib/signaling/base/http.rb

@@ -28,11 +28,12 @@ module Signaling::Base::Http
     end
 
     def define_action(action_name, options)
-      self._defined_actions ||= {}
       unless options[:method] && options[:path]
         raise ArgumentError, ':method and :path options are required'
       end
-      self._defined_actions[action_name.to_sym] = options
+
+      actions = self._defined_actions || {}
+      self._defined_actions = actions.merge(action_name.to_sym => options)
     end
 
     # convert value to params-friendly hash/array

data/lib/signaling/version.rb

@@ -1,3 +1,3 @@
 module Signaling
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/integration/readme_features/custom_action_path_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe "README features" do
+  describe "Custom actions" do
+    let(:custom_path) { 'accounts/:account_id/item_lists.json' }
+
+    around do |example|
+      begin
+        ExampleCom::ItemList.define_action :index, method: :get, path: custom_path
+        example.run
+      ensure
+        ExampleCom::ItemList.define_action :index, method: :get, path: ':route_key.json'
+      end
+    end
+
+    before do
+      stub_request(:get, expected_item_lists_path)
+    end
+
+    specify "will change the URL for the request" do
+      ExampleCom::ItemList.all(account_id: '123')
+      expect_request(:get, path: expected_item_lists_path)
+    end
+
+    specify "are isolated to class" do
+      expect(ExampleCom::Item._defined_actions[:index][:path]).to eq(':route_key.json')
+    end
+
+    def expected_item_lists_path
+      example_com_build_url('accounts/123/item_lists.json')
+    end
+
+  end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: signaling
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Neer Friedman
@@ -207,6 +207,7 @@ files:
 - spec/integration/readme_features/api_setup_spec.rb
 - spec/integration/readme_features/attributes_spec.rb
 - spec/integration/readme_features/controller_usage_spec.rb
+- spec/integration/readme_features/custom_action_path_spec.rb
 - spec/integration/readme_features/errors_spec.rb
 - spec/integration/readme_features/nested_models_spec.rb
 - spec/spec_helper.rb
@@ -244,6 +245,7 @@ test_files:
 - spec/integration/readme_features/api_setup_spec.rb
 - spec/integration/readme_features/attributes_spec.rb
 - spec/integration/readme_features/controller_usage_spec.rb
+- spec/integration/readme_features/custom_action_path_spec.rb
 - spec/integration/readme_features/errors_spec.rb
 - spec/integration/readme_features/nested_models_spec.rb
 - spec/spec_helper.rb