signal 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f93acc02fac0dc15d821540be7b8429a1c4ee767
-  data.tar.gz: ccbf61c85f7448b07f32e5a708905862b63a66f3
+  metadata.gz: 0da1e84da778b581b1e7b325a1437ecc720f56ca
+  data.tar.gz: d1356905f81403f12aac8bebc3205ffb1c031f74
 SHA512:
-  metadata.gz: edebdf9690ad027d27f25a1e80d94272750b1a62434df184d6894c7a253b0f050fe06dda337601179886d22b02d4bffeb5155e695a8d7d09b27f88aef4f3d1f6
-  data.tar.gz: 055b3b383611a0de961f0f66d4cfd7b0b40fcfc36dd252e46d2cdade60dd34b9f73ce50bd07a4e677e596063c3154dbb96687ac788236d4cad9e06a6a15526ac
+  metadata.gz: 1dd9dc2736009aefe24b4aa0dea8d4febd50a3ab9c6b0a8b5eadb95c15e513007c8fedb0bf332809e229e38a0606059b9a8f2a44507f74a47bfabfcb788fbac1
+  data.tar.gz: 292aa7515e1e260860a298da7680235e5418462301042d260d44bc23b0016619eeec6654cc5c045a2ce2527b17b13a1dec9d6808b6f1c2fa67d889c7646057ce

data/.travis.yml

@@ -5,7 +5,6 @@ script: bundle exec rspec
 rvm:
 - '2.2'
 - '2.1'
-- '2.0'
 addons:
   code_climate:
     repo_token:

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Signal
+
+### v1.0.0
+
+- Use `include Signal.active_record` instead of `include Signal::ActiveRecord`. This fixes problems with [constant lookup](https://github.com/fnando/signal/issues/2).

data/README.md

@@ -123,7 +123,7 @@ You can use Signal with ActiveRecord, which will give you some default events li
 
 ```ruby
 class Thing < ActiveRecord::Base
-  include Signal::ActiveRecord
+  include Signal.active_record
 
   validates_presence_of :name
 end
@@ -197,7 +197,7 @@ end
 
 ### Signal::Call
 
-You can include `Signal::Call` instead, so you can have a common interface for your observable object. This will add the `.call()` method to the target class, which will delegate attributes to the observable's `initialize` method and call its `call` method.
+You can include `Signal.call` instead, so you can have a common interface for your observable object. This will add the `.call()` method to the target class, which will delegate attributes to the observable's `initialize` method and call its `call` method.
 
 ```ruby
 class Contact

data/lib/signal.rb

@@ -1,7 +1,7 @@
-require 'signal/active_record'
-require 'signal/listener'
-require 'signal/call'
 require 'signal/version'
+require 'signal/listener'
+require 'signal/extensions/active_record'
+require 'signal/extensions/call'
 
 module Signal
   def on(event, &block)

data/lib/signal/{active_record.rb → extensions/active_record.rb}

@@ -1,19 +1,22 @@
 module Signal
-  module ActiveRecord
-    def self.included(base)
-      base.class_eval do
-        include Signal
-        include InstanceMethods
-
-        around_create     :around_create_signal
-        around_save       :around_save_signal
-        around_destroy    :around_destroy_signal
-        before_validation :before_validation_signal
-        after_validation  :after_validation_signal
+  def self.active_record
+    Extensions::ActiveRecord
+  end
+
+  module Extensions
+    module ActiveRecord
+      def self.included(base)
+        base.class_eval do
+          include Signal
+
+          around_create     :around_create_signal
+          around_save       :around_save_signal
+          around_destroy    :around_destroy_signal
+          before_validation :before_validation_signal
+          after_validation  :after_validation_signal
+        end
       end
-    end
 
-    module InstanceMethods
       private
       def around_create_signal
         emit_signal(:before, :create, self)

data/lib/signal/extensions/call.rb

@@ -0,0 +1,23 @@
+module Signal
+  def self.call
+    Extensions::Call
+  end
+
+  module Extensions
+    module Call
+      def self.included(target)
+        target.include(Signal)
+        target.extend(ClassMethods)
+      end
+
+      module ClassMethods
+        def call(*args, &block)
+          new(*args).tap do |instance|
+            yield(instance)
+            instance.call
+          end
+        end
+      end
+    end
+  end
+end

data/lib/signal/version.rb

@@ -1,3 +1,3 @@
 module Signal
-  VERSION = '0.3.0'
+  VERSION = '1.0.0'
 end

data/spec/signal/activerecord_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Signal::ActiveRecord do
+describe Signal::Extensions::ActiveRecord do
   let(:callable) { Callable.new }
   let(:user) { User.new(:username => 'johndoe') }
 

data/spec/signal/call_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Signal::Call do
+describe Signal::Extensions::Call do
   let(:callable) { Callable.new }
 
   it 'initializes observable with arguments' do

data/spec/signal/issues/2_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe 'Constant lookup', 'https://github.com/fnando/signal/issues/2' do
+  let(:callable) { Callable.new }
+
+  it 'triggers event' do
+    emitter = Emitter.new
+    emitter.on(:success, &callable)
+    expect(callable).to receive(:called).with(no_args)
+
+    emitter.call
+  end
+end

data/spec/spec_helper.rb

@@ -11,6 +11,7 @@ require 'support/observable'
 require 'support/observable_with_call'
 require 'support/callable'
 require 'support/user'
+require 'support/emitter'
 
 ActiveRecord::Base.establish_connection({
   :adapter => 'sqlite3',

data/spec/support/emitter.rb

@@ -0,0 +1,9 @@
+class Emitter
+  include Signal
+
+  def call
+    ActiveRecord::Base.transaction do
+      emit(:success)
+    end
+  end
+end

data/spec/support/user.rb

@@ -1,4 +1,4 @@
 class User < ActiveRecord::Base
-  include Signal::ActiveRecord
+  include Signal.active_record
   validates_presence_of :username
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: signal
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-24 00:00:00.000000000 Z
+date: 2015-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -77,6 +77,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -88,17 +89,19 @@ files:
 - examples/chain.rb
 - examples/listener.rb
 - lib/signal.rb
-- lib/signal/active_record.rb
-- lib/signal/call.rb
+- lib/signal/extensions/active_record.rb
+- lib/signal/extensions/call.rb
 - lib/signal/listener.rb
 - lib/signal/version.rb
 - signal.gemspec
 - spec/signal/activerecord_spec.rb
 - spec/signal/call_spec.rb
+- spec/signal/issues/2_spec.rb
 - spec/signal/listener_spec.rb
 - spec/signal/signal_spec.rb
 - spec/spec_helper.rb
 - spec/support/callable.rb
+- spec/support/emitter.rb
 - spec/support/observable.rb
 - spec/support/observable_with_call.rb
 - spec/support/user.rb
@@ -129,10 +132,12 @@ summary: A simple observer implementation for POROs (Plain Old Ruby Object) and
 test_files:
 - spec/signal/activerecord_spec.rb
 - spec/signal/call_spec.rb
+- spec/signal/issues/2_spec.rb
 - spec/signal/listener_spec.rb
 - spec/signal/signal_spec.rb
 - spec/spec_helper.rb
 - spec/support/callable.rb
+- spec/support/emitter.rb
 - spec/support/observable.rb
 - spec/support/observable_with_call.rb
 - spec/support/user.rb

data/lib/signal/call.rb

@@ -1,21 +0,0 @@
-module Signal
-  def self.call
-    Call
-  end
-
-  module Call
-    def self.included(target)
-      target.include(Signal)
-      target.extend(ClassMethods)
-    end
-
-    module ClassMethods
-      def call(*args, &block)
-        new(*args).tap do |instance|
-          yield(instance)
-          instance.call
-        end
-      end
-    end
-  end
-end