sight 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff89f4bccb463b21835b299946bcf7a54b43f9792eb0b262954812c79633da19
-  data.tar.gz: 7dab4e4911a9bf145a5b0542ac993c6b5d3ce25af54b345e537291c5567db681
+  metadata.gz: 32b20a4a62fbca9fee67a4354538a8e033dc079b945c7aa5a6f6d23f63c0fac6
+  data.tar.gz: 4be26d309ed3cb0649bc093a78326d6f9a4a2ce2f2f3f3ec9943b713bac9f372
 SHA512:
-  metadata.gz: c591ba467ae6d6a64d1d54c188513a2afe743c40e767bca6892f9f30e6ff45ecfb1f134fcef62c420b4e7fb8c13a77fcd9c69e8f830c6cf1a7c79f8d4d61b82f
-  data.tar.gz: 131fd548a595de6b14288b2ae536b2275eb66fb50f6e08182875866bdee44c0acfbb8194a0ee515e510472bb72f38eeae34fa7c64f64e0a97b2e4e4433867775
+  metadata.gz: 7acf8bc51543269963f35953c5e7ffe7452483e655330bd5d9c314c394a575f6710233fe26b117eaa7ca00491c0d4f561c879e2c7ab160fcb32a6d3db15bf7e4
+  data.tar.gz: 696a3493aa44d9e7913913df11f9ef583de057e15bc210811027121a629534d486c7cb7c197180c146644aadba2eea331db8d49315c83da9197d2a4116f472ca

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [0.5.0] - 2026-03-07
+
+### Removed
+
+- Cursor hook support (use Cursor rules instead)
+
+### Changed
+
+- Refactored CLI dispatch to use case statement with extracted `open` and `print_help` methods
+- DRYed up install/uninstall hook agent lookup
+- Use `Set` for commented hunk lines lookup
+- Extracted `hunk_end_offset` to deduplicate boundary logic
+- Use `<<` for string building in `AnnotationFormatter`
+- Simplified prompt comment width clamping
+
 ## [0.4.0] - 2026-03-06
 
 ### Added

data/CLAUDE.md

@@ -13,7 +13,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Architecture
 
-TUI for closing the loop on AI-generated code changes — browse diffs, jump between hunks, and annotate them. Entry point: `exe/sight` → `CLI.run` → `App.new(files).run`.
+TUI for closing the loop on AI-generated code changes — browse diffs, jump between hunks, and annotate them. Entry point: `exe/sight` → `CLI.run` → `CLI.open` → `App.new(files).run`.
 
 **Data flow**: `Git.diff` (raw string) → `DiffParser.parse` (returns `DiffFile[]`) → `App` (curses TUI).
 Untracked files are added via `Git.untracked_files` → `DiffParser.build_untracked`.
@@ -24,10 +24,9 @@ Untracked files are added via `Git.untracked_files` → `DiffParser.build_untrac
 
 **App** renders per-file views with hunk-based navigation (j/k). Active hunk is highlighted; inactive hunks render in dark gray (color pair 5, color 240).
 
-**Hook system**: Unified via `sight install-hook <agent>` / `sight uninstall-hook <agent>` (agent: `claude` or `cursor`).
+**Hook system**: `sight install-hook claude` / `sight uninstall-hook claude`.
 `ClaudeHookInstaller` manages a Claude Code `UserPromptSubmit` hook in `~/.config/claude/settings.json`.
-`CursorHookInstaller` manages a Cursor `beforeSubmitPrompt` hook in `~/.cursor/hooks.json`.
-Both read `.git/sight/pending-review`, output annotations, and delete the file. Hidden subcommands: `hook-run`, `cursor-hook-run`.
+Reads `.git/sight/pending-review`, outputs annotations, and deletes the file. Hidden subcommand: `hook-run`.
 
 ## Conventions
 

data/README.md

@@ -34,18 +34,31 @@ sight
 
 Install a hook so annotations are automatically fed as context in your next message:
 
+**Claude Code** (~/.config/claude/settings.json):
+
 ```bash
-sight install-hook claude   # Claude Code (~/.config/claude/settings.json)
-sight install-hook cursor   # Cursor (~/.cursor/hooks.json)
+sight install-hook claude
 ```
 
 When you quit sight after annotating, the next message you send will include your annotations.
 
+The hook runs on every prompt but is a no-op when there's no pending review — it produces no output and adds nothing to the agent's context.
+
 To remove:
 
 ```bash
 sight uninstall-hook claude
-sight uninstall-hook cursor
+```
+
+**Cursor** — Create a rule in `.cursor/rules/sight.mdc`:
+
+```markdown
+---
+description: When the user asks to review their sight annotations or code review comments
+alwaysApply: false
+---
+
+Read `.git/sight/pending-review`, address the annotations, then delete the file.
 ```
 
 ## Development

data/RELEASING.md

@@ -0,0 +1,7 @@
+# Releasing
+
+1. Update `lib/sight/version.rb` and `CHANGELOG.md`
+2. Run `bundle install` to update `Gemfile.lock`
+3. Run `bundle exec rake` to verify tests and lint pass
+4. Commit: `git commit -am "Release vX.Y.Z"`
+5. Run `bundle exec rake release` — tags, builds, and pushes to RubyGems

data/lib/sight/annotation_formatter.rb

@@ -8,21 +8,21 @@ module Sight
       return "" if annotations.empty?
 
       grouped = annotations.group_by(&:file_path)
-      grouped.map { |path, anns| format_file(path, anns) }.join("\n")
+      grouped.map { |path, file_annotations| format_file(path, file_annotations) }.join("\n")
     end
 
     def format_file(path, annotations)
       out = "## File: #{path}\n\n"
-      annotations.each do |ann|
-        context = ann.hunk.context ? " #{ann.hunk.context}" : ""
-        out += "Hunk (@@#{context}):\n"
-        out += "```diff\n"
-        ann.hunk.lines.each do |line|
+      annotations.each do |annotation|
+        context = annotation.hunk.context ? " #{annotation.hunk.context}" : ""
+        out << "Hunk (@@#{context}):\n"
+        out << "```diff\n"
+        annotation.hunk.lines.each do |line|
           next unless %i[add del].include?(line.type)
-          out += "#{line.content}\n"
+          out << "#{line.content}\n"
         end
-        out += "```\n"
-        out += "> #{ann.comment}\n\n"
+        out << "```\n"
+        out << "> #{annotation.comment}\n\n"
       end
       out
     end

data/lib/sight/app.rb

@@ -92,11 +92,7 @@ module Sight
       content_width = width - gutter - 3
 
       selected_start = hunk_offsets[hunk_idx]
-      selected_end = if hunk_idx + 1 < hunk_offsets.size
-        hunk_offsets[hunk_idx + 1]
-      else
-        lines.size
-      end
+      selected_end = hunk_end_offset(hunk_idx)
 
       commented_lines = commented_hunk_lines
 
@@ -254,9 +250,7 @@ module Sight
 
     def prompt_comment(title)
       win = Curses.stdscr
-      max_width = 80
-      width = [Curses.cols * 2 / 3, 50].max
-      width = [width, max_width].min
+      width = (Curses.cols * 2 / 3).clamp(50, 80)
       height = 5
       top = (Curses.lines - height) / 2
       left = (Curses.cols - width) / 2
@@ -311,6 +305,10 @@ module Sight
       end
     end
 
+    def hunk_end_offset(idx)
+      (idx + 1 < hunk_offsets.size) ? hunk_offsets[idx + 1] : lines.size
+    end
+
     def hunk_commented?(file_index, hunk_index)
       path = files[file_index].path
       hunk = files[file_index].hunks[hunk_index]
@@ -318,13 +316,10 @@ module Sight
     end
 
     def commented_hunk_lines
-      result = []
-      hunk_offsets.each_with_index do |offset, hunk_index|
+      hunk_offsets.each_with_index.each_with_object(Set.new) do |(offset, hunk_index), set|
         next unless hunk_commented?(file_idx, hunk_index)
-        hunk_end = (hunk_index + 1 < hunk_offsets.size) ? hunk_offsets[hunk_index + 1] : lines.size
-        (offset...hunk_end).each { |i| result << i }
+        (offset...hunk_end_offset(hunk_index)).each { |i| set << i }
       end
-      result
     end
 
     def scroll(delta)

data/lib/sight/cli.rb

@@ -1,49 +1,33 @@
 # frozen_string_literal: true
 
-require "json"
-
 module Sight
   module CLI
     module_function
 
     def run(argv)
-      if argv.include?("--help") || argv.include?("-h")
-        puts "Usage: sight"
-        puts "Interactive git diff viewer (staged + unstaged)"
-        puts
-        puts "Keys: j/k hunks, n/p files, c comment, ? help, q quit"
-        puts
-        puts "Subcommands:"
-        puts "  install-hook <agent>    Install hook (claude, cursor)"
-        puts "  uninstall-hook <agent>  Remove hook (claude, cursor)"
-        return
-      end
-
-      if argv.include?("--version") || argv.include?("-v")
-        puts "sight #{VERSION}"
-        return
-      end
-
-      if argv[0] == "install-hook"
-        install_hook(argv[1])
-        return
-      end
-
-      if argv[0] == "uninstall-hook"
-        uninstall_hook(argv[1])
-        return
-      end
-
-      if argv.include?("hook-run")
-        run_hook
-        return
+      return print_help if argv.include?("--help") || argv.include?("-h")
+      return puts("sight #{VERSION}") if argv.include?("--version") || argv.include?("-v")
+
+      case argv[0]
+      when "install-hook" then install_hook(argv[1])
+      when "uninstall-hook" then uninstall_hook(argv[1])
+      when "hook-run" then run_hook
+      else open
       end
+    end
 
-      if argv.include?("cursor-hook-run")
-        run_cursor_hook
-        return
-      end
+    def print_help
+      puts "Usage: sight"
+      puts "Interactive git diff viewer (staged + unstaged)"
+      puts
+      puts "Keys: j/k hunks, n/p files, c comment, ? help, q quit"
+      puts
+      puts "Subcommands:"
+      puts "  install-hook <agent>    Install hook (claude)"
+      puts "  uninstall-hook <agent>  Remove hook (claude)"
+    end
 
+    def open
       Git.clear_pending_review
 
       raw = Git.diff
@@ -71,26 +55,19 @@ module Sight
     end
 
     AGENTS = {
-      "claude" => ClaudeHookInstaller,
-      "cursor" => CursorHookInstaller
+      "claude" => ClaudeHookInstaller
     }.freeze
 
     def install_hook(agent)
-      installer = AGENTS[agent]
-      unless installer
-        warn "Unknown agent: #{agent.inspect}. Use: claude, cursor"
-        return
-      end
-      installer.install
+      resolve_installer(agent)&.install
     end
 
     def uninstall_hook(agent)
-      installer = AGENTS[agent]
-      unless installer
-        warn "Unknown agent: #{agent.inspect}. Use: claude, cursor"
-        return
-      end
-      installer.uninstall
+      resolve_installer(agent)&.uninstall
+    end
+
+    def resolve_installer(agent)
+      AGENTS.fetch(agent) { warn "Unknown agent: #{agent.inspect}. Use: claude" }
     end
 
     def run_hook
@@ -107,20 +84,5 @@ module Sight
       puts content
       File.delete(file)
     end
-
-    def run_cursor_hook
-      $stdin.read
-      git_dir = Git.repo_dir
-    rescue Error
-      nil
-    else
-      file = File.join(git_dir, "sight", "pending-review")
-      return unless File.exist?(file)
-
-      content = File.read(file)
-      message = "The user has just finished reviewing your code changes in sight. Here are their annotations:\n\n#{content}"
-      puts JSON.generate(user_message: message)
-      File.delete(file)
-    end
   end
 end

data/lib/sight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sight
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/lib/sight.rb

@@ -7,7 +7,6 @@ require_relative "sight/git"
 require_relative "sight/annotation"
 require_relative "sight/annotation_formatter"
 require_relative "sight/claude_hook_installer"
-require_relative "sight/cursor_hook_installer"
 require_relative "sight/cli"
 require_relative "sight/app"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sight
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Ariel Rzezak
@@ -37,6 +37,7 @@ files:
 - CODE_OF_CONDUCT.md
 - LICENSE.txt
 - README.md
+- RELEASING.md
 - Rakefile
 - exe/sight
 - lib/sight.rb
@@ -45,7 +46,6 @@ files:
 - lib/sight/app.rb
 - lib/sight/claude_hook_installer.rb
 - lib/sight/cli.rb
-- lib/sight/cursor_hook_installer.rb
 - lib/sight/diff_parser.rb
 - lib/sight/display_line.rb
 - lib/sight/git.rb

data/lib/sight/cursor_hook_installer.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-require "json"
-require "fileutils"
-
-module Sight
-  module CursorHookInstaller
-    HOOK_COMMAND = "sight cursor-hook-run"
-
-    module_function
-
-    def hooks_path
-      File.join(Dir.home, ".cursor", "hooks.json")
-    end
-
-    def install(path: hooks_path)
-      config = if File.exist?(path)
-        JSON.parse(File.read(path))
-      else
-        {"version" => 1, "hooks" => {}}
-      end
-
-      config["version"] ||= 1
-      hooks = config["hooks"] ||= {}
-      prompt_hooks = hooks["beforeSubmitPrompt"] ||= []
-
-      if prompt_hooks.any? { |h| hook_is_sight?(h) }
-        puts "sight hook already installed"
-        return
-      end
-
-      prompt_hooks << {"command" => HOOK_COMMAND}
-
-      FileUtils.mkdir_p(File.dirname(path))
-      File.write(path, JSON.pretty_generate(config) + "\n")
-      puts "Installed sight hook into #{path}"
-    end
-
-    def uninstall(path: hooks_path)
-      unless File.exist?(path)
-        puts "No hooks file found"
-        return
-      end
-
-      config = JSON.parse(File.read(path))
-      prompt_hooks = config.dig("hooks", "beforeSubmitPrompt")
-
-      unless prompt_hooks&.any? { |h| hook_is_sight?(h) }
-        puts "No sight hook found"
-        return
-      end
-
-      prompt_hooks.reject! { |h| hook_is_sight?(h) }
-      File.write(path, JSON.pretty_generate(config) + "\n")
-      puts "Uninstalled sight hook"
-    end
-
-    def hook_is_sight?(entry)
-      entry["command"]&.include?("sight")
-    end
-  end
-end