sift-partner 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MzFkYTY0OGM2MDQxNDQzMzM5NWI5MTczZGJlNzk0YmVmMmU5MjQxMg==
-  data.tar.gz: !binary |-
-    NWJkOGVlNjYxZTNhYzQ5ZTcxM2Q0ZDM4MDcxMDYyNjVhNjRhY2RhOA==
+SHA1:
+  metadata.gz: 2ffbcc3b8821ea80e55772aec21ba849a5bc8c08
+  data.tar.gz: 0ad11555eaf96e0e6d8a60eb12b392ad72913d21
 SHA512:
-  metadata.gz: !binary |-
-    ZjZjY2RkOTVkOTJmNGQ2YWY3YjZkMTk4MjVmYjMxZDBiZTM3OGM1NmZhMTI4
-    MmRmZjUyNjhlYzc5NGU2YTZmNzhjODllYTVjYmRlMjJiY2MxMzlkZDIyNjcy
-    ODFiZDMxYTMzNjFhNjQ2MzAwZTAwNDgzZGViZWIyMzIyMTRlYzM=
-  data.tar.gz: !binary |-
-    YTMzOGExN2Q5ZjRiMjUwMTk4MjI3NjA2NmIyNmQzYzBlYzU4OWZiMDYxZTE3
-    Y2I2YjFmN2U3YmNhMTFhYmMwNGIyY2UxZDg0ZTE3ZTY5NGNhYzQ4OTc3YWI0
-    MWRlZDBmOWRhYTZjMjU3ZjdmM2VlYTAwZGZjY2YxMWUwM2Y2MDQ=
+  metadata.gz: 8e8146c86622681634be4cdc83e38b3f01fc071f500261c3b5da94024a41cafa8676d52fb9ba0aa9dc2cee8ff3e4d87897b425c177f28d5109360967ddbc242a
+  data.tar.gz: 5dbb787221a05ad9b8b9e7bb9cd268928c7afae0c3332a0d90c51012dab6d2d38636024c8fba599c82e5c3e70377270539666d29ea0633da967881f53f34719d

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+before_install:
+  - "gem install bundler"
+  - "bundle -v"
+install:
+  - bundle install
+script:
+  - bundle exec rake spec
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - 2.2.0
+  - 2.3.0

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    sift-partner (0.0.1)
-      httparty (>= 0.13.1)
-      multi_json (>= 1.0)
-      sift (>= 1.1.6.2)
+    sift-partner (0.0.3)
+      httparty (~> 0.13.1)
+      multi_json (~> 1.0)
+      sift (~> 1.1.7)
 
 GEM
   remote: http://rubygems.org/
@@ -13,27 +13,23 @@ GEM
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.2.5)
-    httparty (0.13.1)
+    httparty (0.13.7)
       json (~> 1.8)
       multi_xml (>= 0.5.2)
-    json (1.8.1)
-    multi_json (1.10.1)
+    json (1.8.3)
+    multi_json (1.12.1)
     multi_xml (0.5.5)
-    rake (10.3.2)
-    rspec (3.1.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
-    rspec-core (3.1.4)
-      rspec-support (~> 3.1.0)
-    rspec-expectations (3.1.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.1.0)
-    rspec-mocks (3.1.1)
-      rspec-support (~> 3.1.0)
-    rspec-support (3.1.0)
-    safe_yaml (1.0.3)
-    sift (1.1.6.2)
+    rake (11.1.2)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.4)
+    safe_yaml (1.0.4)
+    sift (1.1.7.3)
       httparty (>= 0.11.0)
       multi_json (>= 1.0)
     webmock (1.18.0)
@@ -44,7 +40,10 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  rake
-  rspec (>= 2.14.1)
+  rake (~> 11.0)
+  rspec (~> 2.0)
   sift-partner!
-  webmock (>= 1.16.0)
+  webmock (~> 1.0)
+
+BUNDLED WITH
+   1.12.5

data/README.rdoc

@@ -1,9 +1,9 @@
-= Sift Science Partner Ruby bindings
+= Sift Science Partner Ruby bindings {<img src="https://travis-ci.org/SiftScience/sift-partner-ruby.png?branch=master" alt="Build Status" />}[https://travis-ci.org/SiftScience/sift-partner-ruby]
 
 == Requirements
 
 * Ruby 1.8.7 or above. (Ruby 1.8.6 might work if you load ActiveSupport.)
-* HTTParty, 0.11.0 or greater
+* HTTParty, 0.13.1 or greater
 * Multi Json, 1.0 or greater
 * sift, 1.1.6.2 or greater
 

data/lib/sift-partner/client.rb

@@ -22,6 +22,8 @@ module SiftPartner
     #   The account id of the partner
     #   (which may be found in the settings page of the console)
     def initialize(api_key = Sift.api_key, id = Sift.account_id)
+      raise("api_key must be a non-empty string") unless valid_string?(api_key)
+      raise("partner must be a non-empty string") unless valid_string?(id)
       @api_key = api_key
       @id = id
     end
@@ -40,6 +42,12 @@ module SiftPartner
     # When successful, returns a including the new account id and credentials.
     # When an error occurs, returns nil.
     def new_account(site_url, site_email, analyst_email, password)
+
+      raise("site url must be a non-empty string") unless valid_string?(site_url)
+      raise("site email must be a non-empty string") unless valid_string?(site_email)
+      raise("analyst email must be a non-empty string") unless valid_string?(analyst_email)
+      raise("password must be a non-empty string") unless valid_string?(password)
+
       reqBody = {:site_url => site_url, :site_email => site_email,
                  :analyst_email => analyst_email, :password => password}
       begin
@@ -70,7 +78,10 @@ module SiftPartner
     #   The value of the notification_url will be a url containing the string '%s' exactly once.
     #   This allows the url to be used as a template, into which a merchant account id can be substituted.
     #   The  notification threshold should be a floating point number between 0.0 and 1.0
-    def update_notification_config(cfg)
+    def update_notification_config(cfg = nil)
+
+      raise("configuration must be a hash") unless cfg.is_a? Hash
+
       http_put(notification_config_url(), cfg)
     end
 
@@ -79,12 +90,20 @@ module SiftPartner
         URI("#{API_ENDPOINT}/partners/#{@id}/accounts")
       end
 
+      def user_agent
+        "SiftScience/v#{API_VERSION} sift-partner-ruby/#{VERSION}"
+      end
+
       def notification_config_url
         URI("#{API_ENDPOINT}/accounts/#{@id}/config")
       end
 
       def safe_json(http_response)
-        response = Sift::Response.new(http_response.body, http_response.code)
+        response = Sift::Response.new(
+          http_response.body,
+          http_response.code,
+          http_response.response
+        )
         if !response.nil? and response.ok?
           response.json
         else
@@ -100,23 +119,32 @@ module SiftPartner
       end
 
       def http_get(uri)
-        header =  {"Authorization" => "Basic #{@api_key}"}
+        header =  {"Authorization" => "Basic #{@api_key}",
+                    "User-Agent" => user_agent}
+
         http_response = HTTParty.get(uri, :headers =>header)
         safe_json(http_response)
       end
 
       def http_put(uri, bodyObj)
         header = {"Content-Type" => "application/json",
-                  "Authorization" => "Basic #{@api_key}"}
+                  "Authorization" => "Basic #{@api_key}",
+                  "User-Agent" => user_agent}
+
         http_response = HTTParty.put(uri, :body => bodyObj.to_json, :headers => header)
         safe_json(http_response)
       end
 
       def http_post(uri, bodyObj)
         header = {"Content-Type" => "application/json",
-                  "Authorization" => "Basic #{@api_key}"}
+                  "Authorization" => "Basic #{@api_key}",
+                  "User-Agent" => user_agent}
         http_response = HTTParty.post(uri, :body => bodyObj.to_json, :headers => header)
         safe_json(http_response)
       end
+
+      def valid_string?(s)
+        s.is_a?(String) && !s.empty?
+      end
   end
 end

data/lib/sift-partner/version.rb

@@ -1,3 +1,4 @@
 module SiftPartner
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
+  API_VERSION = "3"
 end

data/sift-partner.gemspec

@@ -20,13 +20,12 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # Gems that must be intalled for sift to compile and build
-  s.add_development_dependency "rspec", ">=2.14.1"
-  s.add_development_dependency "webmock", ">= 1.16.0"
+  s.add_development_dependency "rspec", "~> 2.0"
+  s.add_development_dependency "webmock", "~>  1.0"
+  s.add_development_dependency("rake", "~> 11.0")
 
   # Gems that must be intalled for sift to work
-  s.add_dependency "httparty", ">= 0.13.1"
-  s.add_dependency "multi_json", ">= 1.0"
-  s.add_dependency "sift", ">= 1.1.6.2"
-
-  s.add_development_dependency("rake")
+  s.add_dependency "httparty", "~> 0.13.1"
+  s.add_dependency "multi_json", "~> 1.0"
+  s.add_dependency "sift", "~> 1.1.7"
 end

data/spec/unit/client_spec.rb

@@ -3,6 +3,11 @@ require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
 describe SiftPartner::Client do
   partner_id = "65653548"
   partner_api_key = "98463454389754"
+  site_url = "merchant123.com"
+  site_email = "owner@merchant123.com"
+  analyst_email = "analyst+merchant123@partner.com"
+  password = "s0m3l0ngp455w0rd"
+
   expected_account_body = {
       "account_id" => "1234567890abcdef",
       "production" => {
@@ -39,11 +44,63 @@ describe SiftPartner::Client do
       }
     }
 
+  it "Cannot instantiate client with nil, empty, or non-string api key" do
+    lambda { Sift::Client.new(nil, partner_id) }.should raise_error
+    lambda { Sift::Client.new("", partner_id) }.should raise_error
+    lambda { Sift::Client.new(123456, partner_id) }.should raise_error
+  end
+
+  it "Cannot instantiate client with nil, empty, or non-string partner id" do
+    lambda { Sift::Client.new(partner_api_key, nil) }.should raise_error
+    lambda { Sift::Client.new(partner_api_key, "") }.should raise_error
+    lambda { Sift::Client.new(partner_api_key, 123456) }.should raise_error
+  end
+
+  it "Can instantiate client with blank api key if Sift.api_key set" do
+    lambda { Sift::Client.new(partner_api_key, partner_id) }.should_not raise_error
+  end
+
+  it "account creation fails with nil, empty, or non-string site url" do
+    partner_client = SiftPartner::Client.new(partner_api_key, partner_id)
+    lambda { partner_client.new_account(nil, site_email, analyst_email,
+      password) }.should raise_error
+    lambda { partner_client.new_account("", site_email, analyst_email,
+      password) }.should raise_error
+    lambda { partner_client.new_account(12345, site_email, analyst_email,
+      password) }.should raise_error
+  end
+
+  it "account creation fails with nil, empty, or non-string site email" do
+    partner_client = SiftPartner::Client.new(partner_api_key, partner_id)
+    lambda { partner_client.new_account(site_url, nil, analyst_email,
+      password) }.should raise_error
+    lambda { partner_client.new_account(site_url, "", analyst_email,
+      password) }.should raise_error
+    lambda { partner_client.new_account(site_url, 12345, analyst_email,
+      password) }.should raise_error
+  end
+
+  it "account creation fails with nil, empty, or non-string analyst email" do
+    partner_client = SiftPartner::Client.new(partner_api_key, partner_id)
+    lambda { partner_client.new_account(site_url, site_email, nil,
+      password) }.should raise_error
+    lambda { partner_client.new_account(site_url, site_email, "",
+      password) }.should raise_error
+    lambda { partner_client.new_account(site_url, site_email, 12345,
+      password) }.should raise_error
+  end
+
+  it "account creation fails with nil, empty, or non-string password" do
+    partner_client = SiftPartner::Client.new(partner_api_key, partner_id)
+    lambda { partner_client.new_account(site_url, site_email, analyst_email,
+     nil) }.should raise_error
+    lambda { partner_client.new_account(site_url, site_email, analyst_email,
+     "") }.should raise_error
+    lambda { partner_client.new_account(site_url, site_email, analyst_email,
+     12345) }.should raise_error
+  end
+
   it "should march through create acct flow" do
-    site_url = "merchant123.com"
-    site_email = "owner@merchant123.com"
-    analyst_email = "analyst+merchant123@partner.com"
-    password = "s0m3l0ngp455w0rd"
     # when we receive the mocked url, it will include the basic auth header encoded
     # and regurgitated before the host name
     stub_request(:post, /https:\/\/.*\@partner\.siftscience\.com\/v3\/partners\/#{partner_id}\/accounts/).
@@ -82,6 +139,14 @@ describe SiftPartner::Client do
       response["totalResults"].should eq(1)
   end
 
+  
+
+  it "config update fails with nil, or non-hash notification threshold" do
+    partner_client = SiftPartner::Client.new(partner_api_key, partner_id)
+    lambda { partner_client.update_notification_config(nil) }.should raise_error
+    lambda { partner_client.update_notification_config("not_a_hash") }.should raise_error
+  end
+
   it "should work through config update flow" do
     stub_request(:put, /https:\/\/.*\@partner\.siftscience\.com\/v3\/accounts\/#{partner_id}\/config/).
       with { |request|

metadata

@@ -1,99 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: sift-partner
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Aaron Beppu
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-06 00:00:00.000000000 Z
+date: 2016-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.1
-  type: :runtime
+        version: '11.0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.1
+        version: '11.0'
 - !ruby/object:Gem::Dependency
-  name: multi_json
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 0.13.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 0.13.1
 - !ruby/object:Gem::Dependency
-  name: sift
+  name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.6.2
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.6.2
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: sift
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 1.1.7
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.1.7
 description: Sift Science Ruby Partner API. Please see http://siftscience.com for
   more details.
 email:
@@ -102,6 +102,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -122,17 +123,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: sift-partner
-rubygems_version: 2.1.11
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Sift Science Ruby Partner API Gem