sidekiq_publisher 5.0.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c19a1a0814263440df5e67a3fccbfcde9db9dd1e157f0fa338b8a39a2c72469d
-  data.tar.gz: 63863dfadce1cba213ec980e8f9eaf2d73a7b63a38a7bb99e608475fb57fbd00
+  metadata.gz: 5d694726b7f22c4d22b2994c73c905981740a2ee6c487bb6ae815c793d766725
+  data.tar.gz: 1fe7ccd8338205c1472c6e7ce8e544c848289a31fd1ba9fa64a93bc7699c9a87
 SHA512:
-  metadata.gz: 93d33b65bd3bf779451172474eff1b87b1552aefd8858aa3614bdb755710aded386b7909b31f1aba4d708868828dbfdda2ed676a01781fa2034772fe5cdd1afa
-  data.tar.gz: 5c16c2f64f50b68345a341cabb032c34f7afc4dca02c0d048880e2bb4d9dc6603edeacf86f1e7e2c83c9ed0a42d75720425ba122b2994a6f718abc1a34305ae4
+  metadata.gz: 31289860faedbc39cc671f59222d15b66558d61a18c32f3318283d15a01a61a50048ae3edbecd259186483c9684ff4f64f2cb6b0c44ee6f33c3f970613beb7eb
+  data.tar.gz: 5fe476a56e27cf5b8a16b71faaf3ac50df0e62c11165f358abca361687aea54254663c9f0cf7f89351269d8ff4ee63dd44baca87d1db6f78c6923a0ecb4286f1

data/.github/CODEOWNERS

@@ -1 +1 @@
-* @ezcater/demand-scalability
+* @ezcater/monolith-experience

data/Appraisals

@@ -2,36 +2,42 @@
 
 appraise "rails-6.1-sidekiq-6.4" do
   gem "activejob", "~> 6.1.0"
+  gem "activerecord", "~> 6.1.0"
   gem "activesupport", "~> 6.1.0"
   gem "sidekiq", "~> 6.4.1"
 end
 
 appraise "rails-6.1-sidekiq-6.5" do
   gem "activejob", "~> 6.1.0"
+  gem "activerecord", "~> 6.1.0"
   gem "activesupport", "~> 6.1.0"
   gem "sidekiq", "~> 6.5.0"
 end
 
 appraise "rails-7.0-sidekiq-6.4" do
   gem "activejob", "~> 7.0.0"
+  gem "activerecord", "~> 7.0.0"
   gem "activesupport", "~> 7.0.0"
   gem "sidekiq", "~> 6.4.1"
 end
 
 appraise "rails-7.0-sidekiq-6.5" do
   gem "activejob", "~> 7.0.0"
+  gem "activerecord", "~> 7.0.0"
   gem "activesupport", "~> 7.0.0"
   gem "sidekiq", "~> 6.5.0"
 end
 
 appraise "rails-7.1-sidekiq-6.4" do
   gem "activejob", "~> 7.1.0"
+  gem "activerecord", "~> 7.1.0"
   gem "activesupport", "~> 7.1.0"
   gem "sidekiq", "~> 6.4.1"
 end
 
 appraise "rails-7.1-sidekiq-6.5" do
   gem "activejob", "~> 7.1.0"
+  gem "activerecord", "~> 7.1.0"
   gem "activesupport", "~> 7.1.0"
   gem "sidekiq", "~> 6.5.0"
 end

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # sidekiq_publisher
 
+## 6.0.0
+- BREAKING: Remove SidekiqPublisher::DatabaseConnection.transaction_open? method
+- Add stage_to_database_outside_transaction configuration option
+
 ## 5.0.0
 - BREAKING: Drop support for Sidekiq < 6.1.
 - Add support for ActiveSupport and ActiveJob 7.1

data/README.md

@@ -19,7 +19,8 @@ publisher process handles retries and ensure that each job is delivered to Sidek
 > :warning: Not all jobs are staged in Postgres. This is determined dynamically:
 > if the job is enqueued from within an `ActiveRecord` transaction, then it is
 > staged in Postgres. If not, then it bypasses Postgres and is enqueued directly
-> to Redis via Sidekiq.
+> to Redis via Sidekiq. To opt out of this behavior configure with
+> SidekiqPublisher.configure { |c| c.stage_to_database_outside_transaction = true }
 
 ## Installation
 

data/gemfiles/rails_6.1_sidekiq_6.4.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 6.1.0"
+gem "activerecord", "~> 6.1.0"
 gem "activesupport", "~> 6.1.0"
 gem "sidekiq", "~> 6.4.1"
 

data/gemfiles/rails_6.1_sidekiq_6.5.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 6.1.0"
+gem "activerecord", "~> 6.1.0"
 gem "activesupport", "~> 6.1.0"
 gem "sidekiq", "~> 6.5.0"
 

data/gemfiles/rails_7.0_sidekiq_6.4.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 7.0.0"
+gem "activerecord", "~> 7.0.0"
 gem "activesupport", "~> 7.0.0"
 gem "sidekiq", "~> 6.4.1"
 

data/gemfiles/rails_7.0_sidekiq_6.5.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 7.0.0"
+gem "activerecord", "~> 7.0.0"
 gem "activesupport", "~> 7.0.0"
 gem "sidekiq", "~> 6.5.0"
 

data/gemfiles/rails_7.1_sidekiq_6.4.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 7.1.0"
+gem "activerecord", "~> 7.1.0"
 gem "activesupport", "~> 7.1.0"
 gem "sidekiq", "~> 6.4.1"
 

data/gemfiles/rails_7.1_sidekiq_6.5.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "activejob", "~> 7.1.0"
+gem "activerecord", "~> 7.1.0"
 gem "activesupport", "~> 7.1.0"
 gem "sidekiq", "~> 6.5.0"
 

data/lib/active_job/queue_adapters/sidekiq_publisher_adapter.rb

@@ -11,7 +11,7 @@ module ActiveJob
       JOB_WRAPPER_CLASS = ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper.to_s.freeze
 
       def enqueue(job)
-        if SidekiqPublisher::DatabaseConnection.transaction_open?
+        if SidekiqPublisher::DatabaseConnection.should_stage_to_database?
           create_job_record(job)
         else
           sidekiq_adapter.enqueue(job)
@@ -19,7 +19,7 @@ module ActiveJob
       end
 
       def enqueue_at(job, timestamp)
-        if SidekiqPublisher::DatabaseConnection.transaction_open?
+        if SidekiqPublisher::DatabaseConnection.should_stage_to_database?
           create_job_record(job, timestamp)
         else
           sidekiq_adapter.enqueue_at(job, timestamp)

data/lib/sidekiq_publisher/database_connection.rb

@@ -2,8 +2,9 @@
 
 module SidekiqPublisher
   module DatabaseConnection
-    def self.transaction_open?
-      ActiveRecord::Base.connection.transaction_open?
+    def self.should_stage_to_database?
+      SidekiqPublisher.stage_to_database_outside_transaction ||
+        ActiveRecord::Base.connection.transaction_open?
     end
   end
 end

data/lib/sidekiq_publisher/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SidekiqPublisher
-  VERSION = "5.0.0"
+  VERSION = "6.0.0"
 end

data/lib/sidekiq_publisher/worker.rb

@@ -10,7 +10,7 @@ module SidekiqPublisher
 
     module ClassMethods
       def client_push(item)
-        if SidekiqPublisher::DatabaseConnection.transaction_open?
+        if SidekiqPublisher::DatabaseConnection.should_stage_to_database?
           SidekiqPublisher::Job.create_job!(item)
         else
           super

data/lib/sidekiq_publisher.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+# FIXES: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger
+require "logger"
+require "active_record"
 require "active_support"
 require "active_support/core_ext/numeric/time"
 require "sidekiq_publisher/version"
@@ -19,7 +22,7 @@ module SidekiqPublisher
   DEFAULT_JOB_RETENTION_PERIOD = 1.day.freeze
 
   class << self
-    attr_accessor :logger, :exception_reporter, :metrics_reporter
+    attr_accessor :logger, :exception_reporter, :metrics_reporter, :stage_to_database_outside_transaction
     attr_writer :batch_size, :job_retention_period
 
     def configure
@@ -36,6 +39,7 @@ module SidekiqPublisher
 
     # For test purposes
     def reset!
+      @stage_to_database_outside_transaction = nil
       @batch_size = nil
       @job_retention_period = nil
       @exception_reporter = nil

data/sidekiq_publisher.gemspec

@@ -59,6 +59,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "shoulda-matchers"
   spec.add_development_dependency "simplecov", "< 0.18"
 
+  spec.add_runtime_dependency "activerecord", ">= 6.1", "< 7.2"
   spec.add_runtime_dependency "activerecord-postgres_pub_sub", ">= 0.4.0"
   spec.add_runtime_dependency "activesupport", ">= 6.1", "< 7.2"
   spec.add_runtime_dependency "sidekiq", ">= 6.4.1", "< 7"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq_publisher
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 6.0.0
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-14 00:00:00.000000000 Z
+date: 2025-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -226,6 +226,26 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '0.18'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: activerecord-postgres_pub_sub
   requirement: !ruby/object:Gem::Requirement
@@ -345,7 +365,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.16
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Publisher for enqueuing jobs to Sidekiq