sidekiq_adhoc_job 2.1.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc98e44d532226e46f53fbe1b7bdb0d5ad300d28298b0288f4d190d7f08cb3e3
-  data.tar.gz: 03de6a6069557e9368c4f118783ea114202262418142acb4805c441d475b25e1
+  metadata.gz: e0eb1cd817107c67f9c597017c3fd7e0fc8e79cd783b934d3b6ebc0fb69f5224
+  data.tar.gz: deaae8c8f3de455976885dddd699fd29295cdcd0ae26a013bac38190d5d5e9a1
 SHA512:
-  metadata.gz: 56847a1d3e01b8f5b185bdc2610ae132801bd036ef99a093f99a70d85683980518d7f39cd636d7e74da7e55d9c964c587b55d17313e99aa40cb8a72130c52cfb
-  data.tar.gz: ffca00494c55f11bce5fde758b0d4ad0c3e07ac61e5d53a668abc0607c29d90b138095bf0a55084c3b2861752eb44fbd79b4dd2450ca6f460489456ecf2c712d
+  metadata.gz: a5955dc23c535cfe30380fb24dabfecaa95dfb8b1bdb251d9def1ddc47bd263f0dda19cca2a2dcbaa45edcf2c974d2bebd2a2fdd371e10e19d263be757478261
+  data.tar.gz: fdb6a47dc6c58d2054f6d6d21b6c10e67a9d38efe5bd76de5dca355df28125f569b6db1ddd4ca5c648faa948cfba2b8293541e1baa7685be6ec68b9984383843

data/lib/sidekiq_adhoc_job/version.rb

@@ -1,3 +1,3 @@
 module SidekiqAdhocJob
-  VERSION = '2.1.1'.freeze
+  VERSION = '2.2.0'.freeze
 end

data/lib/sidekiq_adhoc_job/web/job_presenter.rb

@@ -4,12 +4,20 @@ module SidekiqAdhocJob
     class JobPresenter
       include Sidekiq::WebHelpers
 
-      attr_reader :name, :path_name, :queue, :required_args, :optional_args, :required_kw_args, :optional_kw_args, :has_rest_args
+      attr_reader :name,
+                  :path_name,
+                  :queue,
+                  :required_args,
+                  :optional_args,
+                  :required_kw_args,
+                  :optional_kw_args,
+                  :has_rest_args,
+                  :require_confirm
 
       StringUtil ||= ::SidekiqAdhocJob::Utils::String
 
       # args: { req: [], opt: [] }
-      def initialize(name, path_name, queue, args)
+      def initialize(name, path_name, queue, args, require_confirm)
         @name = name
         @path_name = path_name
         @queue = queue
@@ -18,6 +26,7 @@ module SidekiqAdhocJob
         @required_kw_args = args[:keyreq] || []
         @optional_kw_args = args[:key] || []
         @has_rest_args = !!args[:rest]
+        @require_confirm = require_confirm
       end
 
       # Builds the presenter instances for the schedule hash
@@ -42,7 +51,8 @@ module SidekiqAdhocJob
         queue = SidekiqAdhocJob.config.strategy.get_queue_name(klass_name)
         class_inspector = SidekiqAdhocJob::Utils::ClassInspector.new(klass_name)
         args = class_inspector.parameters(:perform)
-        new(klass_name, path_name, queue, args)
+        require_confirm = SidekiqAdhocJob.config.require_confirmation?(klass_name.to_s)
+        new(klass_name, path_name, queue, args, require_confirm)
       end
 
       def no_arguments?

data/lib/sidekiq_adhoc_job/web/locales/en.yml

@@ -7,6 +7,7 @@ en:
   adhoc_jobs_optional_arguments: Optional Arguments
   adhoc_jobs_go_back: Go Back
   adhoc_jobs_has_rest_arguments: Has Rest Arguments
+  adhoc_jobs_confirm_required: Confirm Required
   adhoc_jobs_name: Job Name
   adhoc_jobs_queue: Job Queue
   adhoc_jobs_run_job: Run Job

data/lib/sidekiq_adhoc_job/web/templates/jobs/index.html.erb

@@ -11,6 +11,7 @@
         <th><%= t('adhoc_jobs_required_keyword_arguments') %></th>
         <th><%= t('adhoc_jobs_optional_keyword_arguments') %></th>
         <th><%= t('adhoc_jobs_has_rest_arguments') %></th>
+        <th><%= t('adhoc_jobs_confirm_required') %></th>
         <th><%= t('adhoc_jobs_actions') %></th>
       </tr>
     </thead>
@@ -25,6 +26,7 @@
           <td><%= job.required_kw_args.join(', ') %></td>
           <td><%= job.optional_kw_args.join(', ') %></td>
           <td><%= job.has_rest_args %></td>
+          <td><%= job.require_confirm %></td>
           <td class="text-center">
             <a class="btn btn-warn btn-xs" href="<%= root_path %>adhoc-jobs/<%= CGI.escape(job.path_name) %>">
               <%= t('adhoc_jobs_view_job') %>

data/lib/sidekiq_adhoc_job/web/templates/jobs/show.html.erb

@@ -2,7 +2,7 @@
 
 <h4><%= SidekiqAdhocJob::Utils::String.classify(@presented_job.path_name) %></h4>
 
-<form method="POST" action="<%= root_path %>adhoc-jobs/<%= CGI.escape(@presented_job.path_name) %>/schedule">
+<form method="POST" action="<%= root_path %>adhoc-jobs/<%= CGI.escape(@presented_job.path_name) %>/schedule" id="adhoc-jobs-submit-form">
   <input type="hidden" name="authenticity_token" value="<%= @csrf_token %>" />
   <% if @presented_job.no_arguments? %>
     <p>No job arguments</p>
@@ -55,3 +55,12 @@
     </div>
   </div>
 </form>
+
+<% if @presented_job.require_confirm %>
+  <script>
+    document.getElementById('adhoc-jobs-submit-form').addEventListener('submit', (event) => {
+      if (!confirm('Are you sure?'))
+        event.preventDefault();
+    })
+  </script>
+<% end %>

data/lib/sidekiq_adhoc_job.rb

@@ -41,7 +41,10 @@ module SidekiqAdhocJob
   end
 
   class Configuration
-    attr_accessor :load_paths, :module_names, :strategy_name
+    attr_accessor :load_paths,
+                  :module_names,
+                  :strategy_name,
+                  :require_confirm_worker_names
 
     def initialize
       @load_paths = []
@@ -53,6 +56,14 @@ module SidekiqAdhocJob
       Array(@module_names).map(&:to_s)
     end
 
+    def require_confirm
+      @require_confirm ||= Array(@require_confirm_worker_names).map(&:to_s)
+    end
+
+    def require_confirmation?(worker_name)
+      require_confirm.include?(worker_name)
+    end
+
     def strategy
       @strategy ||= case strategy_name
                     when :default

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq_adhoc_job
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.2.0
 platform: ruby
 authors:
 - Goh Khoon Hiang
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-11 00:00:00.000000000 Z
+date: 2022-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry