sidekiq-undertaker 1.4.1 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8bb9cb0de79a210eecb875abea9d75cf30f228c294ac9af748a0e90bd2634433
-  data.tar.gz: efeafbf06536b5ce50ea2d0f13286c92829d11c9168dbd608bf60ade9ad80cde
+  metadata.gz: be6e466de018cc344512e76981a4f4c98ea436873d666dc8b49ddaba592e2cd3
+  data.tar.gz: c2667a175749a46487e8f807b800e7a06835365f421591d0af6b1e36c8cd2465
 SHA512:
-  metadata.gz: f4c2faf722ee34829c0de7d9c403f42cc148784a735a036de962651e5f7eb02b385a6044cf72da3d8b9290c247b8fcca751ef161ab89f1ef658ce9312e7151bf
-  data.tar.gz: e599c728949f5363b1d19dcbacc590e606adcd6c15ce4ef2866bc73924f906c5a2b51b6f6533df5d147a2f97fea790fec68cb8f63200aefe00bd0cde792c3f02
+  metadata.gz: fe72efc8d5ddce343d8df6adb821efbe12bf92701743fb30f757217ffb19be3a5485e4ca0036432c01f537ed48469fcf306d40a66859aa17524b638cafb5d980
+  data.tar.gz: ccbcf7042e8a80cee8a22400e496cbb8884d9b76ba7e6c177ee368d134dc421e03dfe2e1599debf787a9ebacb719870b1cfa8265707c3c905e442b7ab6f37402

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+## [1.5.0] - 2022-09-06
+
+### Changed
+- Updated max error message length to be configurable
+- Updated rack-test requirement from ~> 1.1 to ~> 2.0
+
 ## [1.4.1] - 2022-06-03
 ### Fixed
 - Fix downgrade rubocop to '1.28' to keep support for JRuby '9.2.20.1'

data/lib/sidekiq/undertaker/dead_job.rb

@@ -53,7 +53,7 @@ module Sidekiq
       attr_writer :job_class, :time_elapsed_since_failure, :error_class, :error_message, :bucket_name, :job
 
       def shorten_error_msg(msg)
-        max_error_msg_length = 30
+        max_error_msg_length = Sidekiq::Undertaker.max_error_msg_length
 
         msg.length > max_error_msg_length ? "#{msg[0, max_error_msg_length]}..." : msg
       end

data/lib/sidekiq/undertaker/version.rb

@@ -2,6 +2,6 @@
 
 module Sidekiq
   module Undertaker
-    VERSION = "1.4.1"
+    VERSION = "1.5.0"
   end
 end

data/lib/sidekiq/undertaker.rb

@@ -14,3 +14,19 @@ if defined?(Sidekiq::Web)
   Sidekiq::Web.tabs["Undertaker"] = "undertaker/filter"
   Sidekiq::Web.settings.locales << File.join(File.dirname(__FILE__), "../../web/locales")
 end
+
+module Sidekiq
+  module Undertaker
+    @config = {
+      max_error_msg_length: 30
+    }
+
+    def self.max_error_msg_length=(value)
+      @config[:max_error_msg_length] = Integer(value)
+    end
+
+    def self.max_error_msg_length
+      @config[:max_error_msg_length]
+    end
+  end
+end

data/sidekiq-undertaker.gemspec

@@ -39,7 +39,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "approvals", "~> 0.0.25"
   spec.add_development_dependency "mock_redis", "~> 0.19"
   spec.add_development_dependency "pry", "~> 0.12"
-  spec.add_development_dependency "rack-test", "~> 1.1"
+  spec.add_development_dependency "rack-test", "~> 2.0"
   spec.add_development_dependency "rb-readline", "~> 0.5"
   spec.add_development_dependency "rspec", "~> 3.8"
   spec.add_development_dependency "rspec-core", "~> 3.8"

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_filter/when_filter_page_is_called/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_filter/when_job_classbucket_page_is_called/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_filter/when_job_classbucket_page_is_polled/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_filter/when_job_classerror_classbucket_page_is_called/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_filter/when_job_classerror_classbucket_page_is_polled/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_all_failures_and_errors/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_job_class_error_and_specific_error_message/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_job_class_error_and_specific_error_message/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/fixtures/approvals/sidekiq_undertaker_webextension/show_morgue/when_job_classerrorbucket_is_called/with_specific_job_class_and_a_specific_error/with_pagination/behaves_like_a_page/the_displayed_page_is_correct_for_sidekiqv6.approved.txt

@@ -22,7 +22,7 @@
     <div class="navbar navbar-default navbar-fixed-top">
   <div class="container-fluid">
     <div class="navbar-header" data-navbar="static">
-      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-menu">
+      <button type="button" class="navbar-toggle collapsed" data-toggle="navbar-menu" data-target="#navbar-menu">
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>

data/spec/sidekiq/undertaker_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Sidekiq::Undertaker do
+  describe ".max_error_msg_length" do
+    around do |example|
+      memo = described_class.max_error_msg_length
+      example.run
+      described_class.max_error_msg_length = memo
+    end
+
+    it "returns the default max_error_msg_length" do
+      expect(described_class.max_error_msg_length).to eq(30)
+    end
+
+    it "updates the max_error_msg_length" do
+      new_value = 99
+      expect { described_class.max_error_msg_length = new_value }
+        .to change(described_class, :max_error_msg_length)
+        .from(30).to(new_value)
+
+      expect(described_class.max_error_msg_length).to eq(new_value)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-undertaker
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Thomas Koppensteiner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-03 00:00:00.000000000 Z
+date: 2022-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -91,7 +91,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '2.0'
   name: rack-test
   prerelease: false
   type: :development
@@ -99,7 +99,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -369,6 +369,7 @@ files:
 - spec/sidekiq/undertaker/job_distributor_spec.rb
 - spec/sidekiq/undertaker/job_filter_spec.rb
 - spec/sidekiq/undertaker/web_extension_spec.rb
+- spec/sidekiq/undertaker_spec.rb
 - spec/spec_helper.rb
 - web/locales/en.yml
 - web/views/filter.erb