sidekiq-throttled 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e18c53412711982bb7d620c5300d30d89cf1668
-  data.tar.gz: abe45ca2b495ee939a8ce11437b9e1fc48664242
+  metadata.gz: 8ef8cce2c35072fd109e89066e293074fb125828
+  data.tar.gz: 575ea548b4594445fd8b2532896bac87149e96ef
 SHA512:
-  metadata.gz: e8d86da7c4b388b3b235caff8a887e342cae176d42398ef4033d946532cb6bd4568080db5b1afca15b6f6efe4984dd124229219c73524cb5bfe58ee813461fcb
-  data.tar.gz: 83e7c860e3b17b7ec8b4295ea6ddf5d6c9e8f9e984c4fa367d9d803cf2b7403e0bbafc0772df7b679e3e7ad0edfb47729646691eb913b10ff834c424aad97253
+  metadata.gz: 4f5b3b2b3023f776b247e07db7959ad691990d6dbddf26c662e101b95868440dea2c3f2c81f9ed139b5b471bfdc259b6a52649957f5bd809ec508b2f53fc7488
+  data.tar.gz: 5a898501386292385f3399ce572ea47110766e72c38dbf9ab5f57f23bca155c66c2e32cdb0c4b9adf31155b48382e96ca4a071294325cec3fc3beaa66ae9178b

data/CHANGES.md

@@ -1,3 +1,9 @@
+## 0.8.1 (2017-11-02)
+
+* Preload job class constant prior trying to get it's throttling strategy.
+  ([@ixti])
+
+
 ## 0.8.0 (2017-10-11)
 
 * Refactor concurrency throttling internals to use sorted sets in order to avoid

data/lib/sidekiq/throttled.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+# stdlib
+require "thread"
+
 # 3rd party
 require "sidekiq"
 
@@ -40,6 +43,9 @@ module Sidekiq
   #       end
   #     end
   module Throttled
+    MUTEX = Mutex.new
+    private_constant :MUTEX
+
     class << self
       # Hooks throttler into sidekiq.
       #
@@ -68,6 +74,8 @@ module Sidekiq
         job = message.fetch("class") { return false }
         jid = message.fetch("jid") { return false }
 
+        preload_constant! job
+
         Registry.get job do |strategy|
           return strategy.throttled?(jid, *message["args"])
         end
@@ -76,6 +84,34 @@ module Sidekiq
       rescue
         false
       end
+
+      private
+
+      # Tries to preload constant by it's name once.
+      #
+      # Somehow, sometimes, some classes are not eager loaded upon Rails init,
+      # leading to throttling config not being registered prior job perform.
+      # And that leaves us with concurrency limit + 1 situation upon Sidekiq
+      # server restart (becomes normal after all Sidekiq processes handled
+      # at leas onr job of that class).
+      #
+      # @return [void]
+      def preload_constant!(job)
+        MUTEX.synchronize do
+          @preloaded      ||= {}
+          @preloaded[job] ||= constantize(job) || true
+        end
+      end
+
+      # Resolve constant from it's name
+      def constantize(str)
+        str.sub(/^::/, "").split("::").inject(Object) do |const, name|
+          const.const_get(name)
+        end
+      rescue
+        Sidekiq.logger.warn { "Failed to constantize: #{str}" }
+        nil
+      end
     end
   end
 end

data/lib/sidekiq/throttled/version.rb

@@ -3,6 +3,6 @@
 module Sidekiq
   module Throttled
     # Gem version
-    VERSION = "0.8.0"
+    VERSION = "0.8.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-throttled
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Alexey V Zapparov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq