sidekiq-throttled 0.6.6 → 0.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 533d15834069284a6d4a781438724390ae8c185e
-  data.tar.gz: e7ef6171c7d1d50f4e73ca2d856ada94a861cd93
+  metadata.gz: ec534fed2e493758df139b6245cf1f9e657c2e18
+  data.tar.gz: 3de82b6c63e63e59a7c14c47683b9a9bff3dd912
 SHA512:
-  metadata.gz: eb0e8c60fa207fc0c79b051640ee6d0c4312e91f5b5fe327a48a383ff8c21cc706c57de346c71aa5c750e4b19339da3d700858c26574717a130393d20957ae69
-  data.tar.gz: 0d4c82ed8ff3e7af23e4adfeec283c40d4fe200de4342fad333b174e8b9f64ae6fb22641c916fea0aed9bc0a4dbe0611936a350ad691c2b360ded39a3769b6c7
+  metadata.gz: cb31fced1ceae5050599471b39cbe8eedd7285bab72b77923fc471e4104eb1fdb85b7631622917ce423d3440abf06953123f289ce9d1917d1a33446beb39f3d2
+  data.tar.gz: eb34237d9b64bb9c3cc4b6a9d33dc79d439b7990e84a59d63a999361eed857eda4cdf100831fd6e1e1f944d118d7dda504c98980d7bc33aaeafe0c01af3bcefd

data/.rubocop.todo.yml

@@ -0,0 +1,25 @@
+# need to review if it's possible to slim down methods down to 10 LOCs
+# and if not, either disable this cop inline or bump up limits. in any
+# case once we're clear on max allowed LOCs per method - it should be
+# fixed in rubocop config (as rubocop constantly changing "best practices"
+# according to moon's phase and wind's direction).
+Metrics/MethodLength:
+  Exclude:
+    - lib/sidekiq/throttled/strategy.rb
+    - lib/sidekiq/throttled/queues_pauser.rb
+    - lib/sidekiq/throttled/communicator/callbacks.rb
+    - lib/sidekiq/throttled/communicator/listener.rb
+
+# i have no strong feeling one way or the other, but probably using JSON for
+# serializatino will be a bit more secure indeed.
+Security/MarshalLoad:
+  Exclude:
+    - lib/sidekiq/throttled/communicator/listener.rb
+
+# Enable this cop once we drop Ruby 2.2.x support.
+Style/SafeNavigation:
+  Enabled: false
+
+# Enable this cop once we drop Ruby 2.2.x support.
+Style/NumericPredicate:
+  Enabled: false

data/.rubocop.yml

@@ -1,32 +1,35 @@
+inherit_from: .rubocop.todo.yml
+
+################################################################################
+
 AllCops:
   DisplayCopNames: true
+  TargetRubyVersion: 2.4
+
+## Metrics #####################################################################
+
+Metrics/BlockLength:
+  Exclude:
+    - "Guardfile"
+    - "spec/**/*"
 
 ## Styles ######################################################################
 
+Style/AlignHash:
+  EnforcedHashRocketStyle: table
+
 Style/AlignParameters:
   EnforcedStyle: with_fixed_indentation
 
 Style/BracesAroundHashParameters:
   Enabled: false
 
-# Broken (2014-12-15). Use `yardstick` gem instead.
-# See: https://github.com/bbatsov/rubocop/issues/947
-# TODO: Enable back once cop is fixed.
 Style/Documentation:
   Enabled: false
 
-Style/EmptyCaseCondition:
-  Enabled: false
-
-Style/EmptyLineBetweenDefs:
-  AllowAdjacentOneLineDefs: true
-
 Style/Encoding:
   EnforcedStyle: when_needed
 
-Style/FrozenStringLiteralComment:
-  EnforcedStyle: always
-
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 
@@ -36,48 +39,24 @@ Style/IndentArray:
 Style/IndentHash:
   EnforcedStyle: consistent
 
-# New lambda syntax is as ugly to me as new syntax of Hash.
+# Follow your heart where it makes sense to use lambda or lambda literal.
+# Enforcing it makes some pieces of code look REALLY terrible, e.g. in
+# case of empty (noop) lambdas: `lambda { |_| }`.
 Style/Lambda:
   Enabled: false
 
-Style/MultilineOperationIndentation:
+Style/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-# IMHO `%r{foo/bar}` looks way more cleaner than `/foo\/bar/`.
-# Enabling this cop also makes Guardfile (which is full of pathname regexps)
-# look absolutley (style) inconsistent and terrible. Thus it should be on
-# developer's choice whenever to user `%r` or not.
+# Enabling this cop makes Guardfile (which is full of pathname regexps)
+# look absolutley style-inconsistent and terrible. In any case, this should
+# be on developer's choice whenever to use `%r` or not. Just like we don't
+# enforce to use `["foo"]` over `%w(foo)` and so on.
 Style/RegexpLiteral:
   Enabled: false
 
-# A bit useless restriction, that makes impossible aligning code like this:
-#
-#   redis do |conn|
-#     conn.hset    :k1, now
-#     conn.hincrby :k2, 123
-#   end
-Style/SpaceBeforeFirstArg:
-  Enabled: false
+Style/SpaceInLambdaLiteral:
+  EnforcedStyle: require_space
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
-
-# Not all trivial readers/writers can be defined with attr_* methods
-#
-#   class Example < SimpleDelegator
-#     def __getobj__
-#       @obj
-#     end
-#
-#     def __setobj__(obj)
-#       @obj = obj
-#     end
-#   end
-Style/TrivialAccessors:
-  Enabled: false
-
-## Metrics #####################################################################
-
-Metrics/MethodLength:
-  CountComments: false
-  Max: 15

data/.travis.yml

@@ -1,27 +1,48 @@
 language: ruby
+sudo: false
+
+services:
+  - redis-server
+
+cache: bundler
+
+before_install:
+  - gem update --system
+  - gem --version
+  - gem install bundler --no-rdoc --no-ri
+  - bundle --version
+
+install: bundle install --without development
+
+env:
+  - WITH_REDIS_NAMESPACE="false"
+  - WITH_REDIS_NAMESPACE="true"
+
 rvm:
-  - 2.2.5
-  - 2.3.1
-  - ruby-head
-  - jruby-9.0.5.0
-  - jruby-head
-  - rbx-2
+  - 2.2.6
+  - 2.3.3
+  - 2.4.0
+
 matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: jruby-9.0.5.0
-    - rvm: jruby-head
-    - rvm: rbx-2
   fast_finish: true
+  include:
+    -
+      rvm: 2.4.0
+      env: SUITE="rubocop"
+      gemfile: Gemfile
+    -
+      rvm: jruby-9.1.8.0
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug" WITH_REDIS_NAMESPACE="false"
+      gemfile: Gemfile
+    -
+      rvm: jruby-9.1.8.0
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug" WITH_REDIS_NAMESPACE="true"
+      gemfile: Gemfile
+  allow_failures:
+    -
+      rvm: jruby-9.1.8.0
+
 gemfile:
   - gemfiles/sidekiq_4.0.gemfile
   - gemfiles/sidekiq_4.1.gemfile
-  - gemfiles/sidekiq_latest.gemfile
-env:
-  - WITH_REDIS_NAMESPACE=0
-  - WITH_REDIS_NAMESPACE=1
-before_install:
-  - gem install bundler -v 1.10.6
-services:
-  - redis-server
-sudo: false
+  - gemfiles/sidekiq_4.2.gemfile

data/Appraisals

@@ -6,6 +6,6 @@ appraise "sidekiq-4.1" do
   gem "sidekiq", "~> 4.1.0"
 end
 
-appraise "sidekiq-latest" do
-  gem "sidekiq"
+appraise "sidekiq-4.2" do
+  gem "sidekiq", "~> 4.2.0"
 end

data/CHANGES.md

@@ -1,3 +1,9 @@
+## 0.6.7 (2017-03-21)
+
+* Fix fetcher causing workers starvation upon low concurrency thresholds.
+  ([@ixti])
+
+
 ## 0.6.6 (2016-10-16)
 
 * [#24](https://github.com/sensortower/sidekiq-throttled/pull/24)

data/Gemfile

@@ -4,9 +4,16 @@ source "https://rubygems.org"
 
 gem "appraisal"
 gem "rake"
-gem "rspec"
-gem "rubocop", "~> 0.42.0", :require => false
 gem "redis-namespace", :require => false
+gem "rspec"
+gem "rubocop", "~> 0.47.0", :require => false
+gem "sidekiq"
+
+group :development do
+  gem "guard",         :require => false
+  gem "guard-rspec",   :require => false
+  gem "guard-rubocop", :require => false
+end
 
 group :test do
   gem "coveralls", :require => false

data/Guardfile

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+group :red_green_refactor, :halt_on_fail => true do
+  guard :rspec, :cmd => "bundle exec rspec --no-profile" do
+    require "guard/rspec/dsl"
+    dsl = Guard::RSpec::Dsl.new(self)
+
+    # Feel free to open issues for suggestions and improvements
+
+    # RSpec files
+    rspec = dsl.rspec
+    watch(rspec.spec_helper) { rspec.spec_dir }
+    watch(rspec.spec_support) { rspec.spec_dir }
+    watch(rspec.spec_files)
+
+    # Ruby files
+    ruby = dsl.ruby
+    dsl.watch_spec_files_for(ruby.lib_files)
+  end
+
+  guard :rubocop, :all_on_start => false do
+    watch(%r{.+\.rb$})
+    watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+  end
+end

data/LICENSE.md

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015-2016 SensorTower Inc.
+Copyright (c) 2015-2017 SensorTower Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/sidekiq-throttled.svg)](http://rubygems.org/gems/sidekiq-throttled)
 [![Build Status](https://travis-ci.org/sensortower/sidekiq-throttled.svg?branch=master)](https://travis-ci.org/sensortower/sidekiq-throttled)
 [![Code Climate](https://codeclimate.com/github/sensortower/sidekiq-throttled.svg?branch=master)](https://codeclimate.com/github/sensortower/sidekiq-throttled)
-[![Coverage Status](https://coveralls.io/repos/sensortower/sidekiq-throttled/badge.svg?branch=master&service=github)](https://coveralls.io/github/sensortower/sidekiq-throttled?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/sensortower/sidekiq-throttled/badge.svg?branch=master)](https://coveralls.io/github/sensortower/sidekiq-throttled?branch=master)
 [![API Docs](http://inch-ci.org/github/sensortower/sidekiq-throttled.svg?branch=master)](http://inch-ci.org/github/sensortower/sidekiq-throttled)
 
 Concurrency and threshold throttling for [Sidekiq][sidekiq].
@@ -122,8 +122,22 @@ some trouble.
 This library aims to support and is [tested against][travis] the following Ruby
 versions:
 
-* Ruby 2.2.x
+* Ruby 2.2.6+
 * Ruby 2.3.x
+* Ruby 2.4.x
+
+If something doesn't work on one of these versions, it's a bug.
+
+This library may inadvertently work (or seem to work) on other Ruby versions,
+however support will only be provided for the versions listed above.
+
+If you would like this library to support another Ruby version or
+implementation, you may volunteer to be a maintainer. Being a maintainer
+entails making sure all tests run and pass on that implementation. When
+something breaks on your implementation, you will be responsible for providing
+patches in a timely fashion. If critical issues for a particular implementation
+exist at the time of a major release, support for that Ruby version may be
+dropped.
 
 
 ## Supported Sidekiq Versions
@@ -132,6 +146,7 @@ This library aims to support work with following [Sidekiq][sidekiq] versions:
 
 * Sidekiq 4.0.x
 * Sidekiq 4.1.x
+* Sidekiq 4.2.x
 
 
 ## Contributing
@@ -144,9 +159,22 @@ This library aims to support work with following [Sidekiq][sidekiq] versions:
 * If we've accepted a patch, feel free to ask for commit access!
 
 
+## Development
+
+```
+bundle update
+appraisal install   # install dependencies for all gemfiles
+appraisal update    # update dependencies for all gemfiles
+appraisal rspec     # run rspec against each gemfile
+bundle exec rubocop # run static code analysis
+```
+
+Don't forget to run `appraisal update` after any changes to `Gemfile`.
+
+
 ## Copyright
 
-Copyright (c) 2015-2016 SensorTower Inc.
+Copyright (c) 2015-2017 SensorTower Inc.
 See LICENSE.md for further details.
 
 

data/Rakefile

@@ -4,7 +4,23 @@ require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
-require "rubocop/rake_task"
-RuboCop::RakeTask.new
+desc "Run RuboCop"
+task :rubocop do
+  require "rubocop"
+  result = RuboCop::CLI.new.run([])
+  abort("RuboCop failed!") if result.nonzero?
+end
 
-task :default => [:spec, :rubocop]
+namespace :rubocop do
+  desc "Auto-correct RuboCop offenses"
+  task :autocorrect do
+    require "rubocop"
+    result = RuboCop::CLI.new.run(["--auto-correct"])
+    abort("RuboCop failed!") if result.nonzero?
+  end
+end
+
+default_suite = ENV["CI"] ? :spec : %i(spec rubocop)
+named_suites  = { "rubocop" => :rubocop, "rspec" => :spec }
+
+task :default => named_suites.fetch(ENV["SUITE"], default_suite)

data/gemfiles/sidekiq_4.0.gemfile

@@ -4,11 +4,17 @@ source "https://rubygems.org"
 
 gem "appraisal"
 gem "rake"
-gem "rspec"
-gem "rubocop", "~> 0.42.0", :require => false
 gem "redis-namespace", :require => false
+gem "rspec"
+gem "rubocop", "~> 0.47.0", :require => false
 gem "sidekiq", "~> 4.0.0"
 
+group :development do
+  gem "guard", :require => false
+  gem "guard-rspec", :require => false
+  gem "guard-rubocop", :require => false
+end
+
 group :test do
   gem "coveralls", :require => false
   gem "rack-test"

data/gemfiles/sidekiq_4.1.gemfile

@@ -4,11 +4,17 @@ source "https://rubygems.org"
 
 gem "appraisal"
 gem "rake"
-gem "rspec"
-gem "rubocop", "~> 0.42.0", :require => false
 gem "redis-namespace", :require => false
+gem "rspec"
+gem "rubocop", "~> 0.47.0", :require => false
 gem "sidekiq", "~> 4.1.0"
 
+group :development do
+  gem "guard", :require => false
+  gem "guard-rspec", :require => false
+  gem "guard-rubocop", :require => false
+end
+
 group :test do
   gem "coveralls", :require => false
   gem "rack-test"

data/gemfiles/{sidekiq_latest.gemfile → sidekiq_4.2.gemfile}

@@ -4,10 +4,16 @@ source "https://rubygems.org"
 
 gem "appraisal"
 gem "rake"
-gem "rspec"
-gem "rubocop", "~> 0.42.0", :require => false
 gem "redis-namespace", :require => false
-gem "sidekiq"
+gem "rspec"
+gem "rubocop", "~> 0.47.0", :require => false
+gem "sidekiq", "~> 4.2.0"
+
+group :development do
+  gem "guard", :require => false
+  gem "guard-rspec", :require => false
+  gem "guard-rubocop", :require => false
+end
 
 group :test do
   gem "coveralls", :require => false

data/lib/sidekiq/throttled.rb

@@ -79,8 +79,8 @@ module Sidekiq
       # @return [Boolean]
       def throttled?(message)
         message = JSON.parse message
-        job = message.fetch("class".freeze) { return false }
-        jid = message.fetch("jid".freeze) { return false }
+        job = message.fetch("class") { return false }
+        jid = message.fetch("jid") { return false }
 
         Registry.get job do |strategy|
           return strategy.throttled?(jid, *message["args"])

data/lib/sidekiq/throttled/communicator.rb

@@ -30,7 +30,7 @@ module Sidekiq
       # Redis PUB/SUB channel name
       #
       # @see http://redis.io/topics/pubsub
-      CHANNEL_NAME = "sidekiq:throttled".freeze
+      CHANNEL_NAME = "sidekiq:throttled"
       private_constant :CHANNEL_NAME
 
       # Initializes singleton instance.

data/lib/sidekiq/throttled/communicator/callbacks.rb

@@ -61,7 +61,7 @@ module Sidekiq
                   callback.call(payload)
                 rescue => e
                   handle_exception(e, {
-                    :context => "sidekiq:throttled".freeze
+                    :context => "sidekiq:throttled"
                   })
                 end
               end

data/lib/sidekiq/throttled/communicator/listener.rb

@@ -69,12 +69,12 @@ module Sidekiq
           @subscribed = false
         rescue StandardError => e
           @subscribed = false
-          handle_exception(e, { :context => "sidekiq:throttled".freeze })
+          handle_exception(e, { :context => "sidekiq:throttled" })
           sleep 1
         rescue Exception => e # rubocop:disable Lint/RescueException
           @terminated = true
           @subscribed = false
-          handle_exception(e, { :context => "sidekiq:throttled".freeze })
+          handle_exception(e, { :context => "sidekiq:throttled" })
           raise
         end
 

data/lib/sidekiq/throttled/expirable_list.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require "monitor"
+
+module Sidekiq
+  module Throttled
+    # List that tracks when elements were added and enumerates over those not
+    # older than `ttl` seconds ago.
+    #
+    # ## Implementation
+    #
+    # Internally list holds an array of arrays. Thus ecah element is a tuple of
+    # timestamp (when element was added) and element itself:
+    #
+    #     [
+    #       [ 1234567890.12345, "default" ],
+    #       [ 1234567890.34567, "urgent" ],
+    #       [ 1234579621.56789, "urgent" ],
+    #       ...
+    #     ]
+    #
+    # It does not deduplicates elements. Eviction happens only upon elements
+    # retrieval (see {#each}).
+    #
+    # @private
+    class ExpirableList
+      include Enumerable
+
+      # @param ttl [Float] elements time-to-live in seconds
+      def initialize(ttl)
+        @ttl = ttl.to_f
+        @arr = []
+        @mon = Monitor.new
+      end
+
+      # Pushes given element into the list.
+      #
+      # @params element [Object]
+      # @return [ExpirableList] self
+      def <<(element)
+        @mon.synchronize { @arr << [Time.now.to_f, element] }
+        self
+      end
+
+      # Evicts expired elements and calls the given block once for each element
+      # left, passing that element as a parameter.
+      #
+      # @yield [element]
+      # @return [Enumerator] if no block given
+      # @return [ExpirableList] self if block given
+      def each
+        return to_enum __method__ unless block_given?
+
+        @mon.synchronize do
+          horizon = Time.now.to_f - @ttl
+
+          # drop all elements older than horizon
+          @arr.shift while @arr[0] && @arr[0][0] < horizon
+
+          @arr.each { |x| yield x[1] }
+        end
+
+        self
+      end
+    end
+  end
+end

data/lib/sidekiq/throttled/fetch.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "sidekiq"
+require "sidekiq/throttled/expirable_list"
 require "sidekiq/throttled/fetch/unit_of_work"
 require "sidekiq/throttled/queues_pauser"
 require "sidekiq/throttled/queue_name"
@@ -11,11 +12,14 @@ module Sidekiq
     #
     # @private
     class Fetch
+      # Timeout to sleep between fetch retries in case of no job received,
+      # as well as timeout to wait for redis to give us something to work.
       TIMEOUT = 2
-      private_constant :TIMEOUT
 
       # Initializes fetcher instance.
       def initialize(options)
+        @paused = ExpirableList.new(TIMEOUT)
+
         @strict = options[:strict]
         @queues = options[:queues].map { |q| QueueName.expand q }
 
@@ -33,7 +37,7 @@ module Sidekiq
         return work unless work.throttled?
 
         work.requeue_throttled
-        sleep TIMEOUT
+        @paused << QueueName.expand(work.queue_name)
 
         nil
       end
@@ -78,7 +82,7 @@ module Sidekiq
       # @param [Array<String>] queues
       # @return [Array<String>]
       def filter_queues(queues)
-        QueuesPauser.instance.filter(queues)
+        QueuesPauser.instance.filter(queues) - @paused.to_a
       end
     end
   end

data/lib/sidekiq/throttled/middleware.rb

@@ -12,8 +12,8 @@ module Sidekiq
       def call(_worker, msg, _queue)
         yield
       ensure
-        Registry.get msg["class".freeze] do |strategy|
-          strategy.finalize!(msg["jid".freeze], *msg["args"])
+        Registry.get msg["class"] do |strategy|
+          strategy.finalize!(msg["jid"], *msg["args"])
         end
       end
     end

data/lib/sidekiq/throttled/queue_name.rb

@@ -27,7 +27,7 @@ module Sidekiq
         # @param [String]
         # @return [String]
         def normalize(queue)
-          queue.sub(QUEUE_NAME_PREFIX_RE, "".freeze)
+          queue.sub(QUEUE_NAME_PREFIX_RE, "")
         end
 
         # Prepends `queue:` prefix to given `queue` name.
@@ -38,7 +38,7 @@ module Sidekiq
         # @param [String] queue Queue name
         # @return [String]
         def expand(queue)
-          "queue:#{queue}".freeze
+          "queue:#{queue}"
         end
       end
     end

data/lib/sidekiq/throttled/queues_pauser.rb

@@ -19,19 +19,19 @@ module Sidekiq
       # Redis key of Set with paused queues.
       #
       # @return [String]
-      PAUSED_QUEUES = "throttled:X:paused_queues".freeze
+      PAUSED_QUEUES = "throttled:X:paused_queues"
       private_constant :PAUSED_QUEUES
 
       # {Communicator} message used to notify that queue needs to be paused.
       #
       # @return [String]
-      PAUSE_MESSAGE = "pause".freeze
+      PAUSE_MESSAGE = "pause"
       private_constant :PAUSE_MESSAGE
 
       # {Communicator} message used to notify that queue needs to be resumed.
       #
       # @return [String]
-      RESUME_MESSAGE = "resume".freeze
+      RESUME_MESSAGE = "resume"
       private_constant :RESUME_MESSAGE
 
       # Initializes singleton instance.

data/lib/sidekiq/throttled/strategy/concurrency.rb

@@ -23,7 +23,7 @@ module Sidekiq
         # @param [#to_i] ttl Concurrency lock TTL in seconds.
         # @param [Proc] key_suffix Dynamic key suffix generator.
         def initialize(strategy_key, limit:, ttl: 900, key_suffix: nil)
-          @base_key   = "#{strategy_key}:concurrency".freeze
+          @base_key   = "#{strategy_key}:concurrency"
           @limit      = limit
           @ttl        = ttl.to_i
           @key_suffix = key_suffix

data/lib/sidekiq/throttled/strategy/script.rb

@@ -15,11 +15,11 @@ module Sidekiq
       # @private
       class Script
         # Script load command
-        LOAD = "load".freeze
+        LOAD = "load"
         private_constant :LOAD
 
         # Redis error fired when script ID is unkown
-        NOSCRIPT = "NOSCRIPT".freeze
+        NOSCRIPT = "NOSCRIPT"
         private_constant :NOSCRIPT
 
         # LUA script source.
@@ -48,8 +48,7 @@ module Sidekiq
             #   changed in redis, which is not likely gonna happen.
             unless @digest == digest
               if @logger
-                @logger.warn \
-                  "Unexpected script SHA1 digest: " \
+                @logger.warn "Unexpected script SHA1 digest: " \
                   "#{digest.inspect} (expected: #{@digest.inspect})"
               end
 

data/lib/sidekiq/throttled/strategy/threshold.rb

@@ -35,7 +35,7 @@ module Sidekiq
         # @param [#to_f, #call] :period Period in seconds.
         # @param [Proc] key_suffix Dynamic key suffix generator.
         def initialize(strategy_key, limit:, period:, key_suffix: nil)
-          @base_key   = "#{strategy_key}:threshold".freeze
+          @base_key   = "#{strategy_key}:threshold"
           @limit      = limit
           @period     = period
           @key_suffix = key_suffix

data/lib/sidekiq/throttled/version.rb

@@ -3,6 +3,6 @@
 module Sidekiq
   module Throttled
     # Gem version
-    VERSION = "0.6.6".freeze
+    VERSION = "0.6.7"
   end
 end

data/lib/sidekiq/throttled/web/stats.rb

@@ -37,10 +37,9 @@ module Sidekiq
         # @return [String]
         def colorize_count(int, max)
           percentile = 100.00 * int / max
-          lvl = case
-                when 80 <= percentile then "danger"
-                when 60 <= percentile then "warning"
-                else                       "success"
+          lvl = if    80 <= percentile then "danger"
+                elsif 60 <= percentile then "warning"
+                else                        "success"
                 end
 
           %(<span class="label label-#{lvl}">#{int}</span>)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-throttled
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.6.7
 platform: ruby
 authors:
 - Alexey V Zapparov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-16 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -48,23 +48,26 @@ files:
 - ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.todo.yml"
 - ".rubocop.yml"
 - ".travis.yml"
 - ".yardopts"
 - Appraisals
 - CHANGES.md
 - Gemfile
+- Guardfile
 - LICENSE.md
 - README.md
 - Rakefile
 - gemfiles/sidekiq_4.0.gemfile
 - gemfiles/sidekiq_4.1.gemfile
-- gemfiles/sidekiq_latest.gemfile
+- gemfiles/sidekiq_4.2.gemfile
 - lib/sidekiq/throttled.rb
 - lib/sidekiq/throttled/communicator.rb
 - lib/sidekiq/throttled/communicator/callbacks.rb
 - lib/sidekiq/throttled/communicator/listener.rb
 - lib/sidekiq/throttled/errors.rb
+- lib/sidekiq/throttled/expirable_list.rb
 - lib/sidekiq/throttled/fetch.rb
 - lib/sidekiq/throttled/fetch/unit_of_work.rb
 - lib/sidekiq/throttled/middleware.rb
@@ -104,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: Concurrency and threshold throttling for Sidekiq.