sidekiq-throttled 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 921d7e62de113744a3a0c9a6f7a1d6f028597349
-  data.tar.gz: 68c41f87d3174e5bee4f32f74e6bf8f3b1cc1e57
+  metadata.gz: 77157db5b942df1a256b541b48cf882c0fb5fb9d
+  data.tar.gz: ec125a7c26dbe885913a7c0b0ef4f104f9f6bfb5
 SHA512:
-  metadata.gz: f7080abc6b8ba73a1472a47c855973dcefccd610ccff81959719919f5e12ce47890b43d1ae9d8efe4e878b3f94a052eee35c864f7a735bd7317b9f1ad7507559
-  data.tar.gz: 1b5c82fb79e87e4e040c729bcfdd15c98177d210af174096c846e8e7b19f17c3576069e1bde3130594c6f87c6fd1648192fb122f287bf4d1b94fb104c364a3fd
+  metadata.gz: d162a63285e5959673f6d497bc5f5d54726279c879f8835a46ff79bd249b71c36516fc119dc93391a772ccb046d4ce6b018cc60db813cd9c33daf56eb40006fd
+  data.tar.gz: d063e884b5d7bf613b64b53c14c410c2b64e995102a012363152ee907307d501f4af73fe5926828b3eaa3e3f17358cc78d46575cf343b662addfd6ea25d1ad6e

data/.rubocop.yml

@@ -15,6 +15,9 @@ Style/BracesAroundHashParameters:
 Style/Documentation:
   Enabled: false
 
+Style/EmptyCaseCondition:
+  Enabled: false
+
 Style/EmptyLineBetweenDefs:
   AllowAdjacentOneLineDefs: true
 

data/CHANGES.md

@@ -1,3 +1,10 @@
+## 0.3.1 (2016-05-15)
+
+* Precalculate LUA script digests to reduce bandwidth upon nodes reload
+  _(which might (and might not) happen if you run thousands of nodes)_.
+  ([@ixti])
+
+
 ## 0.3.0 (2016-05-02)
 
 * [#1](https://github.com/sensortower/sidekiq-throttled/issues/1):

data/lib/sidekiq/throttled/strategy/script.rb

@@ -1,4 +1,9 @@
 # frozen_string_literal: true
+
+require "digest/sha1"
+
+require "sidekiq"
+
 module Sidekiq
   module Throttled
     class Strategy
@@ -17,15 +22,25 @@ module Sidekiq
         NOSCRIPT = "NOSCRIPT".freeze
         private_constant :NOSCRIPT
 
+        # LUA script source.
+        # @return [String]
+        attr_reader :source
+
+        # LUA script SHA1 digest.
+        # @return [String]
+        attr_reader :digest
+
         # @param [#to_s] source Lua script
-        def initialize(source)
+        # @paral [Logger] logger
+        def initialize(source, logger: Sidekiq.logger)
           @source = source.to_s.strip.freeze
-          @sha    = nil
+          @digest = Digest::SHA1.hexdigest(@source).freeze
+          @logger = logger
         end
 
         # Executes script and returns result of execution
         def eval(*args)
-          Sidekiq.redis { |conn| conn.evalsha(@sha, *args) }
+          Sidekiq.redis { |conn| conn.evalsha(@digest, *args) }
         rescue => e
           raise unless e.message.include? NOSCRIPT
           load_and_eval(*args)
@@ -36,8 +51,21 @@ module Sidekiq
         # Loads script into redis cache and executes it.
         def load_and_eval(*args)
           Sidekiq.redis do |conn|
-            @sha = conn.script(LOAD, @source)
-            conn.evalsha(@sha, *args)
+            digest = conn.script(LOAD, @source)
+
+            # XXX: this may happen **ONLY** if script digesting will be
+            #   changed in redis, which is not likely gonna happen.
+            unless @digest == digest
+              if @logger
+                @logger.warn \
+                  "Unexpected script SHA1 digest: " \
+                  "#{digest.inspect} (expected: #{@digest.inspect})"
+              end
+
+              @digest = digest.freeze
+            end
+
+            conn.evalsha(@digest, *args)
           end
         end
       end

data/lib/sidekiq/throttled/version.rb

@@ -2,6 +2,6 @@
 module Sidekiq
   module Throttled
     # Gem version
-    VERSION = "0.3.0".freeze
+    VERSION = "0.3.1".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-throttled
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Alexey V Zapparov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-02 00:00:00.000000000 Z
+date: 2016-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq