sidekiq-status 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac470dbfaa9bdccc0ef97b932f5b3dd713001063c6b22617a72976564a740901
-  data.tar.gz: 7e0bf255bce4f090a9238892185486aec556949ffb629d5879758e8302e38cd0
+  metadata.gz: b7b21776f1059a82b3a04c1e81639bcfba2c9184a00906688639333b2ee0df42
+  data.tar.gz: 06ffc2506014272d4a40272cc3204696efed21fee426000da8b6c3a6c5e183d9
 SHA512:
-  metadata.gz: cd389c60190a3cfd9b4b31c382ef6f564b62dba8a2bcdec201451d06c53ecad7f653e141aa663600ddd614bb68b5fb2a888ecd47b58660db2d5b381bb90ef438
-  data.tar.gz: c2b36634db5c27605d82c0120048f76e90c0597d0a66b1b79dbf9529250ae0b6bab06b4ea8cc145053a23046560d1bdc2e05c335bc5c9474b6adc18192a821dc
+  metadata.gz: a0f173c573f137b0626b9a76d8977e4d536083e685d376f8ea6201a9d9ed8f48b793f3e59b5f06e57c0c518210ffe7c1fefebbfce9ea4033e77a270eab73d9f1
+  data.tar.gz: 4f963ddaaa7f5a205fc9b6927ed994734f177a6438dd893ba2df435aa626c15614c3676b33d1feaaea03c341cfedb7e344e1a862e004acbd457ae7f9347cabd9

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+**Version 1.1.0**
++ Fixes the use case of multiple services sharing the same redis instance (#135)
+
 **Version 1.0.2**
 + Fixes status not being set to `:failed` after retries
 

data/lib/sidekiq-status/client_middleware.rb

@@ -21,10 +21,16 @@ module Sidekiq::Status
 
       # Determine the actual job class
       klass = msg["args"][0]["job_class"] || worker_class rescue worker_class
-      job_class = klass.is_a?(Class) ? klass : Module.const_get(klass)
+      job_class = if klass.is_a?(Class)
+                    klass
+                  elsif Module.const_defined?(klass)
+                    Module.const_get(klass)
+                  else
+                    nil
+                  end
 
       # Store data if the job is a Sidekiq::Status::Worker
-      if job_class.ancestors.include?(Sidekiq::Status::Worker)
+      if job_class && job_class.ancestors.include?(Sidekiq::Status::Worker)
         initial_metadata = {
           jid: msg['jid'],
           status: :queued,

data/lib/sidekiq-status/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Status
-    VERSION = '1.0.2'
+    VERSION = '1.1.0'
   end
 end

data/spec/lib/sidekiq-status_spec.rb

@@ -148,6 +148,16 @@ describe Sidekiq::Status do
       expect_2_jobs_ttl_covers 1..Sidekiq::Status::DEFAULT_EXPIRY
     end
 
+    it "does jobs without a known class" do
+      seed_secure_random_with_job_ids
+      start_server(:expiration => expiration_param) do
+        expect {
+          Sidekiq::Client.new(Sidekiq.redis_pool).
+            push("class" => "NotAKnownClass", "args" => [])
+        }.to_not raise_error
+      end
+    end
+
     it "retries failed jobs" do
       allow(SecureRandom).to receive(:hex).and_return(retried_job_id)
       start_server do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-status
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Evgeniy Tsvigun
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-19 00:00:00.000000000 Z
+date: 2018-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq