sidekiq-scheduler 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 361fb1b313b057028b848c5459f6b78949d9e017
-  data.tar.gz: 0a12681343204dc62437c57b6865184d9ad3bebe
+  metadata.gz: f1853ea52af3b5ac315998b85d0e0bdfe7b4a609
+  data.tar.gz: 8d1a8da664bc78daf8c3006e3649ac983ffe5170
 SHA512:
-  metadata.gz: 814400614b1fabde47d39503eb586dfcc0e4e881bef9531a3a0b5047015b932a202e3f5c0ea367b9f753c0458adfd4d2d5557cbd607ca4f5cd2e9d8b580e033a
-  data.tar.gz: ba567b96542baf134f78509f649201772730d79139a76812dea2ca7d5545d014281a5c1d7656dd8688185e1ce9858010fc4e8e8b2c22617eec5e25b808208c87
+  metadata.gz: eaf1a2503d7dfad91e180ad3d46124d9b243f0abd16bd5ecdeed1d927a0d1da9069b32387c7a3c86ed3daafe4ddfed637513df34d20aa0ff95e2114bccbbaec8
+  data.tar.gz: 2aeaecd846736d06d6100149b87f57562870f74caec307e7054b2ac9fab3d8de0f9eb0390dba0ef66110a4dedc8dc13f6425804bf4d73342e7614aa62f1dd4d0

data/README.md

@@ -4,24 +4,32 @@
   </a>
 </p>
 
-## Note
-
-The master branch and releases from 1.0 are compatible with sidekiq ~> 3, for sidekiq ~> 2 support
-use versions ~> 0.
-
-## Description
+<p align="center">
+  <a href="https://badge.fury.io/rb/sidekiq-scheduler">
+    <img src="https://badge.fury.io/rb/sidekiq-scheduler.png" alt="Gem Version">
+  </a>
+  <a href="https://codeclimate.com/github/moove-it/sidekiq-scheduler">
+    <img src="https://codeclimate.com/github/moove-it/sidekiq-scheduler/badges/gpa.svg" alt="Code Climate">
+  </a>
+  <a href="https://travis-ci.org/moove-it/sidekiq-scheduler">
+    <img src="https://api.travis-ci.org/moove-it/sidekiq-scheduler.svg?branch=master" alt="Build Status">
+  </a>
+  <a href="https://coveralls.io/github/moove-it/sidekiq-scheduler?branch=master">
+    <img src="https://coveralls.io/repos/moove-it/sidekiq-scheduler/badge.svg?branch=master&service=github" alt="Coverage Status">
+  </a>
+  <a href="https://inch-ci.org/github/moove-it/sidekiq-scheduler">
+    <img src="https://inch-ci.org/github/moove-it/sidekiq-scheduler.svg?branch=master" alt="Documentation Coverage">
+  </a>
+  <a href="http://www.rubydoc.info/github/moove-it/sidekiq-scheduler">
+    <img src="https://img.shields.io/badge/yard-docs-blue.svg" alt="Documentation">
+  </a>
+</p>
 
 sidekiq-scheduler is an extension to [Sidekiq](http://github.com/mperham/sidekiq)
 that adds support for running scheduled.
 
 Scheduled jobs are like cron jobs, recurring on a regular basis.
 
-### Documentation
-
-This README covers what most people need to know. If you're looking for
-details on individual methods, you might want to try the [rdoc](http://rdoc.info/github/moove-it/sidekiq-scheduler/master/frames).
-
-
 ## Installation
 
 Add this to your Gemfile:
@@ -41,7 +49,7 @@ and the execute:
 sidekiq -r created_file_path.rb
 ```
 
-Look at [Loading the schedule][https://github.com/moove-it/sidekiq-scheduler/tree/0.x#loading-the-schedule]
+Look at [Loading the schedule](https://github.com/moove-it/sidekiq-scheduler/#loading-the-schedule)
 for information on how to load your schedule.
 
 You can add sidekiq-scheduler configuration options to sidekiq.yml config file.
@@ -49,6 +57,30 @@ Available options are:
 
     :schedule: <the schedule to be run>
     :dynamic: <if true the schedule can be modified in runtime>
+    :enabled: <disables scheduler if true [true by default]>
+
+## Manage tasks from Unicorn/Rails server
+
+For example, if you want start sidekiq-scheduler only from Unicorn/Rails, but not from Sidekiq you can write something like this in initializer:
+
+```ruby
+# config/initializers/sidekiq_scheduler.rb
+require 'sidekiq/scheduler'
+
+puts "Sidekiq.server? is #{Sidekiq.server?.inspect}"
+puts "defined?(Rails::Server) is #{defined?(Rails::Server).inspect}"
+puts "defined?(Unicorn) is #{defined?(Unicorn).inspect}"
+
+if Rails.env == 'production' && (defined?(Rails::Server) || defined?(Unicorn))
+  Sidekiq.schedule = YAML
+    .load_file(File.expand_path('../../../config/scheduler.yml', __FILE__))
+  Sidekiq::Scheduler.reload_schedule!
+else
+  Sidekiq::Scheduler.enabled = false
+  puts "Sidekiq::Scheduler.enabled is #{Sidekiq::Scheduler.enabled.inspect}"
+end
+```
+
 
 ## Scheduled Jobs (Recurring Jobs)
 

data/Rakefile

@@ -20,9 +20,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-
-
-
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'
@@ -34,5 +31,4 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = false
 end
 
-
-task :default => :test
+task default: :test

data/lib/sidekiq-scheduler.rb

@@ -7,9 +7,10 @@ Sidekiq.configure_server do |config|
 
   config.on(:startup) do
     scheduler_options = {
-      :scheduler => config.options.fetch(:scheduler, true),
-      :dynamic => config.options.fetch(:dynamic, false),
-      :schedule => config.options.fetch(:schedule, nil)
+      scheduler: config.options.fetch(:scheduler, true),
+      dynamic:   config.options.fetch(:dynamic, false),
+      enabled:   config.options.fetch(:enabled, true),
+      schedule:  config.options.fetch(:schedule, nil)
     }
 
     schedule_manager = SidekiqScheduler::Manager.new(scheduler_options)
@@ -21,4 +22,5 @@ Sidekiq.configure_server do |config|
     config.options[:schedule_manager].stop
   end
 
-end
+end
+

data/lib/sidekiq-scheduler/capistrano.rb

@@ -1,35 +1,54 @@
 Capistrano::Configuration.instance.load do
-  before "deploy",        "sidekiq_scheduler:quiet"
-  after "deploy:stop",    "sidekiq_scheduler:stop"
-  after "deploy:start",   "sidekiq_scheduler:start"
-  after "deploy:restart", "sidekiq_scheduler:restart"
+  before 'deploy',         'sidekiq_scheduler:quiet'
+  after  'deploy:stop',    'sidekiq_scheduler:stop'
+  after  'deploy:start',   'sidekiq_scheduler:start'
+  after  'deploy:restart', 'sidekiq_scheduler:restart'
 
   _cset(:sidekiq_timeout) { 10 }
   _cset(:sidekiq_role) { :app }
 
   namespace :sidekiq_scheduler do
 
-    desc "Quiet sidekiq-scheduler with sidekiq (stop accepting new work)"
-    task :quiet, :roles => lambda { fetch(:sidekiq_role) } do
-      run "cd #{current_path} && if [ -f #{current_path}/tmp/pids/sidekiq.pid ]; then #{fetch(:bundle_cmd, "bundle")} exec sidekiqctl quiet #{current_path}/tmp/pids/sidekiq.pid ; fi"
+    desc 'Quiet sidekiq-scheduler with sidekiq (stop accepting new work)'
+    task :quiet, roles: lambda { fetch(:sidekiq_role) } do
+      bundle_cmd = fetch(:bundle_cmd, 'bundle')
+      pid_file = "#{current_path}/tmp/pids/sidekiq.pid"
+      quiet_cmd = "#{bundle_cmd} exec sidekiqctl quiet #{pid_file}"
+
+      run "cd #{current_path} && if [ -f #{pid_file} ]; then #{quiet_cmd} ; fi"
     end
 
-    desc "Stop sidekiq-scheduler with sidekiq"
-    task :stop, :roles => lambda { fetch(:sidekiq_role) } do
-      run "cd #{current_path} && if [ -f #{current_path}/tmp/pids/sidekiq.pid ]; then #{fetch(:bundle_cmd, "bundle")} exec sidekiqctl stop #{current_path}/tmp/pids/sidekiq.pid #{fetch :sidekiq_timeout} ; fi"
+    desc 'Stop sidekiq-scheduler with sidekiq'
+    task :stop, roles: lambda { fetch(:sidekiq_role) } do
+      bundle_cmd = fetch(:bundle_cmd, 'bundle')
+      pid_file = "#{current_path}/tmp/pids/sidekiq.pid"
+      timeout = fetch(:sidekiq_timeout)
+      stop_cmd = "#{bundle_cmd} exec sidekiqctl stop #{pid_file} #{timeout}"
+
+      run "cd #{current_path} && if [ -f #{pid_file} ]; then #{stop_cmd} ; fi"
     end
 
-    desc "Start sidekiq-scheduler with sidekiq"
-    task :start, :roles => lambda { fetch(:sidekiq_role) } do
-      rails_env = fetch(:rails_env, "production")
-      run "cd #{current_path} ; nohup #{fetch(:bundle_cmd, "bundle")} exec sidekiq-scheduler -e #{rails_env} -C #{current_path}/config/sidekiq.yml -P #{current_path}/tmp/pids/sidekiq.pid >> #{current_path}/log/sidekiq.log 2>&1 &", :pty => false
+    desc 'Start sidekiq-scheduler with sidekiq'
+    task :start, roles: lambda { fetch(:sidekiq_role) } do
+      rails_env = fetch(:rails_env, 'production')
+      bundle_cmd = fetch(:bundle_cmd, 'bundle')
+      log_file = "#{current_path}/log/sidekiq.log 2>&1 &"
+      pid_file = "#{current_path}/tmp/pids/sidekiq.pid"
+      start_cmd  = "#{bundle_cmd} exec sidekiq-scheduler start "
+      start_cmd += "-e #{rails_env} "
+      start_cmd += "-C #{current_path}/config/sidekiq.yml "
+      start_cmd += "-P #{pid_file} "
+      exec_cmd = "nohup #{start_cmd}"
+
+      run "cd #{current_path} ; nohup #{exec_cmd} >> #{log_file}", pty: false
     end
 
-    desc "Restart sidekiq-scheduler with sidekiq"
-    task :restart, :roles => lambda { fetch(:sidekiq_role) } do
+    desc 'Restart sidekiq-scheduler with sidekiq'
+    task :restart, roles: lambda { fetch(:sidekiq_role) } do
       stop
       start
     end
 
   end
-end
+end
+

data/lib/sidekiq-scheduler/manager.rb

@@ -19,6 +19,7 @@ module SidekiqScheduler
     def initialize(options={})
       @enabled = options[:scheduler]
 
+      Sidekiq::Scheduler.enabled = options[:enabled]
       Sidekiq::Scheduler.dynamic = options[:dynamic] || false
       Sidekiq.schedule = options[:schedule] if options[:schedule]
     end
@@ -30,9 +31,9 @@ module SidekiqScheduler
     def start
       # Load the schedule into rufus
       # If dynamic is set, load that schedule otherwise use normal load
-      if @enabled && Sidekiq::Scheduler.dynamic
+      if @enabled && Sidekiq::Scheduler.dynamic && Sidekiq::Scheduler.enabled
         Sidekiq::Scheduler.reload_schedule!
-      elsif @enabled
+      elsif @enabled && Sidekiq::Scheduler.enabled
         Sidekiq::Scheduler.load_schedule!
       end
     end

data/lib/sidekiq-scheduler/version.rb

@@ -1,5 +1,5 @@
 module SidekiqScheduler
 
-  VERSION = '1.2.2'
+  VERSION = '1.2.3'
 
 end

data/lib/sidekiq/scheduler.rb

@@ -16,7 +16,10 @@ module Sidekiq
 
     class << self
 
-      # If set, will try to update the schedule in the loop
+      # Set to enable or disable the scheduler.
+      attr_accessor :enabled
+
+      # Set to update the schedule in runtime in a given time period.
       attr_accessor :dynamic
 
     end
@@ -30,7 +33,7 @@ module Sidekiq
       if self.rufus_scheduler
         logger.info "Scheduling Info\tLast Run"
         scheduler_jobs = self.rufus_scheduler.all_jobs
-        scheduler_jobs.each do |k, v|
+        scheduler_jobs.each do |_, v|
           logger.info "#{v.t}\t#{v.last}\t"
         end
       end
@@ -39,22 +42,26 @@ module Sidekiq
     # Pulls the schedule from Sidekiq.schedule and loads it into the
     # rufus scheduler instance
     def self.load_schedule!
-      logger.info 'Loading Schedule'
+      if enabled
+        logger.info 'Loading Schedule'
 
-      # Need to load the schedule from redis for the first time if dynamic
-      Sidekiq.reload_schedule! if dynamic
+        # Need to load the schedule from redis for the first time if dynamic
+        Sidekiq.reload_schedule! if dynamic
 
-      logger.info 'Schedule empty! Set Sidekiq.schedule' if Sidekiq.schedule.empty?
+        logger.info 'Schedule empty! Set Sidekiq.schedule' if Sidekiq.schedule.empty?
 
-      @@scheduled_jobs = {}
+        @@scheduled_jobs = {}
 
-      Sidekiq.schedule.each do |name, config|
-        self.load_schedule_job(name, config)
-      end
+        Sidekiq.schedule.each do |name, config|
+          self.load_schedule_job(name, config)
+        end
 
-      Sidekiq.redis { |r| r.del(:schedules_changed) }
+        Sidekiq.redis { |r| r.del(:schedules_changed) }
 
-      logger.info 'Schedules Loaded'
+        logger.info 'Schedules Loaded'
+      else
+        logger.info 'SidekiqScheduler is disabled'
+      end
     end
 
     # modify interval type value to value with options if options available
@@ -110,13 +117,13 @@ module Sidekiq
     # Returns true if the given schedule config hash matches the current
     # ENV['RAILS_ENV']
     def self.rails_env_matches?(config)
-      config['rails_env'] && ENV['RAILS_ENV'] && config['rails_env'].gsub(/\s/,'').split(',').include?(ENV['RAILS_ENV'])
+      config['rails_env'] && ENV['RAILS_ENV'] && config['rails_env'].gsub(/\s/, '').split(',').include?(ENV['RAILS_ENV'])
     end
 
     def self.handle_errors
       begin
         yield
-      rescue Exception => e
+      rescue StandardError => e
         logger.info "#{e.class.name}: #{e.message}"
       end
     end
@@ -157,9 +164,13 @@ module Sidekiq
     end
 
     def self.reload_schedule!
-      logger.info 'Reloading Schedule'
-      self.clear_schedule!
-      self.load_schedule!
+      if enabled
+        logger.info 'Reloading Schedule'
+        self.clear_schedule!
+        self.load_schedule!
+      else
+        logger.info 'SidekiqScheduler is disabled'
+      end
     end
 
     def self.update_schedule

data/test/lib/sidekiq/scheduler_test.rb

@@ -4,6 +4,7 @@ class ManagerTest < Minitest::Test
   describe 'Sidekiq::Scheduler' do
 
     before do
+      Sidekiq::Scheduler.enabled = true
       Sidekiq::Scheduler.dynamic = false
       Sidekiq.redis { |r| r.del(:schedules) }
       Sidekiq.redis { |r| r.del(:schedules_changed) }
@@ -11,6 +12,23 @@ class ManagerTest < Minitest::Test
       Sidekiq::Scheduler.send(:class_variable_set, :@@scheduled_jobs, {})
     end
 
+    it 'sidekiq-scheduler enabled option is working' do
+      Sidekiq::Scheduler.enabled = false
+      assert_equal(0, Sidekiq::Scheduler.rufus_scheduler.jobs.size)
+      Sidekiq.schedule = {
+        :some_ivar_job => {
+          'cron' => '* * * * *',
+          'class' => 'SomeIvarJob',
+          'args' => '/tmp'
+        }
+      }
+
+      Sidekiq::Scheduler.load_schedule!
+
+      assert_equal(0, Sidekiq::Scheduler.rufus_scheduler.jobs.size)
+      refute Sidekiq::Scheduler.scheduled_jobs.include?(:some_ivar_job)
+    end
+
     it 'enqueue constantizes' do
       # The job should be loaded, since a missing rails_env means ALL envs.
       ENV['RAILS_ENV'] = 'production'
@@ -170,7 +188,7 @@ class ManagerTest < Minitest::Test
         }
       )
 
-      assert_equal(1, Sidekiq::Scheduler.rufus_scheduler.all_jobs.size)
+      assert_equal(1, Sidekiq::Scheduler.rufus_scheduler.jobs.size)
       assert_equal(1, Sidekiq::Scheduler.scheduled_jobs.size)
       assert Sidekiq::Scheduler.scheduled_jobs.keys.include?('some_ivar_job')
     end
@@ -185,7 +203,7 @@ class ManagerTest < Minitest::Test
         }
       )
 
-      assert_equal(1, Sidekiq::Scheduler.rufus_scheduler.all_jobs.size)
+      assert_equal(1, Sidekiq::Scheduler.rufus_scheduler.jobs.size)
       assert_equal(1, Sidekiq::Scheduler.scheduled_jobs.size)
       assert Sidekiq::Scheduler.scheduled_jobs.keys.include?('some_ivar_job')
     end

data/test/lib/sidekiq/web_test.rb

@@ -34,18 +34,18 @@ class WebTest < MiniTest::Test
     it 'shows schedule' do
       get '/recurring-jobs'
 
-      assert_match /Foo Job/, last_response.body
-      assert_match /FooClass/, last_response.body
-      assert_match /0 \* \* \* \* US\/Eastern/, last_response.body
-      assert_match /default/, last_response.body
-      assert_match /\[42\]/, last_response.body
-      assert_match /Does foo things\./, last_response.body
-
-      assert_match /Bar Job/, last_response.body
-      assert_match /BarClass/, last_response.body
-      assert_match /1h/, last_response.body
-      assert_match /special/, last_response.body
-      assert_match /\[\"foo\", \"bar\"\]/, last_response.body
+      assert_match(/Foo Job/, last_response.body)
+      assert_match(/FooClass/, last_response.body)
+      assert_match(/0 \* \* \* \* US\/Eastern/, last_response.body)
+      assert_match(/default/, last_response.body)
+      assert_match(/\[42\]/, last_response.body)
+      assert_match(/Does foo things\./, last_response.body)
+
+      assert_match(/Bar Job/, last_response.body)
+      assert_match(/BarClass/, last_response.body)
+      assert_match(/1h/, last_response.body)
+      assert_match(/special/, last_response.body)
+      assert_match(/\[\"foo\", \"bar\"\]/, last_response.body)
     end
   end
-end
+end

data/test/schedule_test.rb

@@ -3,118 +3,78 @@ require 'test_helper'
 class ScheduleTest < Minitest::Test
 
   describe 'SidekiqScheduler::Schedule' do
+
+    def build_cron_hash
+      {
+        'cron'  => '* * * * *',
+        'class' => 'SomeIvarJob',
+        'args'  => '/tmp/75'
+      }
+    end
+
+    def only_cron_and_args
+      -> (key, _) { %w(cron args).include?(key) }
+    end
+
+    def job_from_redis(job_id)
+      MultiJson.decode(job_from_redis_without_decoding(job_id))
+    end
+
+    def job_from_redis_without_decoding(job_id)
+      Sidekiq.redis { |redis|
+        redis.hget(:schedules, job_id)
+      }
+    end
+
+    let(:cron_hash)    { build_cron_hash }
+    let(:job_id)       { 'my_ivar_job' }
+    let(:job_class_id) { 'SomeIvarJob' }
+
     it 'schedule= sets the schedule' do
       Sidekiq::Scheduler.dynamic = true
-      Sidekiq.schedule = {
-          'my_ivar_job' => {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/75'
-          }
-      }
 
-      assert_equal(
-          {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/75'
-          },
-          MultiJson.decode(Sidekiq.redis { |r|
-            r.hget(:schedules, 'my_ivar_job')
-          })
-      )
+      Sidekiq.schedule = {job_id => cron_hash}
+
+      assert_equal(cron_hash, job_from_redis(job_id))
     end
 
     it "schedule= uses job name as 'class' argument if it's missing" do
       Sidekiq::Scheduler.dynamic = true
-      Sidekiq.schedule = {
-          'SomeIvarJob' => {
-              'cron' => '* * * * *',
-              'args' => '/tmp/75'
-          }
-      }
 
-      assert_equal(
-          {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/75'
-          },
-          MultiJson.decode(Sidekiq.redis { |r| r.hget(:schedules, 'SomeIvarJob') })
-      )
-      assert_equal('SomeIvarJob', Sidekiq.schedule['SomeIvarJob']['class'])
+      Sidekiq.schedule = {job_class_id => cron_hash.select(&only_cron_and_args)}
+
+      assert_equal(cron_hash, job_from_redis(job_class_id))
+      assert_equal(job_class_id, Sidekiq.schedule[job_class_id]['class'])
     end
 
     it 'schedule= does not mutate argument' do
-      schedule = {
-          'SomeIvarJob' => {
-              'cron' => '* * * * *',
-              'args' => '/tmp/75'
-          }
-      }
+      schedule = {job_class_id => cron_hash.select(&only_cron_and_args)}
+
       Sidekiq.schedule = schedule
-      assert !schedule['SomeIvarJob'].key?('class')
+
+      assert !schedule[job_class_id].key?('class')
     end
 
     it 'set_schedule can set an individual schedule' do
-      Sidekiq.set_schedule(
-          'some_ivar_job',
-          {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/22'
-          }
-      )
-      assert_equal(
-          {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/22'
-          },
-          MultiJson.decode(Sidekiq.redis { |r| r.hget(:schedules, 'some_ivar_job') })
-      )
-      assert Sidekiq.redis { |r| r.sismember(:schedules_changed, 'some_ivar_job') }
+      Sidekiq.set_schedule(job_id, cron_hash)
+
+      assert_equal(cron_hash, job_from_redis(job_id))
+      assert Sidekiq.redis { |r| r.sismember(:schedules_changed, job_id) }
     end
 
     it 'get_schedule returns a schedule' do
-      Sidekiq.redis { |r| r.hset(
-          :schedules,
-          'some_ivar_job2',
-          MultiJson.encode(
-              {
-                  'cron' => '* * * * *',
-                  'class' => 'SomeIvarJob',
-                  'args' => '/tmp/33'
-              }
-          )
-      ) }
-      assert_equal(
-          {
-              'cron' => '* * * * *',
-              'class' => 'SomeIvarJob',
-              'args' => '/tmp/33'
-          },
-          Sidekiq.get_schedule('some_ivar_job2')
-      )
+      Sidekiq.redis { |r| r.hset(:schedules, job_id, MultiJson.encode(cron_hash)) }
+
+      assert_equal(cron_hash, Sidekiq.get_schedule(job_id))
     end
 
     it 'remove_schedule removes a schedule' do
-      Sidekiq.redis do |r|
-        r.hset(
-            :schedules,
-            'some_ivar_job3',
-            MultiJson.encode(
-                {
-                    'cron' => '* * * * *',
-                    'class' => 'SomeIvarJob',
-                    'args' => '/tmp/44'
-                }
-            )
-        )
-      end
-      Sidekiq.remove_schedule('some_ivar_job3')
-      assert_equal nil, Sidekiq.redis{ |r| r.hget(:schedules, 'some_ivar_job3') }
-      assert Sidekiq.redis{ |r| r.sismember(:schedules_changed, 'some_ivar_job3') }
+      Sidekiq.redis { |r| r.hset(:schedules, job_id, MultiJson.encode(cron_hash)) }
+
+      Sidekiq.remove_schedule(job_id)
+
+      assert_equal nil, job_from_redis_without_decoding(job_id)
+      assert Sidekiq.redis{ |r| r.sismember(:schedules_changed, job_id) }
     end
   end
-end
+end

data/test/test_helper.rb

@@ -1,6 +1,9 @@
 require 'simplecov'
 SimpleCov.start
 
+require 'coveralls'
+Coveralls.wear!
+
 require 'minitest/autorun'
 require 'minitest/pride'
 require 'minitest/autorun'
@@ -36,15 +39,15 @@ end
 
 class SomeJob
   include Sidekiq::Worker
-  def self.perform(repo_id, path)
+  def self.perform(_, _)
   end
 end
 
 class SomeIvarJob < SomeJob
-  sidekiq_options :queue => :ivar
+  sidekiq_options queue: :ivar
 end
 
 class SomeRealClass
   include Sidekiq::Worker
-  sidekiq_options :queue => :some_real_queue
-end
+  sidekiq_options queue: :some_real_queue
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-scheduler
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Morton Jonuschat
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 3.1.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 3.1.7
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -151,6 +151,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
@@ -197,7 +211,6 @@ files:
 - lib/sidekiq-scheduler/version.rb
 - lib/sidekiq-scheduler/web.rb
 - lib/sidekiq/scheduler.rb
-- lib/tasks/sidekiq-scheduler_tasks.rake
 - test/config.yml
 - test/fake_env.rb
 - test/lib/sidekiq/scheduler_test.rb

data/lib/tasks/sidekiq-scheduler_tasks.rake

@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :sidekiq-scheduler do
-#   # Task goes here
-# end