sidekiq-scheduler-notification 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb2405515818858c8a681df6596e84ff9e657953
-  data.tar.gz: 6305af531c86fa91c55fb10aa6fdc8414df52ab2
+  metadata.gz: d2a43e5a12ca474eade65060e2c3e018f617f7c2
+  data.tar.gz: 99f3548e7a38b6c0bd9a98e94cc8944b226bed9f
 SHA512:
-  metadata.gz: 296881cb631e7e35dbc20e57979c659e118f2b73555b64d80077b1d150da81d4355a5972ede59c729f404beeb0ccffedb2c969e8b8f78a096e48c6fb45d1e303
-  data.tar.gz: 5023df9529b12c51a6e5eb2649babf4cdd66e8de5a74ddb2d0bfb5317cdcb9e66250af7082d6f3122ecb7472d7499f3d624e4318e7c4c33e084fd5f319727b1e
+  metadata.gz: d4ad1805b6ce0345261dc3e73582802358f94ca293021ce141ab2e7035258bae8e0fc5110ac1f888c8dd308c735133234667821e90b22efa66c30321e12c499f
+  data.tar.gz: 0d45e09d2e9c18d0a864ec62dc0338c206bac4b20c795b2af684988f4f987a2b51dab7c2aabc7565a7118aabcfa7d75c9959e5941743ca4d3f3b6ccd01bc73b2

data/README.md

@@ -26,7 +26,7 @@ Added following configuration to initializer like `config/initializer/sidekiq.rb
 Sidekiq::Scheduler.notify_webhook = "https://hooks.slack.com/services/xxx/yyyzzz"
 ```
 
-and append `notification` variable like this
+and append `notification` variable into `schedule.yml` used by sidekiq-scheduler. like this
 
 ```yaml
 NotificationJob:
@@ -34,7 +34,13 @@ NotificationJob:
   notification: true
 ```
 
-You can get notification from sidekiq to slack channnel.
+Finally, You need to load `schedule.yml` at first before loading to this gem. You can add to read schedule.yml to sidekiq startup hook.
+
+```rb
+Sidekiq.options[:lifecycle_events][:startup].unshift -> {
+  Sidekiq.schedule = YAML.load_file(File.expand_path("../../../config/scheduler.yml",__FILE__))
+}
+```
 
 ## Development
 

data/lib/sidekiq/middleware/server/slack_notification.rb

@@ -6,8 +6,9 @@ module Sidekiq
       class SlackNotification
         def call(_worker, job, _queue)
           if Sidekiq::Scheduler.notify_classes.include? job['wrapped']
-            notifier ||= Slack::Notifier.new(Sidekiq::Scheduler.notify_webhook)
-            notifier.username = 'Sidekiq Notification'
+            notifier ||= Slack::Notifier.new(Sidekiq::Scheduler.notify_webhook) do
+              defaults username: 'Sidekiq Notification'
+            end
             begin
               notifier.ping "Start : #{job['wrapped']}"
               yield

data/lib/sidekiq/scheduler/notification/version.rb

@@ -1,7 +1,7 @@
 module Sidekiq
   class Scheduler
     module Notification
-      VERSION = "0.1.1"
+      VERSION = "0.2.0"
     end
   end
 end

data/sidekiq-scheduler-notification.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'sidekiq-scheduler'
-  spec.add_dependency 'slack-notifier'
+  spec.add_dependency 'slack-notifier', '>= 2'
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-scheduler-notification
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - SHIBATA Hiroshi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-23 00:00:00.000000000 Z
+date: 2017-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq-scheduler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -119,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Slack notification middleware for sidekiq-scheduler