sidekiq-promise 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42bd79021c80180e745f9955f20d79676cec7a0a
-  data.tar.gz: c83c3a33895da56df06b0d7e59bec12a60dd431d
+  metadata.gz: 65cb4f994852f81d01a64430041c30bc5b801a61
+  data.tar.gz: d9946fa79e57b00e79147dedb917a4f132e09e06
 SHA512:
-  metadata.gz: 5fae2380872872ed025174c8283d4673dee9454a67a60e7d6716e760cf1344b3e6f5df0d2e62bf64d17975a7e5a6b16c81a0b855d7bd2e534a80616a2b2ad1b5
-  data.tar.gz: 110ae879d59744fd1a21ffbf1dbdf034d243901348ab9877b21a4358c759bc2ab3b816e18438d16f290a79f9a802910d6b84ea54736b33ba0cc5ab94d5ba4e57
+  metadata.gz: 95cd8e902837931b931134b0f1ee81e206ec9f79899902b4a4db3263c18979b0d9df079c2431e1d3d2921d30ae977dd7d8fa613fa0e8bed0a0c2c95b12525f29
+  data.tar.gz: c7907bfa3d88b5a8f53aac87841f69bdc624a843b86f79616227040cb9aeed3273669b19d0c8cbe52decf0f9ec78f5bb448596bd028bf82007a8b9dc8ed2a81d

data/lib/sidekiq/promise/server_middleware.rb

@@ -4,13 +4,20 @@ module Sidekiq
 
       def call worker, job, queue
         job_dequeued job
-        yield
+        result = yield
+        result.raise if thenable? result
         job_completed job
       rescue Exception => e
         job_errored job, e
         raise e
       end
 
+      private
+
+      def thenable? obj
+        obj.respond_to?(:then) && obj.respond_to?(:fail)
+      end
+
     end
   end
 end

data/lib/sidekiq/promise/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Promise
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/spec/acceptance/promising_to_fail_worker_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe 'Promising to fail job as promise' do
+  before(:all) { start_worker }
+  after(:all)  { kill_worker }
+  before       { clear_jobs }
+  after        { clear_jobs }
+
+  let(:promise) { PromisingToFailWorker.as_promise }
+  subject { promise }
+
+  its(:final) { should_not be_resolved }
+  its(:final) { should be_rejected }
+
+  describe '#then' do
+    it 'does not yield' do
+      expect { |b| promise.final.then(&b) }.not_to yield_control
+    end
+  end
+
+  describe '#fail' do
+    it 'yields' do
+      expect { |b| promise.final.fail(&b) }.to yield_control
+    end
+  end
+end

data/spec/workers/promising_to_fail_worker.rb

@@ -0,0 +1,10 @@
+class PromisingToFailWorker
+  include Sidekiq::Promise
+
+  def perform
+    MrDarcy.promise do
+      sleep 0.5
+      reject "for the LOLs"
+    end
+  end
+end

data/spec/workers/promising_worker.rb

@@ -6,6 +6,6 @@ class PromisingWorker
       10.times.map do
         SleepyWorker.as_promise 1
       end
-    end.final
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-promise
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - James Harton
@@ -175,6 +175,7 @@ files:
 - spec/acceptance/crashing_job_spec.rb
 - spec/acceptance/failing_job_spec.rb
 - spec/acceptance/promising_job_spec.rb
+- spec/acceptance/promising_to_fail_worker_spec.rb
 - spec/lib/sidekiq/promise/client_middleware_spec.rb
 - spec/lib/sidekiq/promise/middleware_spec.rb
 - spec/lib/sidekiq/promise/server_middleware_spec.rb
@@ -185,6 +186,7 @@ files:
 - spec/support/mock_client_pool.rb
 - spec/support/sidekiq_helpers.rb
 - spec/workers/crashy_worker.rb
+- spec/workers/promising_to_fail_worker.rb
 - spec/workers/promising_worker.rb
 - spec/workers/raisey_worker.rb
 - spec/workers/sleepy_worker.rb
@@ -217,6 +219,7 @@ test_files:
 - spec/acceptance/crashing_job_spec.rb
 - spec/acceptance/failing_job_spec.rb
 - spec/acceptance/promising_job_spec.rb
+- spec/acceptance/promising_to_fail_worker_spec.rb
 - spec/lib/sidekiq/promise/client_middleware_spec.rb
 - spec/lib/sidekiq/promise/middleware_spec.rb
 - spec/lib/sidekiq/promise/server_middleware_spec.rb
@@ -227,6 +230,7 @@ test_files:
 - spec/support/mock_client_pool.rb
 - spec/support/sidekiq_helpers.rb
 - spec/workers/crashy_worker.rb
+- spec/workers/promising_to_fail_worker.rb
 - spec/workers/promising_worker.rb
 - spec/workers/raisey_worker.rb
 - spec/workers/sleepy_worker.rb