sidekiq-lock 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 592d4bf95b4bbd2cba2444898c5f6843c0a9112c6c45e018999af361b8a5ca73
-  data.tar.gz: 7b0a5614796a292af28fc0880915a76ac85ecfb8c669b07d57d5019d8f246342
+  metadata.gz: 94c0d6993d3e6f8c2acd6a63e2e78464ac974369138f6c20eeb91525d0b5ea13
+  data.tar.gz: 75437ca38c53bc825d0e6e77b8dc2ef64c5c42bb8802746f5fbacf1f91c9e4f5
 SHA512:
-  metadata.gz: ff115e3d009c6b6803e20326c2d84bf2286d9e4b652fe840b743596b8257919d7c54b3f1b9e1dcf2f9f1cba16af6541490464a77d55b52ff1b9407f28a7981f3
-  data.tar.gz: 0cf165b35136db26001b236837dcd7a831867fc81d8b81a3e14c2efe76edf41ade9cb5ba437b311b9ec1626af5aae176a3a09fde0c393ef5b949f2f5e5f8fa64
+  metadata.gz: 463adf7d4dbf5d468a1c795105a716d94fd6f77141e7c7f3d77a84076e4e222cc2b6fb57f64d5286bca6fc8b9491c4de891190fb3d255f1766acd879253220d0
+  data.tar.gz: c215cce1d79e99aaa28a04a5238aac165a8e5d36271a372b39067a80040109e5f64117114fdbfae227c5cb406f86cd46e554cfa6820978573abd1f08b04ada6d

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.6.0 (May 27, 2023)
+
+- support for Sidekiq 7 (thanks to [@stympy](https://github.com/stympy))
+- move CI pipelines to Github Actions - drop tests for everything below Sidekiq 5, run tests on redis 6.2 & 7.0 and ruby 2.6 - 3.1
+
 ## 0.5.0 (August 13, 2021)
 
 - maintenance - test on latest ruby versions (remove outdated rubies from build), add sidekiq 6 to build matrix, remove coveralls

data/README.md

@@ -1,11 +1,10 @@
 <p align="center">
-  <img width="300" height="210" src="https://github.com/emq/sidekiq-lock/raw/master/logo.png">
+  <img width="300" height="210" src="https://github.com/rwojsznis/sidekiq-lock/raw/main/logo.png">
 </p>
 
 # Sidekiq::Lock
 
-[![Code Climate](https://codeclimate.com/github/emq/sidekiq-lock.png)](https://codeclimate.com/github/emq/sidekiq-lock)
-[![Build Status](https://travis-ci.com/rwojsznis/sidekiq-lock.svg?branch=master)](https://travis-ci.com/rwojsznis/sidekiq-lock)
+[![Code Climate](https://codeclimate.com/github/rwojsznis/sidekiq-lock.png)](https://codeclimate.com/github/rwojsznis/sidekiq-lock)
 [![Gem Version](https://badge.fury.io/rb/sidekiq-lock.png)](http://badge.fury.io/rb/sidekiq-lock)
 
 **Note:** This is a _complete_ piece of software, it should work across all future sidekiq & ruby versions.

data/lib/sidekiq/lock/redis_lock.rb

@@ -28,13 +28,12 @@ module Sidekiq
       end
 
       def release!
-        Sidekiq.redis do |r|
-          begin
-            r.evalsha redis_lock_script_sha, keys: [name], argv: [value]
-          rescue Redis::CommandError
-            r.eval redis_lock_script, keys: [name], argv: [value]
-          end
-        end
+        # even if lock expired / was take over by another process
+        # it still means from our perspective that we released it
+        @acquired = false
+
+        # https://redis.io/commands/del/#return
+        release_lock == 1
       end
 
       def name
@@ -53,6 +52,27 @@ module Sidekiq
 
       attr_reader :options, :payload
 
+      def release_lock
+        # Sidekiq 7 uses redis-client gem, designed for redis 6+
+        if Sidekiq::VERSION >= '7'
+          Sidekiq.redis do |r|
+            begin
+              r.evalsha redis_lock_script_sha, [name], [value]
+            rescue RedisClient::CommandError
+              r.eval redis_lock_script, 1, [name], [value]
+            end
+          end
+        else
+          Sidekiq.redis do |r|
+            begin
+              r.evalsha redis_lock_script_sha, keys: [name], argv: [value]
+            rescue Redis::CommandError
+              r.eval redis_lock_script, keys: [name], argv: [value]
+            end
+          end
+        end
+      end
+
       def redis_lock_script_sha
         @lock_script_sha ||= Digest::SHA1.hexdigest redis_lock_script
       end

data/lib/sidekiq/lock/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Lock
-    VERSION = '0.5.0'
+    VERSION = '0.6.0'
   end
 end

data/test/lib/lock_test.rb

@@ -4,7 +4,7 @@ require 'open3'
 module Sidekiq
   describe Lock do
     it 'automatically loads lock middleware for sidekiq server' do
-      skip 'Sidekiq 2 does not print out middleware information' if Sidekiq::VERSION < '3.0.0'
+      skip 'Sidekiq 7+ does not print out middleware information' if Sidekiq::VERSION >= '7'
 
       cmd = 'sidekiq -r ./test/test_workers.rb -v'
       buffer = ''

data/test/lib/middleware_test.rb

@@ -4,7 +4,13 @@ module Sidekiq
   module Lock
     describe Middleware do
       before do
-        Sidekiq.redis = REDIS
+        if Sidekiq::VERSION >= '7'
+          Sidekiq.configure_server do |config|
+            config.redis = { url: REDIS_URL }
+          end
+        else
+          Sidekiq.redis = REDIS
+        end
         Sidekiq.redis { |c| c.flushdb }
         reset_lock_variable!
       end

data/test/lib/redis_lock_test.rb

@@ -4,12 +4,16 @@ module Sidekiq
   module Lock
     describe RedisLock do
       before do
-        Sidekiq.redis = REDIS
+        if Sidekiq::VERSION >= '7'
+          Sidekiq.configure_client do |config|
+            config.redis = { url: REDIS_URL }
+          end
+        else
+          Sidekiq.redis = REDIS
+        end
         Sidekiq.redis { |c| c.flushdb }
       end
 
-      let(:args) { [{'timeout' => 100, 'name' => 'test-lock'}, []] }
-
       it "raises an error on missing timeout&name values" do
         assert_raises ArgumentError do
           RedisLock.new({},[])
@@ -52,46 +56,59 @@ module Sidekiq
       end
 
       it "can acquire a lock" do
-        lock = RedisLock.new(*args)
+        lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
+        assert lock.acquire!
+      end
+
+      it "sets proper lock value on first and second acquire" do
+        lock = RedisLock.new({'timeout' => 1000, 'name' => 'test-lock', 'value' => 'lock value'}, [])
         assert lock.acquire!
+        assert_equal 'lock value', redis("get", lock.name)
+        assert lock.release!
+        # at this point script should be used from evalsha
+        assert lock.acquire!
+        assert_equal 'lock value', redis("get", lock.name)
+
+        redis("script", "flush")
+        assert lock.acquire!
+        assert_equal 'lock value', redis("get", lock.name)
       end
 
-      it "cannot aquire lock if it's already taken by other process/thread" do
-        faster_lock = RedisLock.new(*args)
+      it "cannot acquire lock if it's already taken by other process/thread" do
+        faster_lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
         assert faster_lock.acquire!
 
-        slower_lock = RedisLock.new(*args)
+        slower_lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
         refute slower_lock.acquire!
       end
 
       it "releases taken lock" do
-        lock = RedisLock.new(*args)
+        lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
         lock.acquire!
         assert redis("get", "test-lock")
 
-        lock.release!
+        assert lock.release!
         assert_nil redis("get", "test-lock")
       end
 
       it "releases lock taken by another process without deleting lock key" do
-        lock = RedisLock.new(*args)
+        lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
         lock.acquire!
         lock_value = redis("get", "test-lock")
         assert lock_value
         sleep 0.11 # timeout lock
 
-        new_lock = RedisLock.new(*args)
+        new_lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock'}, [])
         new_lock.acquire!
         new_lock_value = redis("get", "test-lock")
 
-        lock.release!
+        refute lock.release!
 
         assert_equal new_lock_value, redis("get", "test-lock")
       end
 
       it "releases taken lock" do
-        custom_args = [args.first.merge('value' => 'custom_value'), []]
-        lock = RedisLock.new(*custom_args)
+        lock = RedisLock.new({'timeout' => 100, 'name' => 'test-lock', 'value' => 'custom_value'}, [])
         lock.acquire!
         assert redis("get", "test-lock")
 

data/test/test_helper.rb

@@ -7,7 +7,8 @@ require 'test_workers'
 
 Sidekiq.logger.level = Logger::ERROR
 
-REDIS = Sidekiq::RedisConnection.create(url: 'redis://localhost/15')
+REDIS_URL = ENV['REDIS_URL'] || 'redis://localhost/15'
+REDIS = Sidekiq::RedisConnection.create(url: REDIS_URL)
 
 def redis(command, *args)
   Sidekiq.redis do |c|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-lock
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Rafal Wojsznis
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-13 00:00:00.000000000 Z
+date: 2023-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -66,20 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rack-test
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -153,7 +139,7 @@ homepage: https://github.com/emq/sidekiq-lock
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -168,16 +154,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.5
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Simple redis-based lock mechanism for your sidekiq workers
 test_files:
-- test/test_workers.rb
-- test/lib/worker_test.rb
+- test/lib/container_test.rb
+- test/lib/lock_test.rb
+- test/lib/middleware_test.rb
 - test/lib/redis_lock_test.rb
 - test/lib/testing/inline_test.rb
-- test/lib/middleware_test.rb
-- test/lib/lock_test.rb
-- test/lib/container_test.rb
+- test/lib/worker_test.rb
 - test/test_helper.rb
+- test/test_workers.rb