sidekiq-delay 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa257722d3cdc168a74ac49bf2d9dbfdad15299a
-  data.tar.gz: 7c51370d114aba1a1784bcd9e93a47a202fa609f
+  metadata.gz: 744b0e7a5d32a84f8d8920e70d5b9489f756434a
+  data.tar.gz: 7ca242145f24ee2ea4e6d83da579dcd1238a67da
 SHA512:
-  metadata.gz: 79842819024351dd00eae294890f8b06a10613176db1d1b3e8640d9bef891fc4e97707a21e71b3000506db976f5e338e8f260c88e0797954d4ba0d38ecdee54d
-  data.tar.gz: 24d9bac663bed6097aba8e9423334539dd0dffddfc33e52ac0d2a2cae3695ee3faa0e5b7f97fca84ffb2e683b21957777b1dc229c9d994ea686aee5d68f432dc
+  metadata.gz: 03329a323bf0b17ccc7ab1d205470a6c28d7d3f1354c9aab3a97ce8f5a2bd1504d8389b4ad10ba5d98e51274bd18ff71df4638441d96b7010d5e78c46ad3488f
+  data.tar.gz: 7f1d6a287f223a9bd51cbfa11d97e079c0feae6f291312b335fb488c4640e415bc627bfa2f627526fcc9096639f74afdd802178910f4f780d0c93a6e7231b674

data/.simplecov

@@ -0,0 +1,3 @@
+SimpleCov.start do
+  add_filter "/app/"
+end

data/Gemfile

@@ -4,9 +4,9 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in sidekiq-delay.gemspec
 gemspec
 
-gem 'coveralls', require: false
-
 group :test do
+  gem 'simplecov', require: false
+  gem 'coveralls', require: false
   gem "guard-rspec"
   gem "rb-fsevent", require: false
 end

data/Guardfile

@@ -3,7 +3,7 @@
 
 guard :rspec do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
 end
 

data/README.md

@@ -36,7 +36,7 @@ First you have to include `Sidekiq::Delay` at your model.
     field :name
 
     def play!
-      # it is a long task
+      # a long task
       sleep 3
     end
   end
@@ -59,12 +59,12 @@ It queues an job with model class, model id, method name and args. Later, at Sid
 
 What if you class doesn't respond to `find` or you want to use another `Sidekiq` plugin? You can easily write an **custom worker**. You have just to set your model to use it with `worker` method.
 
-Your worker just need to include `Sidekiq::Delay::DefaultStrategy` or extend `Sidekiq::Delay::DefaultWorker`.
+Your worker just need to include `Sidekiq::Delay::Strategy` or extend `Sidekiq::Delay::Worker`.
 
 ```ruby
   class TeamWorker
     include Sidekiq::Worker
-    include Sidekiq::Delay::DefaultStrategy
+    include Sidekiq::Delay::Strategy
 
     def record(klass, id)
       klass.custom_find(id)
@@ -84,7 +84,7 @@ Your worker just need to include `Sidekiq::Delay::DefaultStrategy` or extend `Si
     end
 
     def play!
-      # it is a long task
+      # a long task
       sleep 3
     end
   end

data/lib/sidekiq/delay.rb

@@ -1,13 +1,13 @@
 require "sidekiq"
-require "sidekiq/delay/version"
-require 'active_support/concern'
+require "active_support/concern"
+require "sidekiq/delay/worker"
 
 module Sidekiq
   module Delay
     extend ActiveSupport::Concern
 
     included do
-      @worker = DefaultWorker
+      @worker = Worker
     end
 
     def delay(options={})
@@ -22,21 +22,5 @@ module Sidekiq
         worker ? @worker = worker : @worker
       end
     end
-
-    module DefaultStrategy
-      def perform(yml)
-        ((klass, id), method_name, args) = YAML.load(yml)
-        record(klass, id).send(method_name, *args)
-      end
-
-      def record(klass, id)
-        klass.find(id)
-      end
-    end
-
-    class DefaultWorker
-      include Sidekiq::Worker
-      include DefaultStrategy
-    end
   end
 end

data/lib/sidekiq/delay/strategy.rb

@@ -0,0 +1,14 @@
+module Sidekiq
+  module Delay
+    module Strategy
+      def perform(yml)
+        ((klass, id), method_name, args) = YAML.load(yml)
+        record(klass, id).send(method_name, *args)
+      end
+
+      def record(klass, id)
+        klass.find(id)
+      end
+    end
+  end
+end

data/lib/sidekiq/delay/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module Delay
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/lib/sidekiq/delay/worker.rb

@@ -0,0 +1,10 @@
+require "sidekiq/delay/strategy"
+
+module Sidekiq
+  module Delay
+    class Worker
+      include Sidekiq::Worker
+      include Strategy
+    end
+  end
+end

data/spec/app/models/band.rb

@@ -6,7 +6,7 @@ class Band
 
   def play
     print 'Long running task...'
-    spleep 3
+    sleep 3
     print ' done!'
   end
 end

data/spec/app/models/team.rb

@@ -2,7 +2,7 @@ require 'sidekiq/delay'
 
 class TeamWorker
   include Sidekiq::Worker
-  include Sidekiq::Delay::DefaultStrategy
+  include Sidekiq::Delay::Strategy
 
   def record(klass, id)
     klass.find(id)

data/spec/sidekiq/delay/strategy_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+require "sidekiq/delay/strategy"
+
+describe Sidekiq::Delay::Strategy do
+  Game = Class.new
+  GameWorker = Class.new { include Sidekiq::Delay::Strategy }
+
+  subject(:worker) { GameWorker.new }
+
+  let(:game) { mock "Game", play: nil }
+  let(:yml) { YAML.dump([[ Game, 1 ], :play, [ "get lucky", 10, 20 ]]) }
+
+  context "#perfom" do
+    before { worker.stub(record: game) }
+
+    it "calls record to find instance" do
+      worker.should_receive(:record).with(Game, 1)
+      worker.perform(yml)
+    end
+
+    it "calls play on instance" do
+      game.should_receive(:play).with("get lucky", 10, 20)
+      worker.perform(yml)
+    end
+  end
+
+  context "#record" do
+    before { Game.stub(find: game) }
+
+    it "finds an instance at class" do
+      Game.should_receive(:find).with(1)
+      worker.record(Game, 1)
+    end
+  end
+end

data/spec/sidekiq/delay/worker_spec.rb

@@ -0,0 +1,12 @@
+require "spec_helper"
+require "sidekiq/delay/worker"
+
+describe Sidekiq::Delay::Worker do
+  subject { described_class }
+
+  let(:strategy) { Sidekiq::Delay::Strategy }
+  let(:worker) { Sidekiq::Worker }
+
+  its(:ancestors) { should include(strategy) }
+  its(:ancestors) { should include(worker) }
+end

data/spec/sidekiq/delay_spec.rb

@@ -1,23 +1,33 @@
 require "spec_helper"
 require 'sidekiq/testing'
+
+require 'sidekiq/delay'
 require 'app/models/band'
 require 'app/models/team'
 
 describe Sidekiq::Delay do
   context "with default worker" do
+    subject { Band }
     let(:band) { Band.new }
+    let(:worker) { Sidekiq::Delay::Worker }
+
+    its(:worker) { should eq(worker) }
 
-    it "queue an job at default queue" do
+    it "queues a job at default queue" do
       expect {
         band.delay.play
-      }.to change(Sidekiq::Delay::DefaultWorker.jobs, :size).by(1)
+      }.to change(Sidekiq::Delay::Worker.jobs, :size).by(1)
     end
   end
 
   context "with custom worker" do
+    subject { Team }
     let(:team) { Team.new }
+    let(:worker) { TeamWorker }
+
+    its(:worker) { should eq(worker) }
 
-    it "queue an job at default queue" do
+    it "queues a job at custom queue" do
       expect {
         team.delay.play
       }.to change(TeamWorker.jobs, :size).by(1)

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
-require 'coveralls'
 require 'sidekiq'
 require 'mongoid'
+require 'simplecov'
+require 'coveralls'
 
 Coveralls.wear!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-delay
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Daniel Libanori
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-17 00:00:00.000000000 Z
+date: 2013-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -104,6 +104,7 @@ extra_rdoc_files: []
 files:
 - .coveralls.yml
 - .gitignore
+- .simplecov
 - .travis.yml
 - Gemfile
 - Guardfile
@@ -111,11 +112,15 @@ files:
 - README.md
 - Rakefile
 - lib/sidekiq/delay.rb
+- lib/sidekiq/delay/strategy.rb
 - lib/sidekiq/delay/version.rb
+- lib/sidekiq/delay/worker.rb
 - sidekiq-delay.gemspec
 - spec/app/models/band.rb
 - spec/app/models/team.rb
 - spec/config/mongoid.yml
+- spec/sidekiq/delay/strategy_spec.rb
+- spec/sidekiq/delay/worker_spec.rb
 - spec/sidekiq/delay_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/dlibanori/sidekiq-delay
@@ -146,5 +151,7 @@ test_files:
 - spec/app/models/band.rb
 - spec/app/models/team.rb
 - spec/config/mongoid.yml
+- spec/sidekiq/delay/strategy_spec.rb
+- spec/sidekiq/delay/worker_spec.rb
 - spec/sidekiq/delay_spec.rb
 - spec/spec_helper.rb