sidekiq-configure_notifications 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40d82b93f3bc656760c2230117ced5310943324e
-  data.tar.gz: ed3f931dba649a03cf289dd09ef183b4448ac495
+  metadata.gz: 6fa7d57263da4d6407bc7df715222530129fbc27
+  data.tar.gz: e2157492f3d5a3705b49e0d76b6032bd45402806
 SHA512:
-  metadata.gz: 377fd21e5f17e9a112701983ae198729648da58b83ef728f0407f25bce314a152e999f982f1e8d168a3fbe9fbe58a1a22291d18d764973029b150d63679004c9
-  data.tar.gz: 2c4f69b4794d0465be60791ee48663eb668364b4f180e149d361a9d0803cc6534a94943e7f25f7deddd0f3e143938a13393fc7490d0d571312bfaf9770600164
+  metadata.gz: 9beed690778948d179b8b6a4a4c00e5e4541a747ac6653608f03e30a39e3ca464400a6c938d8cb027ad65fba29ce3c705a31f01a8c910baad850474a86ea0179
+  data.tar.gz: 8090334f5613cab1f9ffbbf2ef70ee09ba2e14d66cf09e580f73197b91efb750ae95f7b071a40e2e711d15ed5e52dacc65fe04a12a292943e78e8c81675a214a

data/lib/sidekiq/configure_notifications/exception_handler.rb

@@ -1,4 +1,4 @@
-require 'sidekiq'
+require 'sidekiq/exception_handler'
 
 module Sidekiq
   module ExceptionHandler

data/lib/sidekiq/configure_notifications/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   module ConfigureNotifications
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/sidekiq-configure_notifications.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'sidekiq', '~> 2.17.7'
+  spec.add_dependency 'sidekiq', '~> 3.2.5'
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/test/test_exception_handler.rb

@@ -2,8 +2,6 @@ require 'helper'
 require 'sidekiq'
 require 'sidekiq/exception_handler'
 require 'sidekiq/configure_notifications/exception_handler'
-require 'stringio'
-require 'logger'
 
 ExceptionHandlerTestException = Class.new(StandardError)
 TEST_EXCEPTION = ExceptionHandlerTestException.new("Something didn't work!")
@@ -20,55 +18,53 @@ end
 
 class TestExceptionHandler < Minitest::Test
   describe "with log_exceptions_after and skip_log_exceptions options" do
-    after do
-      Object.send(:remove_const, "Airbrake") # HACK should probably inject Airbrake etc into this class in the future
-    end
 
-    describe "does not log" do
-      before do
-        class ::Airbrake
-          def self.notify_or_ignore(*args)
-            raise "it should not be called"
-          end
-        end
-      end
+    let(:error_handler) { Minitest::Mock.new }
+
+    before { Sidekiq.error_handlers << error_handler }
+    after  { Sidekiq.error_handlers.delete error_handler }
 
+    describe "does not log" do
       it "does not log when number of retries is less than log_exceptions_after" do
+        error_handler.expect :call, nil, [TEST_EXCEPTION, 'log_exceptions_after' => 4, 'retry_count' => 3]
         Component.new.invoke_exception('log_exceptions_after' => 4, 'retry_count' => 3)
+        assert_raises(MockExpectationError, "It logged!") do
+          error_handler.verify
+        end
       end
 
       it "does not log when number of retries is bigger than log_exceptions_after and exception is not in skip_log_exceptions" do
+        error_handler.expect :call, nil, [TEST_EXCEPTION, 'log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [::Exception]]
         Component.new.invoke_exception('log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [::Exception])
+        assert_raises(MockExpectationError, "It logged!") do
+          error_handler.verify
+        end
       end
     end
 
     describe "logs" do
-      before do
-        ::Airbrake = Minitest::Mock.new
-      end
-
       it "logs when number of retries is less than log_exceptions_after and exception is not in skip_log_exceptions 3" do
-        ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { 'log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [ExceptionHandlerTestException] }])
+        error_handler.expect :call, nil, [TEST_EXCEPTION, { 'log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [ExceptionHandlerTestException] }]
         Component.new.invoke_exception('log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [ExceptionHandlerTestException])
-        ::Airbrake.verify
+        error_handler.verify
       end
 
       it "logs when number of retries is less than log_exceptions_after and skip_log_exceptions is empty" do
-        ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { 'log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [] }])
+        error_handler.expect :call, nil, [TEST_EXCEPTION, { 'log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [] }]
         Component.new.invoke_exception('log_exceptions_after' => 2, 'retry_count' => 3, 'skip_log_exceptions' => [])
-        ::Airbrake.verify
+        error_handler.verify
       end
 
       it "logs when number of retries is less than log_exceptions_after and skip_log_exceptions is not given" do
-        ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { 'log_exceptions_after' => 2, 'retry_count' => 3 }])
+        error_handler.expect :call, nil, [TEST_EXCEPTION, { 'log_exceptions_after' => 2, 'retry_count' => 3 }]
         Component.new.invoke_exception('log_exceptions_after' => 2, 'retry_count' => 3)
-        ::Airbrake.verify
+        error_handler.verify
       end
 
       it "logs when log_exceptions_after is not given" do
-        ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => {}])
+        error_handler.expect :call, nil, [TEST_EXCEPTION, {}]
         Component.new.invoke_exception({})
-        ::Airbrake.verify
+        error_handler.verify
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-configure_notifications
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Caue Guerra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.17.7
+        version: 3.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.17.7
+        version: 3.2.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement