sidekiq-clutch 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f59ca9936b9b249991ee1e9d1ca62e00012dbe12bcfcb68a92939e7de6692065
-  data.tar.gz: 7a70ddcee890571a6d56a7a3f9496ecd2e6359e0e37808ee44bebc64c9d8ffb0
+  metadata.gz: 796b85ff9627cc5bc227521ee81c318f38fc979a7e963df54c762ee174320564
+  data.tar.gz: 9196201e96688775de3dca64d1322a8709b9641ed9fbbeb9ccdae187e4e7b3b9
 SHA512:
-  metadata.gz: 8d051a31dc527bc7397b784925aff21ec1c063b6b1569748f8240846e193349b7c5cb667763844627da3c018aa528f1805fc5bc6708d7a3b19b812cababade21
-  data.tar.gz: 76b9ca9e1873c4b17f5019379efaad052f7431c266cef9f381c52761a9c7d065cd9a52bb339dfb375971701602d64e690813d89df328e7d29afdc6223d50cdd1
+  metadata.gz: 15b262b976dff8c5fd3034ec4368d8e7058bfb4879234e9ad881893fb00f08aa81c48c9c6b44044b84321606a7ccf6901165c395146fc07cddb0e0bdbece1edd
+  data.tar.gz: de761b630c42ec9d78f82f9281f442c05fc88fb3161522f7190765603129852afbd1675fb2d93a1bd79ec8f46a979b062f29346e7e5406200ae962847babfa6f

data/.circleci/config.yml

@@ -7,5 +7,6 @@ jobs:
     - image: redis:3.2
     steps:
     - checkout
+    - run: gem install bundler
     - run: bundle install
     - run: bundle exec rspec

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.0.2 - Sep 24, 2020
+
+* PERF: Delete keys based on known values, instead of a glob
+* PERF: Don't bother enqueing a `:complete` callback if no `on_failure` is specified
+
 # 2.0.1 - Jun 1, 2020
 
 * CHORE: Bump development dependency versions

data/lib/sidekiq/clutch.rb

@@ -54,7 +54,8 @@ module Sidekiq
       return if step.nil?
       batch.callback_queue = queue if queue
       batch.on(:success, Sidekiq::Clutch, 'jobs' => jobs_queue.dup, 'result_key' => step['result_key'])
-      batch.on(:complete, Sidekiq::Clutch, 'on_failure' => on_failure&.name)
+      on_failure_name = on_failure&.name
+      batch.on(:complete, Sidekiq::Clutch, 'on_failure' => on_failure_name) if on_failure_name
       batch.jobs do
         if step['series']
           series_step(step)
@@ -112,8 +113,11 @@ module Sidekiq
 
     def clean_up_result_keys(key_base)
       Sidekiq.redis do |redis|
-        redis.keys(key_base + '*').each do |key|
-          redis.del(key)
+        result_key_index = 1
+        loop do
+          result = redis.del("#{key_base}-#{result_key_index}")
+          result_key_index += 1
+          break if result == 0
         end
       end
     end

data/lib/sidekiq/clutch/version.rb

@@ -1,5 +1,5 @@
 module Sidekiq
   class Clutch
-    VERSION = "2.0.1"
+    VERSION = "2.0.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sidekiq-clutch
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Tim Morgan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-01 00:00:00.000000000 Z
+date: 2020-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: An ergonomic wrapper API for Sidekiq Batches