sibit 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd8d72ab658b0424c135882a0787001395a69db720bc8283cf6b2155729c5a96
-  data.tar.gz: 37c2fab8a0bd840620e57c2a38ac831dcab13232f6274299c11477675e41734a
+  metadata.gz: 420c1f144c205270b6147f9f7841dc623f406da2229515491a6e62394b666a7a
+  data.tar.gz: 4038585222353146bcfb9095edea86cec8f16b4ec8bf2561c134e5e09df8c3a1
 SHA512:
-  metadata.gz: 9e70e784fdf68578e1919ce2989cdfb53c8fc50289e41b57d5df0429fdb28d6679eaf0e558f34112517019f372b16f0c2212b45b7c5104ad3bafd704cf3516b8
-  data.tar.gz: 11123bef8e29dde1689907f4536325f807510e9dd3dd10002afea284925176b37543060083ea17a8934e72d43a88cb2fc51c86697938d565bcfceb0d1487b937
+  metadata.gz: 2327d071a6deecf933409c9a56869889adcbece633fba1072e269130e247ea24a841e8f4b6698eaa91b0b2c6c11c54a654c10fb1049e52245270bc3449890b35
+  data.tar.gz: 590ff2cd99e4f060043a5d067b38013d5bf0fd0dfb09c6def61559a993d4b8c175b94122f4680b1db99e313ea33d34df6c7e8d54e7be7ad2fed57e3ea6f8c1a9

data/.rubocop.yml

@@ -18,7 +18,7 @@ Layout/MultilineMethodCallIndentation:
 Metrics/ParameterLists:
   Max: 6
 Metrics/ClassLength:
-  Max: 150
+  Max: 200
 Metrics/AbcSize:
   Enabled: false
 Metrics/BlockLength:

data/README.md

@@ -1,4 +1,4 @@
-<img src="https://en.bitcoin.it/w/images/en/2/29/BC_Logo_.png" width="64px"/>
+<img src="/logo.png" width="64px"/>
 
 [![EO principles respected here](http://www.elegantobjects.org/badge.svg)](http://www.elegantobjects.org)
 [![Managed by Zerocracy](https://www.0crat.com/badge/C3RFVLU72.svg)](https://www.0crat.com/p/C3RFVLU72)
@@ -26,6 +26,9 @@ something more complex, I would recommend using
 [bitcoin-ruby](https://github.com/lian/bitcoin-ruby) for Ruby and
 [Electrum](https://electrum.org/) as a GUI client.
 
+You may want to discuss this tool at [Bitcointalk](https://bitcointalk.org/index.php?topic=5130324)
+and give the thread a few merits.
+
 This is a Ruby gem, install it first (if doesn't work, there are
 some hints at the bottom of this page):
 

data/Rakefile

@@ -36,7 +36,6 @@ end
 task default: %i[clean test features rubocop copyright]
 
 require 'rake/testtask'
-desc 'Run all unit tests'
 Rake::TestTask.new(:test) do |test|
   Rake::Cleaner.cleanup_files(['coverage'])
   test.libs << 'lib' << 'test'
@@ -45,7 +44,6 @@ Rake::TestTask.new(:test) do |test|
 end
 
 require 'rdoc/task'
-desc 'Build RDoc documentation'
 Rake::RDocTask.new do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title = "#{name} #{version}"
@@ -54,7 +52,6 @@ Rake::RDocTask.new do |rdoc|
 end
 
 require 'rubocop/rake_task'
-desc 'Run RuboCop on all directories'
 RuboCop::RakeTask.new(:rubocop) do |task|
   task.fail_on_error = true
   task.requires << 'rubocop-rspec'

data/appveyor.yml

@@ -15,7 +15,7 @@ build_script:
   - bundle update
   - bundle install
 test_script:
-  - rake
+  - bundle exec rake
 cache:
   - C:\Ruby200\bin -> sibit.gemspec
   - C:\Ruby200\lib\ruby\gems\2.0.0 -> sibit.gemspec

data/bin/sibit

@@ -39,6 +39,7 @@ Commands are:
     pay:      Send a new Bitcoin transaction
 Options are:"
       o.string '--proxy', 'HTTPS proxy for all requests, e.g. "localhost:3128"'
+      o.bool '--dry', 'Don\'t send a real payment, run in a read-only mode'
       o.bool '--help', 'Read this: https://github.com/yegor256/sibit' do
         puts o
         exit
@@ -51,7 +52,8 @@ Options are:"
   raise 'Try --help' if opts.arguments.empty?
   sibit = Sibit.new(
     log: opts[:verbose] ? STDOUT : nil,
-    http: opts[:proxy] ? Sibit.proxy_http(opts[:proxy]) : Sibit.default_http
+    http: opts[:proxy] ? Sibit.proxy_http(opts[:proxy]) : Sibit.default_http,
+    dry: opts[:dry]
   )
   case opts.arguments[0]
   when 'price'

data/features/cli.feature

@@ -25,3 +25,7 @@ Feature: Command Line Processing
   Scenario: Bitcoin balance can be checked
     When I run bin/sibit with "balance 1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f --verbose"
     Then Exit code is zero
+
+  Scenario: Bitcoin transaction can be sent
+    When I run bin/sibit with "--verbose --dry pay 100000 S 1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi:fd2333686f49d8647e1ce8d5ef39c304520b08f3c756b67068b30a3db217dcb2 1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi 1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi"
+    Then Exit code is zero

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/lib/sibit.rb

@@ -25,6 +25,7 @@ require 'uri'
 require 'bitcoin'
 require 'json'
 require 'cgi'
+require_relative 'sibit/version'
 
 # Sibit main class.
 #
@@ -90,9 +91,10 @@ class Sibit
   # provide anything, the console will be used. The object you provide
   # has to respond to the method +info+ or +puts+ in order to receive logging
   # messages.
-  def initialize(log: STDOUT, http: Sibit.default_http)
+  def initialize(log: STDOUT, http: Sibit.default_http, dry: false)
     @log = log
     @http = http
+    @dry = dry
   end
 
   # Current price of 1 BTC.
@@ -138,6 +140,7 @@ class Sibit
   # +target+: the target address to send to
   # +change+: the address where the change has to be sent to
   def pay(amount, fee, sources, target, change)
+    p = price
     satoshi = satoshi(amount)
     builder = Bitcoin::Builder::TxBuilder.new
     unspent = 0
@@ -157,11 +160,11 @@ class Sibit
         i.signature_key(key(sources[address]))
       end
       size += 180
-      info("  #{num(utxo['value'])}/#{utxo['confirmations']} at #{utxo['tx_hash_big_endian']}")
+      info("  #{num(utxo['value'], p)}/#{utxo['confirmations']} at #{utxo['tx_hash_big_endian']}")
       break if unspent > satoshi
     end
     if unspent < satoshi
-      raise Error, "Not enough funds to send #{num(amount)}, only #{num(unspent)} left"
+      raise Error, "Not enough funds to send #{num(satoshi, p)}, only #{num(unspent, p)} left"
     end
     builder.output(satoshi, target)
     f = mfee(fee, size)
@@ -171,20 +174,21 @@ class Sibit
       extra_fee: f - Bitcoin.network[:min_tx_fee],
       change_address: change
     )
+    left = unspent - tx.outputs.map(&:value).inject(&:+)
     info("A new Bitcoin transaction #{tx.hash} prepared:
   #{tx.in.count} input#{tx.in.count > 1 ? 's' : ''}:
     #{tx.inputs.map { |i| " in: #{i.prev_out.bth}:#{i.prev_out_index}" }.join("\n    ")}
   #{tx.out.count} output#{tx.out.count > 1 ? 's' : ''}:
-    #{tx.outputs.map { |o| "out: #{o.script.bth} / #{num(o.value)}" }.join("\n    ")}
-  Fee required: #{num(f)} satoshi
-  Min tx fee: #{num(Bitcoin.network[:min_tx_fee])} satoshi
-  Fee left: #{num(unspent - tx.outputs.map(&:value).inject(&:+))} satoshi
-  Tx size: #{num(size)} bytes
-  Unspent: #{num(unspent)} satoshi
-  Amount: #{num(satoshi)} satoshi
+    #{tx.outputs.map { |o| "out: #{o.script.bth} / #{num(o.value, p)}" }.join("\n    ")}
+  Fee required: #{num(f, p)}
+  Min tx fee: #{num(Bitcoin.network[:min_tx_fee], p)}
+  Fee left: #{num(left, p)}
+  Tx size: #{size} bytes
+  Unspent: #{num(unspent, p)}
+  Amount: #{num(satoshi, p)}
   Target address: #{target}
   Change address is #{change}")
-    post_tx(tx.to_payload.bth)
+    post_tx(tx.to_payload.bth) unless @dry
     tx.hash
   end
 
@@ -211,8 +215,12 @@ class Sibit
 
   private
 
-  def num(int)
-    int.to_s.gsub(/\d(?=(...)+$)/, '\0,')
+  def num(satoshi, usd)
+    format(
+      '%<satoshi>ss/$%<dollars>0.2f',
+      satoshi: satoshi.to_s.gsub(/\d(?=(...)+$)/, '\0,'),
+      dollars: satoshi * usd / 100_000_000
+    )
   end
 
   # Convert text to amount.

data/test/test_sibit.rb

@@ -80,6 +80,9 @@ class TestSibit < Minitest::Test
   end
 
   def test_send_payment
+    stub_request(
+      :get, 'https://blockchain.info/ticker'
+    ).to_return(status: 200, body: '{"USD" : {"15m" : 5160.04}}')
     json = {
       unspent_outputs: [
         {
@@ -110,4 +113,44 @@ class TestSibit < Minitest::Test
     assert(!tx.nil?)
     assert(tx.length > 30, tx)
   end
+
+  def test_fail_if_not_enough_funds
+    stub_request(
+      :get, 'https://blockchain.info/ticker'
+    ).to_return(status: 200, body: '{"USD" : {"15m" : 5160.04}}')
+    json = {
+      unspent_outputs: []
+    }
+    stub_request(
+      :get,
+      'https://blockchain.info/unspent?active=1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi&limit=1000'
+    ).to_return(status: 200, body: JSON.pretty_generate(json))
+    sibit = Sibit.new
+    target = sibit.create(sibit.generate)
+    change = sibit.create(sibit.generate)
+    assert_raises Sibit::Error do
+      sibit.pay(
+        '0.0001BTC', 'XL',
+        {
+          '1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi' =>
+          'fd2333686f49d8647e1ce8d5ef39c304520b08f3c756b67068b30a3db217dcb2'
+        },
+        target, change
+      )
+    end
+  end
+
+  def test_fake_object_works
+    sibit = Sibit::Fake.new
+    assert_equal(4_000, sibit.price)
+    assert_equal('fd2333686f49d8647e1ce8d5ef39c304520b08f3c756b67068b30a3db217dcb2', sibit.generate)
+    assert_equal('1JvCsJtLmCxEk7ddZFnVkGXpr9uhxZPmJi', sibit.create(''))
+    assert_equal(100_000_000, sibit.balance(''))
+    assert_equal(
+      '9dfe55a30b5ee732005158c589179a398117117a68d21531fb6c78b85b544c54',
+      sibit.pay(0, 'M', {}, '', '')
+    )
+    assert_equal('00000000000000000008df8a6e1b61d1136803ac9791b8725235c9f780b4ed71', sibit.latest)
+    assert_equal({}, sibit.get_json('/'))
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-03 00:00:00.000000000 Z
+date: 2019-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace
@@ -240,6 +240,7 @@ files:
 - features/support/env.rb
 - lib/sibit.rb
 - lib/sibit/version.rb
+- logo.png
 - sibit.gemspec
 - test/test__helper.rb
 - test/test_sibit.rb