sibit 0.34.0 → 0.34.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9835f6fa0e5abbd809c650561dc79b4bddd69281bcc6f34c28d703c1ff7e27e
-  data.tar.gz: f64fa06396983ea189f42d7d1028842831f082c6c12660858916111b62f6be28
+  metadata.gz: 469905d53f542975d0fe59c8b429289423762f4b36aca8b703928d54f5ba394f
+  data.tar.gz: c68a4237d70f25a11ea2e98c36d76c7b0917a6355353e6d23c22336eedd94f31
 SHA512:
-  metadata.gz: bc3cc86f77d6418d88c327f87758de829b98644adf439f736c4c6a8db24e7f0f15a1faad58dc3f36a45b3ac5693995dcda0bb117ece14178fc0d437131139ab8
-  data.tar.gz: 49982a64fedb0281e093d4dd2176e649bc721f56b8743819c536ab28ac324e230097c5e4d741553da6a7b25e248b32f0933a14b8052d2fd705afc1222feec53e
+  metadata.gz: f5aa717192c0417c572226c3a0f79924f61e5d70b0bc84efe53d0cc760c16515f3cd6ef63b00de57e4228dbcd82fdb60a269f35df858b0c1ff8bec81006db6bc
+  data.tar.gz: fe9f402e207051f02e31b54d0a4e41cca76efd2a0260fbc6dfb3fb69f1aa543af2a9af6045590bd653c6c26472c97fdb6d5ba3a8b5a98f4ca282e351d88f53ee

data/Gemfile.lock

@@ -72,7 +72,7 @@ GEM
       loog (~> 0.6)
       tago (~> 0.1)
     ellipsized (0.3.0)
-    erb (6.0.4)
+    erb (6.0.6)
     ffi (1.17.4-arm64-darwin)
     ffi (1.17.4-x86_64-linux-gnu)
     hashdiff (1.2.1)
@@ -83,8 +83,8 @@ GEM
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
     iri (0.11.8)
-    json (2.19.9)
-    language_server-protocol (3.17.0.5)
+    json (2.21.1)
+    language_server-protocol (3.17.0.6)
     lint_roller (1.1.0)
     logger (1.7.0)
     loog (0.8.0)
@@ -108,10 +108,10 @@ GEM
     openssl (3.3.3)
     os (1.1.4)
     parallel (2.1.0)
-    parser (3.3.11.1)
+    parser (3.3.12.0)
       ast (~> 2.4.1)
       racc
-    pp (0.6.3)
+    pp (0.6.4)
       prettyprint
     prettyprint (0.2.0)
     prism (1.9.0)
@@ -144,7 +144,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.7)
-    rubocop (1.88.0)
+    rubocop (1.88.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -155,13 +155,13 @@ GEM
       rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.1)
+    rubocop-ast (1.50.0)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
-    rubocop-elegant (0.6.0)
+    rubocop-elegant (0.7.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.75)
-    rubocop-minitest (0.39.1)
+    rubocop-minitest (0.40.0)
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
@@ -177,7 +177,7 @@ GEM
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-cobertura (3.1.0)
+    simplecov-cobertura (3.2.0)
       rexml
       simplecov (~> 0.19)
     simplecov-html (0.13.2)

data/README.md

@@ -115,6 +115,11 @@ The proxy address may include authentication credentials:
 sibit --proxy=user:password@host:port balance 1PfsYNygsuVL8fvBarJNQnHytkg4rGih1U
 ```
 
+Some providers accept an API key, read from an environment variable:
+`SIBIT_BLOCKCHAIR_KEY` for [Blockchair.com] and
+  `SIBIT_CRYPTOAPIS_KEY` for [Cryptoapis.io].
+When the variable is set, requests to that provider use the authenticated tier.
+
 All operations are performed through the [Blockchain API].
 Transactions are pushed to the Bitcoin network via [this relay].
 

data/cross/centos.df

@@ -3,11 +3,6 @@
 
 FROM quay.io/centos/centos:stream9
 
-RUN dnf install -y epel-release && \
-    dnf config-manager --set-enabled crb && \
-    dnf install -y gcc make openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel tar && \
-    curl -fsSL https://github.com/rbenv/ruby-build/archive/refs/heads/master.tar.gz | tar -xz && \
-    PREFIX=/usr/local ./ruby-build-master/install.sh && \
-    ruby-build 3.2.6 /usr/local && \
-    rm -rf ruby-build-master && \
+RUN dnf module enable -y ruby:3.3 && \
+    dnf install -y ruby ruby-devel gcc make openssl-devel redhat-rpm-config && \
     dnf clean all

data/cross/opensuse.df

@@ -3,7 +3,15 @@
 
 FROM opensuse/tumbleweed
 
-RUN zypper --non-interactive install ruby ruby-devel gcc make libopenssl-devel bash && \
+RUN ok=; \
+    for i in 1 2 3 4 5; do \
+      if zypper --non-interactive --gpg-auto-import-keys refresh && \
+         zypper --non-interactive install ruby ruby-devel gcc make libopenssl-devel bash; then \
+        ok=1; break; \
+      fi; \
+      echo "zypper attempt $i failed, retrying in 15s"; sleep 15; \
+    done; \
+    test -n "$ok" && \
     zypper clean --all && \
     gem update --system --no-document && \
     sed -i '/format.executable/d' /etc/gemrc

data/cross/rocky.df

@@ -3,11 +3,6 @@
 
 FROM rockylinux:9
 
-RUN dnf install -y epel-release && \
-    dnf config-manager --set-enabled crb && \
-    dnf install -y gcc make openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel tar && \
-    curl -fsSL https://github.com/rbenv/ruby-build/archive/refs/heads/master.tar.gz | tar -xz && \
-    PREFIX=/usr/local ./ruby-build-master/install.sh && \
-    ruby-build 3.2.6 /usr/local && \
-    rm -rf ruby-build-master && \
+RUN dnf module enable -y ruby:3.3 && \
+    dnf install -y ruby ruby-devel gcc make openssl-devel redhat-rpm-config && \
     dnf clean all

data/lib/sibit/bech32.rb

@@ -66,8 +66,19 @@ class Sibit
 
     def witness
       hrp, data = parse
+      ver = data[0]
+      unless ver.between?(0, 16)
+        raise(Sibit::Error, "Unsupported witness version #{ver} in '#{@addr}'")
+      end
       raise(Sibit::Error, "Invalid Bech32 checksum in '#{@addr}'") unless verified?(hrp, data)
-      convert(data[1..-7], 5, 8, false).pack('C*').unpack1('H*')
+      prog = convert(data[1..-7], 5, 8)
+      if ver.zero? && [20, 32].none?(prog.length)
+        raise(Sibit::Error, "Witness v0 program in '#{@addr}' must be 20 or 32 bytes")
+      end
+      unless prog.length.between?(2, 40)
+        raise(Sibit::Error, "Witness program in '#{@addr}' must be 2 to 40 bytes")
+      end
+      prog.pack('C*').unpack1('H*')
     end
 
     def version
@@ -88,7 +99,7 @@ class Sibit
     end
 
     def verified?(hrp, data)
-      [1, 0x2bc830a3].include?(polymod(expand(hrp) + data))
+      polymod(expand(hrp) + data) == (data[0].zero? ? 1 : 0x2bc830a3)
     end
 
     def expand(hrp)
@@ -105,7 +116,7 @@ class Sibit
       chk
     end
 
-    def convert(data, frombits, tobits, pad)
+    def convert(data, frombits, tobits)
       acc = 0
       bits = 0
       result = []
@@ -118,7 +129,9 @@ class Sibit
           result << ((acc >> bits) & maxv)
         end
       end
-      result << ((acc << (tobits - bits)) & maxv) if pad && bits.positive?
+      if bits >= frombits || (acc << (tobits - bits)).anybits?(maxv)
+        raise(Sibit::Error, "Non-zero padding in Bech32 address '#{@addr}'")
+      end
       result
     end
   end

data/lib/sibit/bestof.rb

@@ -66,11 +66,26 @@ class Sibit::BestOf
     best_of('latest', &:latest)
   end
 
-  # Push this transaction (in hex format) to the network.
+  # Push this transaction (in hex format) to the network. This one does
+  # not vote: pushing is a side effect, so it hands the transaction to
+  # each API in turn and stops at the first that accepts it.
   def push(hex)
-    best_of('push') do |api|
-      api.push(hex)
+    return @list.push(hex) unless @list.is_a?(Array)
+    errors = []
+    @list.each do |api|
+      return api.push(hex)
+    rescue Sibit::NotSupportedError
+      nil
+    rescue Sibit::Error => e
+      errors << e
+      @log.debug("The API #{api.class.name} failed at push(): #{e.message}") if @verbose
     end
+    errors.each { |e| @log.debug(Backtrace.new(e).to_s) }
+    raise(
+      Sibit::Error,
+      "No APIs out of #{@list.length} managed to succeed at push(): " \
+      "#{@list.map { |a| a.class.name }.join(', ')}"
+    )
   end
 
   # This method should fetch a block and return as a hash.
@@ -84,17 +99,17 @@ class Sibit::BestOf
 
   def best_of(method)
     return yield(@list) unless @list.is_a?(Array)
-    results = []
+    votes = []
     errors = []
     @list.each do |api|
-      results << yield(api)
+      votes << [api.class.name, yield(api)]
     rescue Sibit::NotSupportedError
       nil
     rescue Sibit::Error => e
       errors << e
       @log.debug("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
     end
-    if results.empty?
+    if votes.empty?
       errors.each { |e| @log.debug(Backtrace.new(e).to_s) }
       raise(
         Sibit::Error,
@@ -102,6 +117,18 @@ class Sibit::BestOf
         "#{@list.map { |a| a.class.name }.join(', ')}"
       )
     end
-    results.group_by(&:to_s).values.max_by(&:size)[0]
+    majority(method, votes)
+  end
+
+  def majority(method, votes)
+    winner = votes.group_by { |v| v[1].to_s }.values.max_by(&:size)
+    if winner.size <= votes.size / 2
+      raise(
+        Sibit::Error,
+        "No strict majority among #{votes.size} answers at #{method}(): " \
+        "#{votes.map { |name, answer| "#{name}=#{answer}" }.join(', ')}"
+      )
+    end
+    winner[0][1]
   end
 end

data/lib/sibit/bin.rb

@@ -101,7 +101,8 @@ class Sibit
       desc: 'Minimum number of confirmations required on a UTXO before it can be spent'
     def pay(amount, fee, sources, target, change)
       keys = sources.split(',')
-      if amount.upcase == 'MAX'
+      sweep = amount.upcase == 'MAX'
+      if sweep
         addrs =
           keys.map do |k|
             kk = Sibit::Key.new(k)
@@ -111,6 +112,7 @@ class Sibit
       end
       amount = Integer(amount, 10) if amount.is_a?(String) && /^[0-9]+$/.match?(amount)
       fee = Integer(fee, 10) if /^[0-9]+$/.match?(fee)
+      amount -= fee if sweep && fee.is_a?(Integer)
       args = [amount, fee, keys, target, change]
       kwargs = {
         skip_utxo: options[:skip_utxo], base58: options[:base58],
@@ -157,7 +159,7 @@ class Sibit
           when 'bitcoinchain'
             Sibit::Bitcoinchain.new(http: http, log: log)
           when 'blockchair'
-            Sibit::Blockchair.new(http: http, log: log)
+            Sibit::Blockchair.new(key: ENV.fetch('SIBIT_BLOCKCHAIR_KEY', nil), http: http, log: log)
           when 'cex'
             Sibit::Cex.new(http: http, log: log)
           when 'cryptoapis'

data/lib/sibit/bitcoinchain.rb

@@ -7,6 +7,7 @@ require 'iri'
 require 'json'
 require 'loog'
 require 'uri'
+require_relative 'coins'
 require_relative 'error'
 require_relative 'http'
 require_relative 'json'
@@ -58,8 +59,7 @@ class Sibit::Bitcoinchain
       @log.debug("The balance of #{address} is not visible")
       return 0
     end
-    b *= 100_000_000
-    b = Integer(b)
+    b = Sibit::Coins.new(b).satoshi
     @log.debug("The balance of #{address} is #{b} satoshi (#{json['transactions']} txns)")
     b
   end
@@ -112,7 +112,7 @@ class Sibit::Bitcoinchain
           outputs: t['outputs'].map do |o|
             {
               address: o['receiver'],
-              value: o['value'] * 100_000_000
+              value: Sibit::Coins.new(o['value']).satoshi
             }
           end
         }

data/lib/sibit/blockchain.rb

@@ -3,6 +3,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
+require 'cgi'
 require 'iri'
 require 'json'
 require 'loog'
@@ -32,7 +33,7 @@ class Sibit::Blockchain
     h = Sibit::Json.new(http: @http, log: @log).get(
       Iri.new('https://blockchain.info/ticker')
     )[currency]
-    raise(Error, "Unrecognized currency #{currency}") if h.nil?
+    raise(Sibit::Error, "Unrecognized currency #{currency}") if h.nil?
     price = h['15m']
     @log.debug("The price of BTC is #{price} USD")
     price
@@ -48,6 +49,7 @@ class Sibit::Blockchain
     h = Sibit::Json.new(http: @http, log: @log).get(
       Iri.new('https://blockchain.info/rawblock').append(hash)
     )['height']
+    raise(Sibit::Error, "The block #{hash} found but the height is absent") if h.nil?
     @log.debug("The height of #{hash} is #{h}")
     h
   end
@@ -55,10 +57,10 @@ class Sibit::Blockchain
   # Gets the balance of the address, in satoshi.
   def balance(address)
     json = Sibit::Json.new(http: @http, log: @log).get(
-      Iri.new('https://blockchain.info/rawaddr').append(address).add(limit: 0),
-      accept: [200, 500]
+      Iri.new('https://blockchain.info/rawaddr').append(address).add(limit: 0)
     )
     b = json['final_balance']
+    raise(Sibit::Error, "The balance of #{address} is absent") unless b.is_a?(Integer)
     @log.debug("The balance of #{address} is #{b} satoshi (#{json['n_tx']} txns)")
     b
   end
@@ -75,7 +77,7 @@ class Sibit::Blockchain
       ].join
     )
     {
-      S: json['regular'] / 3,
+      S: (json['regular'] / 3.0).ceil,
       M: json['regular'],
       L: json['priority'],
       XL: json['limits']['max']
@@ -100,7 +102,9 @@ class Sibit::Blockchain
 
   # Push this transaction (in hex format) to the network.
   def push(hex)
-    Sibit::Json.new(http: @http, log: @log).post(Iri.new('https://blockchain.info/pushtx'), hex)
+    Sibit::Json.new(http: @http, log: @log).post(
+      Iri.new('https://blockchain.info/pushtx'), "tx=#{CGI.escape(hex)}"
+    )
   end
 
   # Gets the hash of the latest block.

data/lib/sibit/btc.rb

@@ -39,10 +39,7 @@ class Sibit::Btc
       return 0
     end
     data = json['data']
-    if data.nil?
-      @log.debug("The balance of #{address} is probably zero (not found)")
-      return 0
-    end
+    raise(Sibit::Error, "The address #{address} not found") if data.nil?
     txns = data['list']
     if txns.nil?
       @log.debug("The balance of #{address} is probably zero (not found)")
@@ -103,19 +100,19 @@ class Sibit::Btc
       list = data['list']
       next if list.nil?
       list.each do |u|
-        outs = Sibit::Json.new(http: @http, log: @log).get(
+        index = u['tx_output_n']
+        raise(Sibit::Error, "The unspent output of #{hash} has no tx_output_n") if index.nil?
+        out = Sibit::Json.new(http: @http, log: @log).get(
           Iri.new('https://chain.api.btc.com/v3/tx').append(u['tx_hash']).add(verbose: 3)
-        )['data']['outputs']
-        outs.each_with_index do |o, i|
-          next unless o['addresses'].include?(hash)
-          results << {
-            value: o['value'],
-            hash: u['tx_hash'],
-            index: i,
-            confirmations: u['confirmations'],
-            script: [o['script_hex']].pack('H*')
-          }
-        end
+        )['data']['outputs'][index]
+        raise(Sibit::Error, "The output #{index} of #{u['tx_hash']} is absent") if out.nil?
+        results << {
+          value: u['value'],
+          hash: u['tx_hash'],
+          index: index,
+          confirmations: u['confirmations'],
+          script: [out['script_hex']].pack('H*')
+        }
       end
     end
     results

data/lib/sibit/coins.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
+# SPDX-License-Identifier: MIT
+
+require 'bigdecimal'
+require_relative 'error'
+
+# Sibit main class.
+class Sibit
+  # An amount of bitcoins, convertible to an exact number of satoshi.
+  #
+  # It parses the amount through +BigDecimal+ instead of a binary +Float+,
+  # so decimal values like 0.29 map to exactly 29,000,000 satoshi. An amount
+  # with sub-satoshi precision is rejected instead of being truncated.
+  #
+  # Author:: Yegor Bugayenko (yegor256@gmail.com)
+  # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
+  # License:: MIT
+  class Coins
+    def initialize(btc)
+      @btc = btc
+    end
+
+    def satoshi
+      sat = BigDecimal(@btc.to_s) * 100_000_000
+      unless sat.frac.zero?
+        raise(Sibit::Error, "The amount #{@btc.inspect} is finer than one satoshi")
+      end
+      Integer(sat)
+    rescue ArgumentError, TypeError
+      raise(Sibit::Error, "The amount #{@btc.inspect} is not a valid number of bitcoins")
+    end
+  end
+end

data/lib/sibit/cryptoapis.rb

@@ -7,6 +7,7 @@ require 'iri'
 require 'json'
 require 'loog'
 require 'uri'
+require_relative 'coins'
 require_relative 'error'
 require_relative 'http'
 require_relative 'json'
@@ -32,10 +33,13 @@ class Sibit::Cryptoapis
 
   # Get hash of the block after this one.
   def next_of(hash)
-    nxt = Sibit::Json.new(http: @http, log: @log).get(
+    head = Sibit::Json.new(http: @http, log: @log).get(
       Iri.new('https://api.cryptoapis.io/v1/bc/btc/mainnet/blocks').append(hash),
       headers: headers
-    )['payload']['hash']
+    )['payload']
+    raise(Sibit::Error, "The block #{hash} not found") if head.nil?
+    nxt = head['nextblockhash']
+    nxt = nil if nxt == '0000000000000000000000000000000000000000000000000000000000000000'
     @log.debug("The block #{hash} is the latest, there is no next block") if nxt.nil?
     @log.debug("The next block of #{hash} is #{nxt}") unless nxt.nil?
     nxt
@@ -53,14 +57,12 @@ class Sibit::Cryptoapis
 
   # Gets the balance of the address, in satoshi.
   def balance(address)
-    b = Integer(
-      Float(
-        Sibit::Json.new(http: @http, log: @log).get(
-          Iri.new('https://api.cryptoapis.io/v1/bc/btc/mainnet/address').append(address),
-          headers: headers
-        )['payload']['balance']
-      ) * 100_000_000
-    )
+    b = Sibit::Coins.new(
+      Sibit::Json.new(http: @http, log: @log).get(
+        Iri.new('https://api.cryptoapis.io/v1/bc/btc/mainnet/address').append(address),
+        headers: headers
+      )['payload']['balance']
+    ).satoshi
     @log.debug("The balance of #{address} is #{b} satoshi")
     b
   end
@@ -90,7 +92,7 @@ class Sibit::Cryptoapis
     Sibit::Json.new(http: @http, log: @log).post(
       Iri.new('https://api.cryptoapis.io/v1/bc/btc/mainnet/txs/send'),
       JSON.pretty_generate(hex: hex),
-      headers: headers
+      headers: headers.merge('Content-Type' => 'application/json')
     )
   end
 
@@ -135,7 +137,7 @@ class Sibit::Cryptoapis
             outputs: t['txouts'].map do |o|
               {
                 address: o['addresses'][0],
-                value: Float(o['amount'] || 0) * 100_000_000
+                value: Sibit::Coins.new(o['amount'] || 0).satoshi
               }
             end
           }

data/lib/sibit/json.rb

@@ -3,7 +3,6 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
-require 'cgi'
 require 'elapsed'
 require 'json'
 require 'loog'
@@ -62,7 +61,7 @@ class Sibit::Json
     elapsed(@log) do
       res = @http.client(uri).post(
         "#{uri.path.empty? ? '/' : uri.path}#{"?#{uri.query}" if uri.query}",
-        "tx=#{CGI.escape(body)}",
+        body,
         {
           'Accept' => 'text/plain',
           'User-Agent' => user_agent,

data/lib/sibit/sochain.rb

@@ -111,9 +111,9 @@ class Sibit::Sochain
       data = Sibit::Json.new(http: @http, log: @log).get(
         Iri.new('https://sochain.com/api/v2/get_tx_unspent').append(@network).append(address)
       )['data']
-      next if data.nil?
+      raise(Sibit::Error, "The address #{address} unspent lookup returned no data") if data.nil?
       txs = data['txs']
-      next if txs.nil?
+      raise(Sibit::Error, "The address #{address} unspent lookup returned no txs") if txs.nil?
       txs.each do |u|
         out << {
           value: Integer((Float(u['value']) * 100_000_000).round),
@@ -162,9 +162,12 @@ class Sibit::Sochain
       next: nxt,
       previous: data['previous_blockhash'],
       txns: (data['txs'] || []).map do |t|
+        unless t.is_a?(Hash)
+          raise(Sibit::NotSupportedError, "SoChain returned bare txid #{t} without outputs")
+        end
         {
-          hash: t['txid'] || t,
-          outputs: ((t.is_a?(Hash) ? t['outputs'] : nil) || []).map do |o|
+          hash: t['txid'],
+          outputs: (t['outputs'] || []).map do |o|
             {
               address: o['address'],
               value: Integer((Float(o['value']) * 100_000_000).round)

data/lib/sibit/tx.rb

@@ -38,12 +38,16 @@ class Sibit
     end
 
     def hash
-      Digest::SHA256.hexdigest(Digest::SHA256.digest(payload)).reverse.scan(/../).join
+      sign_inputs
+      Digest::SHA256.hexdigest(
+        Digest::SHA256.digest(serialize(witness: false))
+      ).scan(/../).reverse.join
     end
 
     def payload
+      return @payload if @payload
       sign_inputs
-      serialize
+      @payload = serialize
     end
 
     def hex
@@ -121,12 +125,24 @@ class Sibit
 
       private
 
+      def decoded
+        return @decoded if @decoded
+        hex = Base58.new(@address).decode
+        unless hex.length == 50
+          raise(Sibit::Error, "Address '#{@address}' does not decode to 25 bytes")
+        end
+        unless hex[-8..] == Base58.new(hex[0..-9]).check
+          raise(Sibit::Error, "Address '#{@address}' fails its Base58 checksum")
+        end
+        @decoded = hex
+      end
+
       def version
-        Base58.new(@address).decode[0, 2]
+        decoded[0, 2]
       end
 
       def hash160
-        [Base58.new(@address).decode[2, 40]].pack('H*')
+        [decoded[2, 40]].pack('H*')
       end
 
       def p2pkh_script
@@ -138,8 +154,13 @@ class Sibit
       end
 
       def segwit_script
-        witness = Bech32.new(@address).witness
-        [0x00, (witness.length / 2)].pack('C*') + [witness].pack('H*')
+        bech = Bech32.new(@address)
+        program = bech.witness
+        [opcode(bech.version), program.length / 2].pack('C*') + [program].pack('H*')
+      end
+
+      def opcode(version)
+        version.zero? ? 0x00 : 0x50 + version
       end
     end
 
@@ -150,6 +171,7 @@ class Sibit
     end
 
     def sign_inputs
+      return if @signed
       @inputs.each_with_index do |input, idx|
         sig = sign(input.key, (input.segwit? ? segwit_sighash(idx) : legacy_sighash(idx)))
         pubkey = [input.key.pub].pack('H*')
@@ -159,6 +181,7 @@ class Sibit
           input.script_sig = der_sig(sig) + pubkey_script(pubkey)
         end
       end
+      @signed = true
     end
 
     def legacy_sighash(idx)
@@ -244,9 +267,9 @@ class Sibit
       [pubkey.length].pack('C') + pubkey
     end
 
-    def serialize
+    def serialize(witness: witness?)
       result = [VERSION].pack('V')
-      result += [0x00, 0x01].pack('CC') if witness?
+      result += [0x00, 0x01].pack('CC') if witness
       result += varint(@inputs.length)
       @inputs.each do |input|
         result += [input.hash].pack('H*').reverse
@@ -262,7 +285,7 @@ class Sibit
         result += varint(script.length)
         result += script
       end
-      result += serialize_witness if witness?
+      result += serialize_witness if witness
       result += [0].pack('V')
       result
     end

data/lib/sibit/txbuilder.rb

@@ -3,6 +3,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
+require_relative 'error'
 require_relative 'key'
 require_relative 'tx'
 
@@ -17,6 +18,8 @@ class Sibit
   # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
   # License:: MIT
   class TxBuilder
+    DUST = 546
+
     def initialize
       @inputs = []
       @outputs = []
@@ -47,6 +50,15 @@ class Sibit
       @outputs.each { |o| txn.add_output(o[:value], o[:address]) }
       if leave_fee
         change = input_value - total - extra_fee
+        if change.negative?
+          raise(
+            Sibit::Error,
+            "The inputs of #{input_value} cannot cover outputs of #{total} plus fee of #{extra_fee}"
+          )
+        end
+        if change.positive? && change < DUST
+          raise(Sibit::Error, "The change of #{change} is below the dust limit of #{DUST}")
+        end
         txn.add_output(change, change_address) if change.positive?
       end
       Built.new(txn, @inputs, @outputs)

data/lib/sibit/version.rb

@@ -8,5 +8,5 @@
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
 class Sibit
-  VERSION = '0.34.0' unless defined?(VERSION)
+  VERSION = '0.34.1' unless defined?(VERSION)
 end

data/lib/sibit.rb

@@ -7,6 +7,7 @@ require 'ellipsized'
 require 'loog'
 require_relative 'sibit/base58'
 require_relative 'sibit/blockchain'
+require_relative 'sibit/coins'
 require_relative 'sibit/key'
 require_relative 'sibit/script'
 require_relative 'sibit/tx'
@@ -19,7 +20,7 @@ require_relative 'sibit/version'
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
 class Sibit
-  MIN_SATOSHI_PER_BYTE = 0.1
+  MIN_SATOSHI_PER_BYTE = 1
 
   # Constructor.
   #
@@ -96,9 +97,13 @@ class Sibit
   #
   # If the payment can't be signed (the key is wrong, for example) or the
   # previous transaction is not found, or there is a network error, or
-  # any other reason, you will get an exception. In this case, just try again.
-  # It's safe to try as many times as you need. Don't worry about duplicating
-  # your transaction, the Bitcoin network will filter duplicates out.
+  # any other reason, you will get an exception. You may retry, but only
+  # while no earlier attempt could have reached the network: inputs are
+  # selected deterministically, so an immediate retry rebuilds a conflicting
+  # transaction that the network rejects as a double-spend. Once an earlier
+  # attempt might have confirmed, the wallet holds a fresh set of UTXOs and
+  # a blind retry may pay the target twice; check the target address (or the
+  # previous transaction hash) before re-sending.
   #
   # If there are more than 1000 UTXOs in the address where you are trying
   # to send bitcoins from, this method won't be helpful.
@@ -150,7 +155,7 @@ class Sibit
     builder = TxBuilder.new
     unspent = 0
     size = 100
-    utxos = @api.utxos(sources.keys)
+    utxos = @api.utxos(sources.keys).sort_by { |u| [u[:hash], u[:index]] }
     @log.debug("#{utxos.count} UTXOs found, these will be used (value/confirmations at tx_hash):")
     utxos.each do |utxo|
       if skip_utxo.include?(utxo[:hash])
@@ -313,7 +318,7 @@ class Sibit
     unless amount.is_a?(String)
       raise(Error, "Amount should either be a String or Integer, #{amount.class.name} provided")
     end
-    return Integer(Float(amount.gsub(/BTC$/, '')) * 100_000_000) if amount.end_with?('BTC')
+    return Coins.new(amount.gsub(/BTC$/, '')).satoshi if amount.end_with?('BTC')
     raise(Error, "Can't understand the amount #{amount.inspect}")
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.34.0
+  version: 0.34.1
 platform: ruby
 authors:
 - Yegor Bugayenko
@@ -192,6 +192,7 @@ files:
 - lib/sibit/blockchair.rb
 - lib/sibit/btc.rb
 - lib/sibit/cex.rb
+- lib/sibit/coins.rb
 - lib/sibit/cryptoapis.rb
 - lib/sibit/dry.rb
 - lib/sibit/error.rb