sibit 0.20.3 → 0.20.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a10cbcbf86d4a0c612ebba219e7e5d0a09480444280a106fd47bb41cbadd0405
-  data.tar.gz: 5c3ede973fe824a8f247099c6980b938dc83b07481553bf7925678837553d4ad
+  metadata.gz: 5fce6b2ed89b0207cda60852aa0308c19e176725782e6821141c73a24dcdb2f9
+  data.tar.gz: 807d723a53772eb71002a0223030795ab47710952979398b207b4d87c58fca75
 SHA512:
-  metadata.gz: 4bd040eb2e985bd9af773e4bcda1108939cecbcea6b4719f3779eba70a3ce3d2bd69c1deb5c8a748eaaeee85f98fcc6ac5f447189ef635befbd75d68abde6aff
-  data.tar.gz: ee1ba5bc4c7bd03d0f975a38c0d2f5d315804eb3444dad26b93511fed19ce3092420907d0a338d4d871dc1abc7fd9307bc3d9f4f7a97a46a6a5824be52c13c62
+  metadata.gz: 5186670b03e26882ab1863b056d2951e0116bd71e4f4ef1ca213ea4e08958b85bac00baeb9763ab24c3ffce35bcc280d282d5ab89621a38874f53df530308c66
+  data.tar.gz: 9c816996ea654affba93c3d7d4e42b46559a7ff8a73f74765f28331c991038f2af4aa0361deea5b3332f7a9b44896f450e666888adef13414a15dbd9bb5a3523

data/.rubocop.yml

@@ -1,12 +1,13 @@
 AllCops:
+  NewCops: enable
   Exclude:
     - 'assets/**/*'
   DisplayCopNames: true
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.5
 
 Style/ClassAndModuleChildren:
   Enabled: false
-Metrics/LineLength:
+Layout/LineLength:
   Max: 100
 Layout/EndOfLine:
   EnforcedStyle: lf

data/.simplecov

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2019-2020 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -18,21 +20,21 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-if Gem.win_platform? then
+if Gem.win_platform?
   SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
     SimpleCov::Formatter::HTMLFormatter
   ]
   SimpleCov.start do
-    add_filter "/test/"
-    add_filter "/features/"
+    add_filter '/test/'
+    add_filter '/features/'
   end
 else
   SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
     [SimpleCov::Formatter::HTMLFormatter]
   )
   SimpleCov.start do
-    add_filter "/test/"
-    add_filter "/features/"
+    add_filter '/test/'
+    add_filter '/features/'
     minimum_coverage 60
   end
 end

data/Gemfile

@@ -21,5 +21,5 @@
 # SOFTWARE.
 
 source 'https://rubygems.org'
-ruby '~>2.3'
+ruby '~>2.5'
 gemspec

data/bin/sibit

@@ -21,7 +21,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-STDOUT.sync = true
+$stdout.sync = true
 
 require 'slop'
 require 'backtrace'
@@ -68,27 +68,28 @@ Options are:"
         default: %w[earn blockchain btc bitcoinchain blockchair cex]
       )
     end
-  rescue Slop::Error => ex
-    raise ex.message
+  rescue Slop::Error => e
+    raise e.message
   end
   raise 'Try --help' if opts.arguments.empty?
-  log = Sibit::Log.new(opts[:verbose] ? STDOUT : nil)
+  log = Sibit::Log.new(opts[:verbose] ? $stdout : nil)
   http = opts[:proxy] ? Sibit::HttpProxy.new(opts[:proxy]) : Sibit::Http.new
   apis = opts[:api].map(&:downcase).map do |a|
     api = nil
-    if a == 'blockchain'
+    case a
+    when 'blockchain'
       api = Sibit::Blockchain.new(http: http, log: log, dry: opts[:dry])
-    elsif a == 'btc'
+    when 'btc'
       api = Sibit::Btc.new(http: http, log: log, dry: opts[:dry])
-    elsif a == 'bitcoinchain'
+    when 'bitcoinchain'
       api = Sibit::Bitcoinchain.new(http: http, log: log, dry: opts[:dry])
-    elsif a == 'blockchair'
+    when 'blockchair'
       api = Sibit::Blockchair.new(http: http, log: log, dry: opts[:dry])
-    elsif a == 'cex'
+    when 'cex'
       api = Sibit::Cex.new(http: http, log: log, dry: opts[:dry])
-    elsif a == 'fake'
+    when 'fake'
       api = Sibit::Fake.new
-    elsif a == 'earn'
+    when 'earn'
       api = Sibit::Earn.new(http: http, log: log, dry: opts[:dry])
     else
       raise Sibit::Error, "Unknown API \"#{a}\""
@@ -105,7 +106,7 @@ Options are:"
     text = %i[S M L XL].map do |m|
       sat = fees[m] * 250
       usd = sat * sibit.price / 100_000_000
-      "#{m}: #{sat}sat / $#{format('%.02f', usd)}"
+      "#{m}: #{sat}sat / $#{format('%<usd>.02f', usd: usd)}"
     end.join("\n")
     puts text
   when 'latest'
@@ -141,11 +142,11 @@ Options are:"
   else
     raise "Command #{opts.arguments[0]} is not supported"
   end
-rescue StandardError => ex
+rescue StandardError => e
   if opts[:verbose]
-    puts Backtrace.new(ex).to_s
+    puts Backtrace.new(e).to_s
   else
-    puts "ERROR: #{ex.message}"
+    puts "ERROR: #{e.message}"
   end
   exit(255)
 end

data/lib/sibit.rb

@@ -48,7 +48,7 @@ class Sibit
   # The +api+ argument can be an object or an array of objects. If an array
   # is provided, we will make an attempt to try them one by one, until
   # one of them succeedes.
-  def initialize(log: STDOUT, api: Sibit::Blockchain.new(log: Sibit::Log.new(log)))
+  def initialize(log: $stdout, api: Sibit::Blockchain.new(log: Sibit::Log.new(log)))
     @log = Sibit::Log.new(log)
     @api = api
   end

data/lib/sibit/bestof.rb

@@ -20,6 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+require 'backtrace'
 require_relative 'error'
 require_relative 'log'
 
@@ -103,14 +104,15 @@ class Sibit
     def best_of(method)
       return yield @list unless @list.is_a?(Array)
       results = []
+      errors = []
       @list.each do |api|
-        begin
-          results << yield(api)
-        rescue Sibit::Error => e
-          @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
-        end
+        results << yield(api)
+      rescue Sibit::Error => e
+        errors << e
+        @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
       end
       if results.empty?
+        errors.each { |e| @log.info(Backtrace.new(e).to_s) }
         raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
 #{@list.map { |a| a.class.name }.join(', ')}"
       end

data/lib/sibit/firstof.rb

@@ -20,6 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+require 'backtrace'
 require_relative 'error'
 require_relative 'log'
 
@@ -102,6 +103,7 @@ class Sibit
 
     def first_of(method)
       return yield @list unless @list.is_a?(Array)
+      errors = []
       done = false
       result = nil
       @list.each do |api|
@@ -111,10 +113,12 @@ class Sibit
           done = true
           break
         rescue Sibit::Error => e
+          errors << e
           @log.info("The API #{api.class.name} failed at #{method}(): #{e.message}") if @verbose
         end
       end
       unless done
+        errors.each { |e| @log.info(Backtrace.new(e).to_s) }
         raise Sibit::Error, "No APIs out of #{@list.length} managed to succeed at #{method}(): \
 #{@list.map { |a| a.class.name }.join(', ')}"
       end

data/lib/sibit/log.rb

@@ -34,7 +34,7 @@ class Sibit
     # provide anything, the console will be used. The object you provide
     # has to respond to the method +info+ or +puts+ in order to receive logging
     # messages.
-    def initialize(log = STDOUT)
+    def initialize(log = $stdout)
       @log = log
     end
 

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.20.3'
+  VERSION = '0.20.4'
 end

data/sibit.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |s|
     s.required_rubygems_version = Gem::Requirement.new('>= 0')
   end
   s.rubygems_version = '2.2'
-  s.required_ruby_version = '>= 2.3'
+  s.required_ruby_version = '>= 2.5'
   s.name = 'sibit'
   s.version = Sibit::VERSION
   s.license = 'MIT'
@@ -49,20 +49,18 @@ and Ruby 2.3+.'
   s.rdoc_options = ['--charset=UTF-8']
   s.extra_rdoc_files = ['README.md', 'LICENSE.txt']
   s.add_runtime_dependency 'backtrace', '~> 0.3'
-  s.add_runtime_dependency 'bitcoin', '0.2.0'
   s.add_runtime_dependency 'bitcoin-ruby', '0.0.19'
   s.add_runtime_dependency 'json', '~> 2'
   s.add_runtime_dependency 'retriable_proxy', '1.0.2'
   s.add_runtime_dependency 'slop', '~> 4.6'
-  s.add_development_dependency 'aruba', '~> 0.14.1'
-  s.add_development_dependency 'codecov', '0.2.8'
-  s.add_development_dependency 'cucumber', '~> 1.3.17'
-  s.add_development_dependency 'debase', '0.2.2'
-  s.add_development_dependency 'minitest', '5.5.0'
-  s.add_development_dependency 'rake', '12.0.0'
-  s.add_development_dependency 'rspec-rails', '3.1.0'
-  s.add_development_dependency 'rubocop', '0.61.0'
-  s.add_development_dependency 'rubocop-rspec', '1.31.0'
-  s.add_development_dependency 'ruby-debug-ide', '0.6.1'
-  s.add_development_dependency 'webmock', '3.7.6'
+  s.add_development_dependency 'aruba', '~> 1.0'
+  s.add_development_dependency 'codecov', '0.2.11'
+  s.add_development_dependency 'cucumber', '~> 5.1'
+  s.add_development_dependency 'debase', '~> 0.2'
+  s.add_development_dependency 'minitest', '5.14.2'
+  s.add_development_dependency 'rake', '13.0.1'
+  s.add_development_dependency 'rspec-rails', '4.0.1'
+  s.add_development_dependency 'rubocop', '0.91.0'
+  s.add_development_dependency 'rubocop-rspec', '1.43.2'
+  s.add_development_dependency 'webmock', '3.9.1'
 end

data/test/test__helper.rb

@@ -20,7 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-STDOUT.sync = true
+$stdout.sync = true
 
 require 'simplecov'
 SimpleCov.start

data/test/test_live.rb

@@ -107,7 +107,7 @@ class TestLive < Minitest::Test
       json = api.utxos(['12fCwqBN4XsHq4iu2Wbfgq5e8YhqEGP3ee'])
       assert_equal(3, json.length)
       assert(json.find { |t| t[:value] == 16_200_000 }, 'UTXO not found')
-      assert(json.find { |t| t[:script].unpack('H*').first.start_with?('76a9141231e760') })
+      assert(json.find { |t| t[:script].unpack1('H*').start_with?('76a9141231e760') })
     end
   end
 
@@ -130,11 +130,9 @@ class TestLive < Minitest::Test
     require_relative '../lib/sibit/bitcoinchain'
     apis << Sibit::Bitcoinchain.new
     apis.each do |api|
-      begin
-        yield api
-      rescue Sibit::Error => e
-        puts Backtrace.new(e).to_s
-      end
+      yield api
+    rescue Sibit::Error => e
+      puts Backtrace.new(e).to_s
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.20.3
+  version: 0.20.4
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-08 00:00:00.000000000 Z
+date: 2020-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace
@@ -24,20 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.3'
-- !ruby/object:Gem::Dependency
-  name: bitcoin
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.2.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: bitcoin-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -100,154 +86,140 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.8
+        version: 0.2.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.8
+        version: 0.2.11
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.17
+        version: '5.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.17
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: debase
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.2
+        version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.2
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.5.0
+        version: 5.14.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.5.0
+        version: 5.14.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.1
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 4.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 4.0.1
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.61.0
+        version: 0.91.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.61.0
+        version: 0.91.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.31.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.31.0
-- !ruby/object:Gem::Dependency
-  name: ruby-debug-ide
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 1.43.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 1.43.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.6
+        version: 3.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.6
+        version: 3.9.1
 description: |-
   This is a simple Bitcoin client, to use from command line
   or from your Ruby app. You don't need to run any Bitcoin software,
@@ -324,7 +296,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="