sibit 0.18.3 → 0.18.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6805c243e46030be83939f3f77aed146e40aa753693316b649fa465c8f1cacf
-  data.tar.gz: 4ae1c9f68bc690ea3e73ef1686707c078bd262c4c98f87d6689c7c952bae9845
+  metadata.gz: 9190dd104e8af92e3a5d8f1f6a967ef5d001fcf47e51adbaf260a281ecf043a5
+  data.tar.gz: f6b2280a10d118ad474b02022ad428de4c5775632c8f98a7f552c100ddb25460
 SHA512:
-  metadata.gz: f496223f5853ec59fa7b2f4647d06ffc735d7a810cc23b09cecd7621e88657b3fbcdb1d897609060913246dc20e784b916d4d997fd909f1a69e0ace2249e99bb
-  data.tar.gz: 2da853866f8a5db42323da57b79fbc244c7eccf9d58140a5b1faa33e218f72e12d31b025c1748ab582e86d8f5983166bed3b68ca40c5e92745537d2174072e8d
+  metadata.gz: 863c1ce07d8c74d1029d29a27711244e12350d23f2cdcdc0da21a41793fdd98ce5685a8a725814c691d633e65e6d6858aa1cc716382a4465f93973df773a802c
+  data.tar.gz: 4b7556e9a790db63e63c2cdb0b836b8e3a7f1a9153cb1eba18f722c701b460c379ccda784feb40773f627e78f8129ef78ca7d2e9648431ecaa3608ef6409c89f

data/lib/sibit/bitcoinchain.rb

@@ -59,16 +59,23 @@ class Sibit
         URI("https://api-r.bitcoinchain.com/v1/block/#{hash}")
       )[0]['next_block']
       nxt = nil if nxt == '0000000000000000000000000000000000000000000000000000000000000000'
+      @log.info("The next block of #{hash} is #{nxt}")
       nxt
     end
 
     # Gets the balance of the address, in satoshi.
     def balance(address)
       json = Sibit::Json.new(http: @http, log: @log).get(
-        URI("https://api-r.bitcoinchain.com/v1/address/#{address}")
+        URI("https://api-r.bitcoinchain.com/v1/address/#{address}"),
+        accept: [200, 409]
       )[0]
-      raise Sibit::Error, "Address #{address} not found" if json.nil?
-      b = (json['balance'] * 100_000_000).to_i
+      b = json['balance']
+      if b.nil?
+        @log.info("The balance of #{address} is not visible")
+        return 0
+      end
+      b *= 100_000_000
+      b = b.to_i
       @log.info("The balance of #{address} is #{b} satoshi")
       b
     end

data/lib/sibit/blockchain.rb

@@ -75,9 +75,9 @@ class Sibit
     # Gets the balance of the address, in satoshi.
     def balance(address)
       json = Sibit::Json.new(http: @http, log: @log).get(
-        URI("https://blockchain.info/rawaddr/#{address}")
+        URI("https://blockchain.info/rawaddr/#{address}?limit=0"),
+        accept: [200, 500]
       )
-      @log.info("Total transactions: #{json['n_tx']}")
       @log.info("Received/sent: #{json['total_received']}/#{json['total_sent']}")
       json['final_balance']
     end

data/lib/sibit/blockchair.rb

@@ -66,7 +66,10 @@ class Sibit
       json = Sibit::Json.new(http: @http, log: @log).get(
         URI("https://api.blockchair.com/bitcoin/dashboards/address/#{address}?#{the_key}")
       )['data'][address]
-      raise Sibit::Error, "Address #{address} not found" if json.nil?
+      if json.nil?
+        @log.info("Address #{address} not found")
+        return 0
+      end
       b = json['address']['balance']
       @log.info("The balance of #{address} is #{b} satoshi")
       b
@@ -74,17 +77,17 @@ class Sibit
 
     # Get recommended fees, in satoshi per byte.
     def fees
-      raise Sibit::Error, 'Not implemented yet'
+      raise Sibit::Error, 'Blockchair doesn\'t implement fees()'
     end
 
     # Gets the hash of the latest block.
     def latest
-      raise Sibit::Error, 'Not implemented yet'
+      raise Sibit::Error, 'Blockchair doesn\'t implement latest()'
     end
 
     # Fetch all unspent outputs per address.
     def utxos(_sources)
-      raise Sibit::Error, 'Not implemented yet'
+      raise Sibit::Error, 'Blockchair doesn\'t implement utxos()'
     end
 
     # Push this transaction (in hex format) to the network.
@@ -93,11 +96,12 @@ class Sibit
         URI("https://api.blockchair.com/bitcoin/push/transaction?#{the_key}"),
         "data=#{hex}"
       )
+      @log.info("Transaction (#{hex.length} in hex) has been pushed to Blockchair")
     end
 
     # This method should fetch a Blockchain block and return as a hash.
     def block(_hash)
-      raise Sibit::Error, 'Not implemented yet'
+      raise Sibit::Error, 'Blockchair doesn\'t implement block()'
     end
 
     private

data/lib/sibit/btc.rb

@@ -54,12 +54,11 @@ class Sibit
     def balance(address)
       uri = URI("https://chain.api.btc.com/v3/address/#{address}/unspent")
       json = Sibit::Json.new(http: @http, log: @log).get(uri)
-      data = json['data']
-      if data.nil?
+      if json['err_no'] == 1
         @log.info("The balance of #{address} is zero (not found)")
         return 0
       end
-      txns = data['list']
+      txns = json['data']['list']
       balance = txns.map { |tx| tx['value'] }.inject(&:+) || 0
       @log.info("The balance of #{address} is #{balance}, total txns: #{txns.count}")
       balance
@@ -72,6 +71,7 @@ class Sibit
       )
       nxt = head['data']['next_block_hash']
       nxt = nil if nxt == '0000000000000000000000000000000000000000000000000000000000000000'
+      @log.info("The next block of #{hash} is #{nxt}")
       nxt
     end
 

data/lib/sibit/earn.rb

@@ -69,7 +69,7 @@ class Sibit
         URI('https://bitcoinfees.earn.com/api/v1/fees/recommended')
       )
       @log.info("Current recommended Bitcoin fees: \
-  #{json['hourFee']}/#{json['halfHourFee']}/#{json['fastestFee']} sat/byte")
+#{json['hourFee']}/#{json['halfHourFee']}/#{json['fastestFee']} sat/byte")
       {
         S: json['hourFee'] / 3,
         M: json['hourFee'],

data/lib/sibit/json.rb

@@ -48,7 +48,7 @@ class Sibit
     # Send GET request to the HTTP and return JSON response.
     # This method will also log the process and will validate the
     # response for correctness.
-    def get(uri, headers: {})
+    def get(uri, headers: {}, accept: [200])
       start = Time.now
       res = @http.client(uri).get(
         "#{uri.path.empty? ? '/' : uri.path}#{uri.query ? "?#{uri.query}" : ''}",
@@ -59,7 +59,7 @@ class Sibit
           'Accept-Encoding' => ''
         }.merge(headers)
       )
-      unless res.code == '200'
+      unless accept.include?(res.code.to_i)
         raise Sibit::Error, "Failed to retrieve #{uri} (#{res.code}): #{res.body}"
       end
       @log.info("GET #{uri}: #{res.code}/#{res.body.length}b in #{age(start)}")

data/lib/sibit/version.rb

@@ -26,5 +26,5 @@
 # License:: MIT
 class Sibit
   # Current version of the library.
-  VERSION = '0.18.3'
+  VERSION = '0.18.4'
 end

data/test/test_live.rb

@@ -23,6 +23,7 @@
 require 'minitest/autorun'
 require 'webmock/minitest'
 require 'json'
+require 'backtrace'
 require_relative '../lib/sibit'
 
 # Live tests.
@@ -60,6 +61,14 @@ class TestLive < Minitest::Test
     end
   end
 
+  def test_absent_balance
+    for_each do |api|
+      hash = '12NJ7DxjBMCkk7EFdb6nXnMsuJV1nAXGiM'
+      satoshi = api.balance(hash)
+      assert_equal(0, satoshi)
+    end
+  end
+
   def test_latest
     for_each do |api|
       hash = api.latest
@@ -108,14 +117,14 @@ class TestLive < Minitest::Test
     skip if ENV['skip_live']
     WebMock.allow_net_connect!
     apis = []
+    require_relative '../lib/sibit/btc'
+    apis << Sibit::Btc.new
     require_relative '../lib/sibit/blockchain'
     apis << Sibit::Blockchain.new
     require_relative '../lib/sibit/blockchair'
     apis << Sibit::Blockchair.new
     require_relative '../lib/sibit/cryptoapis'
     apis << Sibit::Cryptoapis.new('')
-    require_relative '../lib/sibit/btc'
-    apis << Sibit::Btc.new
     require_relative '../lib/sibit/cex'
     apis << Sibit::Cex.new
     require_relative '../lib/sibit/bitcoinchain'
@@ -124,7 +133,7 @@ class TestLive < Minitest::Test
       begin
         yield api
       rescue Sibit::Error => e
-        puts e.message
+        puts Backtrace.new(e).to_s
       end
     end
   end

data/test/test_sibit.rb

@@ -87,7 +87,7 @@ class TestSibit < Minitest::Test
   def test_get_balance
     stub_request(
       :get,
-      'https://blockchain.info/rawaddr/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f'
+      'https://blockchain.info/rawaddr/1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f?limit=0'
     ).to_return(body: '{"final_balance": 100}')
     sibit = Sibit.new
     balance = sibit.balance('1MZT1fa6y8H9UmbZV6HqKF4UY41o9MGT5f')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sibit
 version: !ruby/object:Gem::Version
-  version: 0.18.3
+  version: 0.18.4
 platform: ruby
 authors:
 - Yegor Bugayenko