siba_api 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bbba86823deead2120faa71d5277a25da5a1e4ca99b9b1c60f25fb7fda70678
-  data.tar.gz: cc0f1f091f4deae42e93d167b56e6704f4df42caf5bbf91933f0e50e8afd75a3
+  metadata.gz: 0407b762bb94232363d947d76afaead1441da284c7b7e1aab71a8d9cb4322604
+  data.tar.gz: ca5290b3e621ada85990432ccb2544ee5d2548a9369e4e0d1ddf1368ccb89603
 SHA512:
-  metadata.gz: 1f452bf2a48e5b6af0cd9b1d7abea1633d495350b8063a19a48c24be246f9fc6ee13ea9cb05f0a34b01784e8bc7cf830696c9879c169bf6723ff18101cc822da
-  data.tar.gz: fe4feceba7c8f50a01582aecc811b9ae7bbc080425dfad1b9005023ee31f97e16e03af17e8304da0089f83f3cc60c70d57aeadd789f0c6894a266eec472d3781
+  metadata.gz: 551cb36918ce40eaf0f8cfa53cd1c874049f3ce68115f051366d2ad667ec73df669457eff3900f696b9fad2deaaae3b8deab5a4ac744313ec31ca0305ed549c6
+  data.tar.gz: a6d141af352dfc63ca5b73955ff68746244387581a807262e0736b535762505aba82efb4cb9637e1d4b97406645396f8074f11efc18dfdff99606d1a226fbac9

data/.irbrc

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'irb'
 require 'irb/completion'
 require 'rubygems'

data/.rubocop.yml

@@ -12,3 +12,10 @@ Layout/LineLength:
 AllCops:
   TargetRubyVersion: 2.4.0
   NewCops: enable
+
+Metrics/BlockLength:
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - 'test/**/*.rb'
+    - 'spec/**/*.rb'

data/README.md

@@ -1,5 +1,7 @@
 # SIBA API Wrapper
 
+![main workflow](https://github.com/dlage/siba_api/actions/workflows/main.yml/badge.svg)
+
 Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library
 into a gem. Put your Ruby code in the file `lib/siba_api`. To experiment with that code, run `bin/console` for an
 interactive prompt.

data/lib/siba_api/api.rb

@@ -80,28 +80,18 @@ module SIBAApi
       response = client.call(operation.to_sym, message: default_params.merge(params))
       self.last_response = response
 
+      process_operation_response(operation, response)
+    end
+
+    def process_operation_response(operation, response)
       if response_successful?(response)
         result = response.body["#{operation}_response".to_sym]["#{operation}_result".to_sym]
         return response if result == '0'
-
-        parsed_response = parse_response(result)
-        raise error_class(response.http.code), "Code: #{parsed_response[:codigo_retorno]}, response: #{response.body}, description: #{parsed_response[:descricao]}"
       end
 
       raise error_class(response.http.code), "Code: #{response.http.code}, response: #{response.body}"
     end
 
-    # Error:
-    # {:erros_ba=>
-    #   {:retorno_ba=>
-    #     {:linha=>"0",
-    #      :codigo_retorno=>"75",
-    #      :descricao=>
-    #       "Linha XML 6. -->The element 'Unidade_Hoteleira' in namespace 'http://sef.pt/BAws' has incomplete content. List of possible elements expected: 'Abreviatura' in namespace 'http://sef.pt/BAws'."},
-    #    :@xmlns=>"http://www.sef.pt/BAws"}}
-    #
-    # Success:
-    #
     def parse_response(result)
       inner_response = Nori.new(convert_tags_to: ->(tag) { tag.snakecase.to_sym }).parse(
         result
@@ -130,7 +120,7 @@ module SIBAApi
       # :nodoc:
       case method_name.to_s
       when /^(.*)\?$/
-        !!send(Regexp.last_match(1).to_s)
+        !send(Regexp.last_match(1).to_s).nil?
       when /^clear_(.*)$/
         send("#{Regexp.last_match(1)}=", nil)
       else

data/lib/siba_api/client.rb

@@ -46,21 +46,7 @@ module SIBAApi
     #     'Data_Saida' => '20220831',
     #     'Local_Residencia_Origem' => 'Place of Residence',
     def deliver_bulletins(file_number, bulletins = [], _global_params = {})
-      logger = Logger.new $stderr
-      logger.level = Logger::DEBUG
-      bulletins_xml = Gyoku.xml(
-        {
-          'MovimentoBAL' => {
-            'Unidade_Hoteleira' => build_hotel_unit,
-            'Boletim_Alojamento' => build_bulletins(bulletins),
-            'Envio' => build_control_data(file_number),
-            :@xmlns => 'http://sef.pt/BAws'
-          }
-        },
-        pretty_print: true
-      )
-      logger.debug(bulletins_xml)
-      bulletins_encoded = Base64.encode64(bulletins_xml)
+      bulletins_encoded = build_encoded_bulletins_xml(file_number, bulletins)
       response = request(
         operation: :entrega_boletins_alojamento,
         params: {
@@ -72,6 +58,19 @@ module SIBAApi
 
     protected
 
+    def build_encoded_bulletins_xml(file_number, bulletins)
+      bulletins_xml = Gyoku.xml(
+        {
+          'MovimentoBAL' => {
+            'Unidade_Hoteleira' => build_hotel_unit, 'Boletim_Alojamento' => build_bulletins(bulletins),
+            'Envio' => build_control_data(file_number), :@xmlns => 'http://sef.pt/BAws'
+          }
+        },
+        pretty_print: true
+      )
+      Base64.encode64(bulletins_xml)
+    end
+
     #   <Unidade_Hoteleira>
     #     <Codigo_Unidade_Hoteleira>121212121</Codigo_Unidade_Hoteleira>
     #     <Estabelecimento>00</Estabelecimento>
@@ -93,27 +92,11 @@ module SIBAApi
     #     <Numero_Ficheiro>97</Numero_Ficheiro>
     #     <Data_Movimento>2008-05-20T00:00:00</Data_Movimento>
     def build_control_data(file_number)
-      {
-        'Numero_Ficheiro' => file_number,
-        'Data_Movimento' => DateTime.now.strftime('%FT%T')
-      }
+      { 'Numero_Ficheiro' => file_number, 'Data_Movimento' => DateTime.now.strftime('%FT%T') }
     end
 
     def build_bulletins(bulletins = [])
-      translation_hash = {
-        surname: 'Apelido',
-        name: 'Nome',
-        nationality: 'Nacionalidade',
-        birthdate: 'Data_Nascimento',
-        place_of_birth: 'Local_Nascimento',
-        id_document: 'Documento_Identificacao',
-        document_country: 'Pais_Emissor_Documento',
-        document_type: 'Tipo_Documento',
-        start_date: 'Data_Entrada',
-        end_date: 'Data_Saida',
-        origin_country: 'Pais_Residencia_Origem',
-        origin_place: 'Local_Residencia_Origem'
-      }
+      translation_hash = bulletin_translation_hash
       translated_bulletins = []
       bulletins.each do |b|
         bt = {}
@@ -125,18 +108,25 @@ module SIBAApi
       translated_bulletins
     end
 
+    def bulletin_translation_hash
+      {
+        surname: 'Apelido', name: 'Nome', nationality: 'Nacionalidade',
+        birthdate: 'Data_Nascimento', place_of_birth: 'Local_Nascimento',
+        id_document: 'Documento_Identificacao', document_country: 'Pais_Emissor_Documento',
+        document_type: 'Tipo_Documento',
+        start_date: 'Data_Entrada', end_date: 'Data_Saida',
+        origin_country: 'Pais_Residencia_Origem', origin_place: 'Local_Residencia_Origem'
+      }
+    end
+
     def process_response(response)
       result = response
       case result
       when Hash
         result.transform_keys!(&:to_sym)
-        result.each_value do |r|
-          process_response(r)
-        end
+        result.each_value { |r| process_response(r) }
       when Array
-        result.each do |r|
-          process_response(r)
-        end
+        result.each { |r| process_response(r) }
       end
       result
     end

data/lib/siba_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SIBAApi
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: siba_api
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Dinis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-23 00:00:00.000000000 Z
+date: 2022-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gyoku