RubyGems - shuttlerock_shared_config - Versions diffs - 0.2.32 → 0.3.0 - Mend

shuttlerock_shared_config 0.2.32 → 0.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (5) hide show

checksums.yaml +4 -4
data/lib/shuttlerock_shared_config/version.rb +1 -1
data/lib/templates/.rubocop.yml +196 -22
data/lib/templates/PULL_REQUEST_TEMPLATE.md +52 -9
metadata +9 -9

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f860efc08c45b143efe1269e873978274e9f2cc0b7bfa1d153503dedc8324767
-  data.tar.gz: 51a8f8d7c980b3e27604bee962eb67546e109e180270cfbfe0c12ac37dad200f
+  metadata.gz: 3e9b2fe2b2782f6128f8cdbf526b4317df5b7fea3f8226e2588f28948295eb7e
+  data.tar.gz: 2cda90e5fe7309efd226cd3671b248e05d4f5768004c68daef3a5bb5634b8d3a
 SHA512:
-  metadata.gz: 3b142dfb076a5f67db27dbc62faa1d5155f42915e8767c89dd6a75a019bd3bcc405459dbfdd81d94319545f8cc344cf68feac5a600a64914075d8d0b0eacc9f3
-  data.tar.gz: 1500ae49faf0bdcbca9344cb52a532d2a8e13f7660f68bd9831276d72f463a83d5c42576470bdfd08b985a05f45b4fd794d0e4c0b68159fc2a88b535139ecc6f
+  metadata.gz: 8623af666469112c72474a5d7d5340a50ff2a054c0b7d86cc941dfffbb1e7645274988bd765c92b1fa9341f895c961d3501bba2fb8f9ebefd45fb56423b0fcd8
+  data.tar.gz: e1de180170c2059b26886ad26a9b9f5f2d9cc934d1fe5d4f19b072f7b5c9c059995e55dde7583599c6523fffb226d40bd34c8e925ba6a3feac04b16c576bb293

data/lib/shuttlerock_shared_config/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module ShuttlerockSharedConfig
-  VERSION = '0.2.32'
+  VERSION = '0.3.0'
 end

data/lib/templates/.rubocop.yml CHANGED Viewed

@@ -2,9 +2,11 @@
 require:
   - rubocop-performance
   - rubocop-rails
+  - rubocop-rspec
 AllCops:
-  TargetRubyVersion: 2.6
+  NewCops: enable
+  TargetRubyVersion: 3.0
   Exclude:
     - 'app/admin/**/*.rb'
     - 'bin/**/*'
@@ -12,6 +14,7 @@ AllCops:
     - 'db/schema.rb'
     - 'db/migrate/**/*'
     - 'lib/tasks/**/*'
+    - 'node_modules/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
@@ -42,26 +45,44 @@ Layout/HashAlignment:
   #   bb: 1
   EnforcedColonStyle: table
-Rails/ApplicationController:
+Style/Documentation:
+  Enabled: false
+Layout/EmptyLines:
+  Enabled: false
+Layout/LineLength:
+  Max: 150
+Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: true
-Rails/AfterCommitOverride:
+Lint/DuplicateElsifCondition:
   Enabled: true
-Rails/SquishedSQLHeredocs:
+Lint/DuplicateRescueException:
   Enabled: true
-Rails/WhereNot:
+Lint/EmptyConditionalBody:
   Enabled: true
-Style/Documentation:
-  Enabled: false
+Lint/FloatComparison:
+  Enabled: true
-Layout/EmptyLines:
-  Enabled: false
+Lint/MissingSuper:
+  Enabled: true
-Layout/LineLength:
-  Max: 150
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+Lint/SelfAssignment:
+  Enabled: true
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+Lint/UnreachableLoop:
+  Enabled: true
 Metrics/AbcSize:
   Enabled: true
@@ -86,6 +107,9 @@ Naming/MethodParameterName:
 Naming/BlockParameterName:
   MinNameLength: 2
+Naming/VariableNumber:
+  EnforcedStyle: normalcase
 Lint/ConstantDefinitionInBlock:
   Enabled: true
@@ -95,12 +119,21 @@ Lint/DeprecatedOpenSSLConstant:
 Lint/DuplicateRequire:
   Enabled: true
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: false
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
 Lint/EmptyFile:
   Enabled: true
 Lint/IdentityComparison:
   Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
 Lint/TrailingCommaInAttributeDeclaration:
   Enabled: true
@@ -113,15 +146,6 @@ Lint/UselessTimes:
 Layout/BeginEndAlignment:
   Enabled: true
-Layout/EmptyLinesAroundBlockBody:
-  Enabled: false
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-Lint/MixedRegexpCaptureTypes:
-  Enabled: false
 #Checks method call operators to not have spaces around them.
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
@@ -138,12 +162,99 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: true
+Performance/AncestorsInclude:
+  Enabled: true
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+Performance/RedundantSortBlock:
+  Enabled: true
+Performance/RedundantStringChars:
+  Enabled: true
+Performance/ReverseFirst:
+  Enabled: true
+Performance/SortReverse:
+  Enabled: true
+Performance/Squeeze:
+  Enabled: true
+Performance/StringInclude:
+  Enabled: true
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+Rails/ApplicationController:
+  Enabled: true
+Rails/AfterCommitOverride:
+  Enabled: true
+Rails/WhereNot:
+  Enabled: true
+Rails/FindById:
+  Enabled: true
+Rails/HasAndBelongsToMany:
+  Enabled: false
+Rails/Inquiry:
+  Enabled: true
+Rails/MailerName:
+  Enabled: true
+Rails/MatchRoute:
+  Enabled: true
+Rails/NegateInclude:
+  Enabled: true
+Rails/Pluck:
+  Enabled: true
+Rails/PluckInWhere:
+  Enabled: true
+Rails/RenderInline:
+  Enabled: true
+Rails/RenderPlainText:
+  Enabled: true
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+Rails/ShortI18n:
+  Enabled: true
+Rails/WhereExists:
+  Enabled: true
 Style/AccessModifierDeclarations:
   Enabled: false
+Style/AccessorGrouping:
+  Enabled: true
+Style/ArrayCoercion:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
 Style/BlockDelimiters:
   Enabled: false
+Style/CaseLikeIf:
+  Enabled: true
 Style/ClassAndModuleChildren:
   Enabled:       true
   EnforcedStyle: compact
@@ -151,15 +262,30 @@ Style/ClassAndModuleChildren:
 Style/CombinableLoops:
   Enabled: true
+Style/ExplicitBlockArgument:
+  Enabled: true
 Style/ExponentialNotation:
   Enabled: false
+Style/FetchEnvVar:
+  Enabled: true
 Style/FrozenStringLiteralComment:
-  Enabled: false
+  Enabled: true
+Style/GlobalStdStream:
+  Enabled: true
+Style/HashAsLastArrayItem:
+  Enabled: true
 Style/HashEachMethods:
   Enabled: true
+Style/HashLikeCase:
+  Enabled: true
 Style/HashTransformKeys:
   Enabled: true
@@ -169,6 +295,21 @@ Style/HashTransformValues:
 Style/KeywordParametersOrder:
   Enabled: true
+Style/OptionalBooleanParameter:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Style/RedundantSelfAssignment:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
 Style/RedundantReturn:
   Enabled: false
@@ -178,7 +319,7 @@ Style/RedundantRegexpCharacterClass:
 Style/RedundantRegexpEscape:
   Enabled: false
-Style/RedundantSelfAssignment:
+Style/SingleArgumentDig:
   Enabled: true
 Style/SlicingWithRange:
@@ -187,6 +328,9 @@ Style/SlicingWithRange:
 Style/SoleNestedConditional:
   Enabled: true
+Style/StringConcatenation:
+  Enabled: true
 Style/TrailingCommaInArguments:
   Enabled:                   true
   EnforcedStyleForMultiline: comma
@@ -206,3 +350,33 @@ Style/AndOr:
 # We use %w[ ], not %w( ) because the former looks like an array
 Style/PercentLiteralDelimiters:
   Enabled: false
+RSpec/AnyInstance:
+  Enabled: false
+RSpec/ExampleLength:
+  Max: 70
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+RSpec/MessageChain:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/MultipleMemoizedHelpers:
+  Max: 25
+RSpec/NamedSubject:
+  Enabled: false
+RSpec/NestedGroups:
+  Max: 10
+RSpec/StubbedMock:
+  Enabled: false
+RSpec/ContextWording:
+  Enabled: false

data/lib/templates/PULL_REQUEST_TEMPLATE.md CHANGED Viewed

@@ -1,17 +1,60 @@
-## Clubhouse Card Name Here
+[JIRA Story Link]( www.add-link-here )
-[Clubhouse Story](link-here)
+Copy and paste JIRA description here
+## Type of change
+Select all that apply:
+- [ ] Bug fix
+- [ ] New feature
+- [ ] Breaking change
+- [ ] Security issue
+- [ ] Infrastructure / network
+- [ ] Refactoring
+- [ ] Functional improvement
+## What changed?
+#### Before
+（エラーの）条件があれば、ここに書いてください。
+You clicked a button and it gave error
+#### After
+開発後の結果
+When you click the button, it does the thing.
-Description from the Clubhouse story
 ## How to test the PR
-- How to test feature 1
-  - Do this
-  - Do that
-  - Success
-- How to test feature 2
-- How to test feature 3
+#### Preparation:
+テスト用の条件、準備を書いてください。
+Prepare something before tests
+#### Tests
+Some page > Subpage (どこでテストをします)
+- Select something　（やること）
+- Click button　（やること）
+  - Success when something happens　（結果）
+Add screenshot if applicable　（スクショ）
+- Select something else　（やること）
+- Click button　（やること）
+  - Success when something else happens　（結果）
+Add screenshot if applicable　（スクショ）
+---
+**Regression:** If there were any substantial changes to view layer code (CSS, JS) or Javascript dependencies were updated do a general smoke test of the feature using the following Windows 7 browsers on Browser Stack. If Chrome only is chosen, only Chrome is tested normally without any other browsers.
+Chromeだけが選択だったら、他のブラウザーのテストは不要です。
+- [x] Chrome (Latest)
+- [ ] Firefox (Latest)
+- [ ] Internet Explorer 11
 ## Deployment Notes

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shuttlerock_shared_config
 version: !ruby/object:Gem::Version
-  version: 0.2.32
+  version: 0.3.0
 platform: ruby
 authors:
 - ElseThen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-01 00:00:00.000000000 Z
+date: 2022-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '1.29'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '1.29'
 - !ruby/object:Gem::Dependency
   name: danger
   requirement: !ruby/object:Gem::Requirement
@@ -98,16 +98,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: 2.6.6
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.30
 signing_key:
 specification_version: 4
 summary: Update shared config.