showcase 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8cc9956d43209ffcf07147c5ebd550aa6dd07407
-  data.tar.gz: 2f0302d869f55ac73959facae8ce2595d4c5f4b2
+  metadata.gz: bcf0fde90d484b35c54b9cfb8ef72123de71a78d
+  data.tar.gz: fdcc72c89960d828ab4d496974cb45c01045dc19
 SHA512:
-  metadata.gz: 28fdce56fdb476019ecf50d476f614bba7d8c7a01d569d78abe6c824ef213f930972d2b90ddf5010143f0d148527ba1f9f9c60e87908e1b674e75a95676ef1b7
-  data.tar.gz: d613dce8342d633d97368a003937a068e64bd2d8ec8dc8825cf857648e9c759281c31b15413a35592b9883c4880ec68670d7e56065535bd4c0539510a58740f4
+  metadata.gz: 72365b989e2d2aeef8f757cbe85607097da0a602510652d03266b6d352f4c5036164dfe81376649407f47620af7296bde6bf7f8def7edc02a31b04fbfbda644b
+  data.tar.gz: c8774f411e41452fc643f952ed6c43413968d2246421cabce9b38d4854f23d80609d43f198328d5be234e8fb7b1f0bf96c4d1496480474044cffb3716a17cf6f

data/lib/showcase/errors.rb

@@ -0,0 +1,5 @@
+module Showcase
+  class PresenterClassNotFound < RuntimeError
+  end
+end
+

data/lib/showcase/helpers/present.rb

@@ -2,6 +2,8 @@ require 'active_support/concern'
 require 'active_support/inflector'
 require 'active_support/core_ext/hash/keys'
 
+require 'showcase/errors'
+
 module Showcase
   module Helpers
     module Present
@@ -20,6 +22,9 @@ module Showcase
 
         if obj || options.fetch(:nil_presenter, false)
           klass ||= presenter_class(obj)
+          if klass.nil?
+            raise Showcase::PresenterClassNotFound, "Unable to guess a presenter class for #{obj.inspect}!"
+          end
           klass.new(obj, context)
         else
           nil
@@ -37,7 +42,9 @@ module Showcase
           klass = "#{k.name}Presenter".safe_constantize
           return klass if klass
         end
+        nil
       end
     end
   end
 end
+

data/lib/showcase/version.rb

@@ -1,4 +1,4 @@
 module Showcase
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end
 

data/spec/helpers_spec.rb

@@ -2,23 +2,33 @@ require 'spec_helper'
 
 describe Showcase::Helpers do
   let(:object) { Person.new('Steve Ballmer') }
-  let(:derived_object) { EnterpriseCustomer.new('Tito Traves') }
+  let(:subclass_object) { EnterpriseCustomer.new('Tito Traves') }
+  let(:object_with_no_presenter) { Shop.new }
   let(:context) { Context.new }
 
   describe '.present' do
-    it 'instantiates a new presenter, inferring the class' do
+    it 'instantiates a new presenter, inferring the presenter class' do
       PersonPresenter.stub(:new).with(object, context).and_return 'Presenter'
       context.present(object).should == 'Presenter'
     end
-    it "instantiates a new presenter, searching presenter class in object ancestors chain" do
-      PersonPresenter.stub(:new).with(derived_object, context).and_return 'Presenter'
-      context.present(derived_object).should == 'Presenter'
+    context 'with a superclass presenter' do
+      it "instantiates a new presenter, searching presenter class in object ancestors chain" do
+        PersonPresenter.stub(:new).with(subclass_object, context).and_return 'Presenter'
+        context.present(subclass_object).should == 'Presenter'
+      end
     end
-    it 'the presenter class to use can be specified as the second parameter' do
+    context 'with no existing presenter class' do
+      it "raises a PresenterClassNotFound error" do
+        expect {
+          context.present(object_with_no_presenter)
+        }.to raise_error(Showcase::PresenterClassNotFound)
+      end
+    end
+    it 'uses the specified presenter class, when passed' do
       ProjectPresenter.stub(:new).with(object, context).and_return 'Presenter'
       context.present(object, ProjectPresenter).should == 'Presenter'
     end
-    it 'the context to use can be specified as third parameter' do
+    it 'uses the specified context, when passed' do
       different_context = double
       context.present(object, ProjectPresenter, different_context).view_context.should == different_context
     end
@@ -36,3 +46,4 @@ describe Showcase::Helpers do
     end
   end
 end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: showcase
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Stefano Verna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-14 00:00:00.000000000 Z
+date: 2013-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -101,6 +101,7 @@ files:
 - lib/generators/showcase/presenter/presenter_generator.rb
 - lib/generators/showcase/presenter/templates/presenter.rb
 - lib/showcase.rb
+- lib/showcase/errors.rb
 - lib/showcase/helpers/config_object.rb
 - lib/showcase/helpers/html_options.rb
 - lib/showcase/helpers/module_method_builder.rb
@@ -146,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A barebone and framework agnostic presenter implementation