show_me_the_cookies 5.0.1 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d294688897e90476af27c9e42d195f55e2b0d5c61c1765db4ebda6b3b180bf1
-  data.tar.gz: 27662bfab37e69bd0c4ed51acd0122259009f160c9774faa7741e4d1e1c790bc
+  metadata.gz: 733e1bf58e719ff4734c5ab7992c0d2f450e20e4bd4adb9e561660586e365f81
+  data.tar.gz: 56bbc390e84918eae097eb1a6b877197dd52a89ff34ed2f3f5550f65664bbdeb
 SHA512:
-  metadata.gz: 18282eb1b5cdd16cf88f78e126b02c1ea098223f8339ec8ed19c9d0a0ccb457e8038523200c38d6f6e2d2ed4e6f9af0946bc6fa13c53f5a43805ec4a7ef7bd09
-  data.tar.gz: 5089d31dc352bfa76e77a634d3449f948ecc8502d728e9a9d4a2e4e867f3beaed61f51b4ad73175f553d22654c35abbeb992a61dc7e5fad1229db9f8581a5261
+  metadata.gz: 1036a7874266a20ce068f0be468a9a1d524aeca7557398ded8398c63964d3fc8c6e7ae473ba9f472bb0fb05f94e95802777d354580aed5d3e3772507e297b56a
+  data.tar.gz: 3ce7610725681a70d5e49c6b419e13f734b29b5e6f9a002170ade038f1d24554d2c44f54e2f30001fedde41420a493fcad8fce4cc8b6d85aadf588628773882c

data/Changelog.md

@@ -1,6 +1,20 @@
+# 6.0.0
+
+## Breaking change: Poltergeist removed
+
+It's been obsolete for a while now. If you still need it, you can copy the driver / registration into your app's test code.
+
+## Fix incompatibility with rack-test 2.0
+
+Thanks juno. https://github.com/nruth/show_me_the_cookies/pull/64
+This will likely break rack-test 1.x as it uses new methods/API to get the cookie store.
+To restore that, override the changed code in your test setup, or register a custom
+rack-test1 driver based on the old code.
+
 # 5.0.1
 
-## Gem development dependencies
+## Gem development dependencies
+
 chromedriver-helper -> webdrivers. Bundler -> 2.0.2. Should not affect your app.
 
 # 5.0

data/Gemfile

@@ -7,8 +7,7 @@ gem 'rake' # for releases
 
 group :test do
   gem 'rspec', '~> 3.0'
-  gem 'poltergeist'
   gem 'sinatra'
   gem 'selenium-webdriver'
-  gem 'webdrivers', '~> 4.0' # chromedriver installer
+  gem 'webdrivers', require: false # chromedriver installer
 end

data/Gemfile.lock

@@ -1,74 +1,74 @@
 PATH
   remote: .
   specs:
-    show_me_the_cookies (5.0.1)
+    show_me_the_cookies (6.0.0)
       capybara (>= 2, < 4)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    addressable (2.7.0)
+    addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
-    capybara (3.32.1)
+    capybara (3.37.1)
       addressable
+      matrix
       mini_mime (>= 0.1.3)
       nokogiri (~> 1.8)
       rack (>= 1.6.0)
       rack-test (>= 0.6.3)
-      regexp_parser (~> 1.5)
+      regexp_parser (>= 1.5, < 3.0)
       xpath (~> 3.2)
-    childprocess (3.0.0)
-    cliver (0.3.2)
-    diff-lcs (1.3)
-    mini_mime (1.0.2)
-    mini_portile2 (2.4.0)
+    childprocess (4.1.0)
+    diff-lcs (1.5.0)
+    matrix (0.4.2)
+    mini_mime (1.1.2)
+    mini_portile2 (2.8.0)
     mustermann (1.1.1)
       ruby2_keywords (~> 0.0.1)
-    nokogiri (1.10.9)
-      mini_portile2 (~> 2.4.0)
-    poltergeist (1.18.1)
-      capybara (>= 2.1, < 4)
-      cliver (~> 0.3.1)
-      websocket-driver (>= 0.2.0)
-    public_suffix (4.0.5)
-    rack (2.2.2)
-    rack-protection (2.0.8.1)
+    nokogiri (1.13.7)
+      mini_portile2 (~> 2.8.0)
+      racc (~> 1.4)
+    public_suffix (4.0.7)
+    racc (1.6.0)
+    rack (2.2.4)
+    rack-protection (2.2.0)
       rack
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rake (13.0.1)
-    regexp_parser (1.7.0)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rack-test (2.0.2)
+      rack (>= 1.3)
+    rake (13.0.6)
+    regexp_parser (2.5.0)
+    rexml (3.2.5)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    ruby2_keywords (0.0.2)
-    rubyzip (2.3.0)
-    selenium-webdriver (3.142.7)
-      childprocess (>= 0.5, < 4.0)
-      rubyzip (>= 1.2.2)
-    sinatra (2.0.8.1)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    ruby2_keywords (0.0.5)
+    rubyzip (2.3.2)
+    selenium-webdriver (4.3.0)
+      childprocess (>= 0.5, < 5.0)
+      rexml (~> 3.2, >= 3.2.5)
+      rubyzip (>= 1.2.2, < 3.0)
+      websocket (~> 1.0)
+    sinatra (2.2.0)
       mustermann (~> 1.0)
-      rack (~> 2.0)
-      rack-protection (= 2.0.8.1)
+      rack (~> 2.2)
+      rack-protection (= 2.2.0)
       tilt (~> 2.0)
     tilt (2.0.10)
-    webdrivers (4.3.0)
+    webdrivers (5.0.0)
       nokogiri (~> 1.6)
       rubyzip (>= 1.3.0)
-      selenium-webdriver (>= 3.0, < 4.0)
-    websocket-driver (0.7.1)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.4)
+      selenium-webdriver (~> 4.0)
+    websocket (1.2.9)
     xpath (3.2.0)
       nokogiri (~> 1.8)
 
@@ -76,13 +76,12 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  poltergeist
   rake
   rspec (~> 3.0)
   selenium-webdriver
   show_me_the_cookies!
   sinatra
-  webdrivers (~> 4.0)
+  webdrivers
 
 BUNDLED WITH
-   2.0.2
+   2.2.16

data/README.md

@@ -1,10 +1,10 @@
 # Show me the cookies
 
-[![Build Status](https://semaphoreapp.com/api/v1/projects/9a0dc444-fd04-4187-95a7-7a07abecbad7/201807/shields_badge.png)](https://semaphoreapp.com/nruth/show_me_the_cookies) [![Gem Version](https://badge.fury.io/rb/show_me_the_cookies.svg)](http://badge.fury.io/rb/show_me_the_cookies)
+[![Build Status](https://semaphoreci.com/api/v1/projects/9a0dc444-fd04-4187-95a7-7a07abecbad7/201807/shields_badge.png)](https://semaphoreci.com/nruth/show_me_the_cookies) [![Gem Version](https://badge.fury.io/rb/show_me_the_cookies.svg)](http://badge.fury.io/rb/show_me_the_cookies)
 
 Some helpers for poking around at your Capybara driven browser's cookies in integration tests.
 
-Provides drivers for rack-test, [selenium-webdriver](https://rubygems.org/gems/selenium-webdriver), and [Poltergeist](https://github.com/teampoltergeist/poltergeist) (PhantomJS).
+Provides drivers for rack-test and [selenium-webdriver](https://rubygems.org/gems/selenium-webdriver).
 
 You can add new drivers to  your application by implementing an adapter class and calling ShowMeTheCookies.register_adapter in your test code (e.g. a spec/support file). But in that case you might prefer to skip this gem and use your driver's api directly.
 

data/lib/show_me_the_cookies/adapters/rack_test.rb

@@ -36,7 +36,7 @@ module ShowMeTheCookies
 
   private
     def cookie_jar
-      @rack_test_driver.browser.current_session.instance_variable_get(:@rack_mock_session).cookie_jar
+      @rack_test_driver.browser.current_session.cookie_jar
     end
 
     def cookies

data/lib/show_me_the_cookies/version.rb

@@ -1,5 +1,5 @@
 # change gem version here then use bundler's rake tasks to make a new release
 # follow semantic versioning http://guides.rubygems.org/patterns/#semantic-versioning
 module ShowMeTheCookies
-  VERSION = '5.0.1'
+  VERSION = '6.0.0'
 end

data/lib/show_me_the_cookies.rb

@@ -1,6 +1,5 @@
 module ShowMeTheCookies
   require 'show_me_the_cookies/adapters/rack_test'
-  require 'show_me_the_cookies/adapters/poltergeist'
   require 'show_me_the_cookies/adapters/selenium'
   require 'show_me_the_cookies/adapters/selenium_chrome'
 
@@ -22,7 +21,6 @@ module ShowMeTheCookies
   register_adapter(:selenium_chrome, ShowMeTheCookies::SeleniumChrome)
   register_adapter(:selenium_chrome_headless, ShowMeTheCookies::SeleniumChrome)
   register_adapter(:rack_test, ShowMeTheCookies::RackTest)
-  register_adapter(:poltergeist, ShowMeTheCookies::Poltergeist)
 
   # puts a string summary of the cookie
   def show_me_the_cookie(cookie_name)

data/show_me_the_cookies.gemspec

@@ -14,8 +14,6 @@ Gem::Specification.new do |s|
   s.licenses = ["MIT"]
 
   s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
   s.add_dependency('capybara', ['>= 2', '< 4'])
 end

data/spec/shared_examples_for_api.rb

@@ -1,4 +1,4 @@
-shared_examples "the API" do
+RSpec.shared_examples "the API" do
 
   describe "for getting cookie hashes" do
     describe "get_me_the_cookie" do

data/spec/spec_helper.rb

@@ -11,6 +11,7 @@ Capybara.app = Sinatra::Application
 require 'show_me_the_cookies'
 RSpec.configure do |config|
   config.include(ShowMeTheCookies, type: :feature)
+  config.disable_monkey_patching!
 end
 
 Capybara.server_port = 36363

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: show_me_the_cookies
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 6.0.0
 platform: ruby
 authors:
 - Nicholas Rutherford
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-12 00:00:00.000000000 Z
+date: 2022-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -44,14 +44,12 @@ files:
 - README.md
 - Rakefile
 - lib/show_me_the_cookies.rb
-- lib/show_me_the_cookies/adapters/poltergeist.rb
 - lib/show_me_the_cookies/adapters/rack_test.rb
 - lib/show_me_the_cookies/adapters/selenium.rb
 - lib/show_me_the_cookies/adapters/selenium_chrome.rb
 - lib/show_me_the_cookies/version.rb
 - show_me_the_cookies.gemspec
 - spec/app/set_cookie.rb
-- spec/drivers/poltergeist_spec.rb
 - spec/drivers/rack-test_spec.rb
 - spec/drivers/selenium_chrome_headless_spec.rb
 - spec/drivers/selenium_chrome_spec.rb
@@ -79,18 +77,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Cookie manipulation for Capybara drivers
-test_files:
-- spec/app/set_cookie.rb
-- spec/drivers/poltergeist_spec.rb
-- spec/drivers/rack-test_spec.rb
-- spec/drivers/selenium_chrome_headless_spec.rb
-- spec/drivers/selenium_chrome_spec.rb
-- spec/drivers/selenium_headless_spec.rb
-- spec/drivers/selenium_spec.rb
-- spec/drivers/unknown_driver_spec.rb
-- spec/shared_examples_for_api.rb
-- spec/spec_helper.rb
+test_files: []

data/lib/show_me_the_cookies/adapters/poltergeist.rb

@@ -1,50 +0,0 @@
-module ShowMeTheCookies
-  class Poltergeist
-    def initialize(driver)
-      @browser = driver.browser
-      @driver = driver
-    end
-
-    def get_me_the_cookie(name)
-      cookie = cookies_hash[name.to_s]
-      translate(cookie) unless cookie.nil?
-    end
-
-    def get_me_the_cookies
-      cookies_hash.values.map(&method(:translate))
-    end
-
-    def expire_cookies
-      cookies_hash.each do |name, cookie|
-        delete_cookie(name) if (cookie.expires rescue nil).nil?
-      end
-    end
-
-    def delete_cookie(name)
-      @browser.remove_cookie(name.to_s)
-    end
-
-    def create_cookie(name, value, options)
-      # see: https://github.com/jonleighton/poltergeist#manipulating-cookies
-      @driver.set_cookie(name, value, options)
-    end
-
-  private
-
-    def cookies_hash
-      @browser.cookies
-    end
-
-    def translate(cookie)
-      {
-        :name => cookie.name,
-        :domain => cookie.domain,
-        :value => cookie.value,
-        :expires => (cookie.expires rescue nil),
-        :path => cookie.path,
-        :secure => cookie.secure?,
-        :httponly => cookie.httponly?
-      }
-    end
-  end
-end

data/spec/drivers/poltergeist_spec.rb

@@ -1,27 +0,0 @@
-require 'spec_helper'
-require 'shared_examples_for_api'
-require 'capybara/poltergeist'
-
-RSpec.describe 'Poltergeist', type: :feature do
-  before(:each) do
-    Capybara.current_driver = :poltergeist
-  end
-
-  describe 'the testing rig' do
-    it 'should load the sinatra app' do
-      visit '/'
-      expect(page).to have_content('Cookie setter ready')
-    end
-  end
-
-  describe 'get_me_the_cookie' do
-    it 'reads httponly option' do
-      visit '/set_httponly/foo/bar'
-      expect(get_me_the_cookie('foo')).to include(
-        name: 'foo', value: 'bar', httponly: true
-      )
-    end
-  end
-
-  it_behaves_like 'the API'
-end