shoulda 3.6.0 → 4.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd256fdc40162759558e33c2fd011d0c1c78f1fc6a48530c1981c9d5be59749c
-  data.tar.gz: 67eed1f001ac7575cf5e71ecd17543a03bdbf12cbd0953616520df25294b1def
+  metadata.gz: b87e253682d87a9713acd221ad7201c6ed1885d23eea6727dc8af5432432ee84
+  data.tar.gz: f28166eed87bc29a895445d5c5175aac1b08eff2b7d577eaee3b5c9a53524574
 SHA512:
-  metadata.gz: c3671625339d0e7f18941504b295e155104e8f67d6c7d7b70afcbf6face4c2fa21eaea02133c6b1da611b000df68f3b89cfee0197cd4ccbb8c81bfdef0542a08
-  data.tar.gz: 989e4dc4ed540ed7d2bbc88477f700926e036774ac5ea8310c313778af27ad82e5338ef06056dba2fde9d4fbf08e3cc3e7893522371a6352bb73009399031cf3
+  metadata.gz: 92e53a4b9fb2c8b90bc09d95f8dde8100c3849481a3978c355539addccd19b4dd18cd74ae52724f9d57891c5e838577c726a0422451b1432536d09c19317e48b
+  data.tar.gz: b55e8b92f1655845712ad2affe99681ad0917c3bc8edfdb547737c36e4dceac713249f9f69121d7bbb6407c49691bc06fe4728f21c6c00b12c1bef663183788d

data/.gitignore

@@ -1,5 +1,7 @@
 *.swo
 *.swp
+.DS_Store
+.byebug_history
 .bundle
 .svn/
 Gemfile.lock

data/.rubocop.yml

@@ -1,13 +1,192 @@
-inherit_from: .hound/ruby.yml
-Style/AlignParameters:
+AllCops:
+  TargetRubyVersion: 2.4
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
+Layout/ConditionPosition:
+  Enabled: false
+Layout/DotPosition:
+  EnforcedStyle: trailing
+Layout/HeredocIndentation:
+  Enabled: false
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+Lint/AmbiguousOperator:
+  Enabled: false
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+Lint/AssignmentInCondition:
+  Enabled: false
+Lint/DeprecatedClassMethods:
+  Enabled: false
+Lint/ElseLayout:
+  Enabled: false
+Lint/SuppressedException:
+  Enabled: false
+Lint/LiteralInInterpolation:
+  Enabled: false
+Lint/Loop:
+  Enabled: false
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+Lint/RequireParentheses:
+  Enabled: false
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false
+Lint/Void:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Metrics/LineLength:
+  IgnoredPatterns:
+    - "^[ ]*describe.+$"
+    - "^[ ]*context.+$"
+    - "^[ ]*shared_context.+$"
+    - "^[ ]*shared_examples_for.+$"
+    - "^[ ]*it.+$"
+    - "^[ ]*'.+?' => '.+?',?$"
+    - "^[ ]*\".+?\" => \".+?\",?$"
+    - "^[ ]*.+?: .+?$"
+Metrics/MethodLength:
+  Max: 30
+Naming/AccessorMethodName:
+  Enabled: false
+Naming/AsciiIdentifiers:
+  Enabled: false
+Naming/BinaryOperatorParameterName:
+  Enabled: false
+Style/ClassVars:
+  Enabled: false
+Style/ColonMethodCall:
+  Enabled: false
+Naming/FileName:
+  Enabled: false
+Rails:
+  Enabled: true
+Rails/Delegate:
+  Enabled: false
+Rails/HttpPositionalArguments:
+  Enabled: false
+Style/Alias:
+  Enabled: false
+Style/ArrayJoin:
+  Enabled: false
+Style/AsciiComments:
+  Enabled: false
+Style/Attr:
+  Enabled: false
+Style/CaseEquality:
+  Enabled: false
+Style/CharacterLiteral:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
 Style/CollectionMethods:
   PreferredMethods:
     find: detect
     reduce: inject
     collect: map
     find_all: select
+Style/CommentAnnotation:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/DoubleNegation:
+  Enabled: false
+Style/EachWithObject:
+  Enabled: false
+Style/EmptyLiteral:
+  Enabled: false
+Style/Encoding:
+  Enabled: false
+Style/EvenOdd:
+  Enabled: false
+Lint/FlipFlop:
+  Enabled: false
+Style/FormatString:
+  Enabled: false
 Style/FrozenStringLiteralComment:
   Enabled: false
+Style/GlobalVars:
+  Enabled: false
+Style/GuardClause:
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Style/IfWithSemicolon:
+  Enabled: false
+Style/InlineComment:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/LambdaCall:
+  Enabled: false
+Style/LineEndConcatenation:
+  Enabled: false
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+Style/ModuleFunction:
+  Enabled: false
+Style/NegatedIf:
+  Enabled: false
+Style/NegatedWhile:
+  Enabled: false
+Style/Next:
+  Enabled: false
+Style/NilComparison:
+  Enabled: false
+Style/Not:
+  Enabled: false
+Style/NumericLiterals:
+  Enabled: false
+Style/NumericPredicate:
+  Enabled: false
+Style/OneLineConditional:
+  Enabled: false
+Style/ParenthesesAroundCondition:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/PerlBackrefs:
+  Enabled: false
+Style/PreferredHashMethods:
+  Enabled: false
+Style/Proc:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Style/RedundantParentheses:
+  Enabled: false
+Style/RegexpLiteral:
+  Enabled: false
+Style/SelfAssignment:
+  Enabled: false
+Style/SignalException:
+  Enabled: false
+Style/SingleLineBlockParams:
+  Enabled: false
+Style/SingleLineMethods:
+  Enabled: false
+Style/SpecialGlobalVars:
+  Enabled: false
 Style/StringLiterals:
   EnforcedStyle: single_quotes
+Style/SymbolArray:
+  Enabled: false
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrivialAccessors:
+  Enabled: false
+Style/WhenThen:
+  Enabled: false
+Style/WhileUntilModifier:
+  Enabled: false
+Style/WordArray:
+  Enabled: false
+Style/VariableInterpolation:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+2.6.3

data/.travis.yml

@@ -1,12 +1,27 @@
+dist: trusty
 language: ruby
-sudo: false
-cache: bundler
-script: "bundle exec rake"
+dist: xenial
 rvm:
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
-  - 2.5.1
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3
 gemfile:
-  - gemfiles/4.2.gemfile
-  - gemfiles/5.0.gemfile
+  - gemfiles/rails_4_2.gemfile
+  - gemfiles/rails_5_0.gemfile
+  - gemfiles/rails_5_1.gemfile
+  - gemfiles/rails_5_2.gemfile
+  - gemfiles/rails_6_0.gemfile
+matrix:
+  exclude:
+    - rvm: 2.4.6
+      gemfile: gemfiles/rails_6_0.gemfile
+    - rvm: 2.6.3
+      gemfile: gemfiles/rails_4_2.gemfile
+# Source: <https://docs.travis-ci.com/user/languages/ruby/#bundler-20>
+before_install:
+  - gem update --system '2.7.8' --no-document
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2' --no-document
+  - nvm use v11.0.0
+install: "bundle install --jobs=3 --retry=3 --path vendor/bundle"
+script: "bundle exec rake"

data/Appraisals

@@ -1,18 +1,116 @@
+# Note: All of the dependencies here were obtained by running `rails new` with
+# various versions of Rails and copying lines from the generated Gemfile. It's
+# best to keep the gems here in the same order as they're listed there so you
+# can compare them more easily.
+
+shared_rails_dependencies = proc do
+  gem 'sqlite3', platform: :ruby
+end
+
+shared_spring_dependencies = proc do
+  gem 'spring'
+  gem 'spring-commands-rspec'
+end
+
+shared_test_dependencies = proc do
+  gem 'minitest-reporters'
+end
+
 shared_dependencies = proc do
-  gem 'listen'
-  gem 'sass-rails'
-  gem 'sqlite3'
-  gem 'rspec', '~> 3.0'
-  gem 'shoulda-context'
-  gem 'shoulda-matchers', '~> 3.0'
+  instance_eval(&shared_rails_dependencies)
+  instance_eval(&shared_spring_dependencies)
+  instance_eval(&shared_test_dependencies)
 end
 
-appraise '4.2' do
+appraise 'rails_4_2' do
   instance_eval(&shared_dependencies)
-  gem 'rails', '4.2.10'
+
+  gem 'rails', '~> 4.2.10'
+  gem 'sass-rails', '~> 5.0'
+  gem 'uglifier', '>= 1.3.0'
+  gem 'coffee-rails', '~> 4.1.0'
+  gem 'jquery-rails'
+  gem 'turbolinks'
+  gem 'jbuilder', '~> 2.0'
+  gem 'sdoc', '~> 0.4.0', group: :doc
+  gem 'bcrypt', '~> 3.1.7'
+
+  # Other dependencies we use
+  gem 'activeresource', '4.0.0'
+  gem 'json', '~> 1.4'
+  gem 'protected_attributes', '~> 1.0.6'
 end
 
-appraise '5.0' do
+appraise 'rails_5_0' do
   instance_eval(&shared_dependencies)
-  gem 'rails', '5.0.1'
+
+  gem 'rails', '~> 5.0.7'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.0'
+  gem 'sass-rails', '~> 5.0'
+  gem 'jquery-rails'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'listen', '~> 3.0.5'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+appraise 'rails_5_1' do
+  instance_eval(&shared_dependencies)
+  gem 'rails', '~> 5.1.6'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.7'
+  gem 'sass-rails', '~> 5.0'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'capybara', '~> 2.13'
+  gem 'selenium-webdriver'
+  gem 'listen', '>= 3.0.5', '< 3.2'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+appraise 'rails_5_2' do
+  instance_eval(&shared_dependencies)
+
+  gem 'rails', '~> 5.2.2'
+  gem 'rails-controller-testing', '>= 1.0.1'
+  gem 'puma', '~> 3.11'
+  gem 'bootsnap', '>= 1.1.0', require: false
+  gem 'sass-rails', '~> 5.0'
+  gem 'turbolinks', '~> 5'
+  gem 'jbuilder', '~> 2.5'
+  gem 'bcrypt', '~> 3.1.7'
+  gem 'capybara', '~> 3.1.1'
+  gem 'selenium-webdriver'
+  gem 'chromedriver-helper'
+  gem 'listen', '>= 3.0.5', '< 3.2'
+  gem 'spring-watcher-listen', '~> 2.0.0'
+end
+
+if (
+  Gem::Requirement.new('>= 2.5.0').satisfied_by?(Gem::Version.new(RUBY_VERSION))
+)
+  appraise 'rails_6_0' do
+    instance_eval(&shared_dependencies)
+
+    gem 'rails', '~> 6.0.2'
+    gem 'puma', '~> 4.1'
+    gem 'sass-rails', '>= 6'
+    gem 'webpacker', '~> 4.0'
+    gem 'turbolinks', '~> 5'
+    gem 'jbuilder', '~> 2.7'
+    gem 'bcrypt', '~> 3.1.7'
+    gem 'bootsnap', '>= 1.4.2', require: false
+    gem 'listen', '>= 3.0.5', '< 3.2'
+    gem 'spring-watcher-listen', '~> 2.0.0'
+    gem 'capybara', '>= 2.15'
+    gem 'selenium-webdriver'
+    gem 'webdrivers'
+
+    # Other dependencies
+    gem 'rails-controller-testing', '>= 1.0.4'
+    gem 'pg', '~> 1.1', platform: :ruby
+  end
 end

data/Gemfile

@@ -1,10 +1,14 @@
 source 'https://rubygems.org'
 
+gemspec
+
 gem 'appraisal', '~> 2.1'
-gem 'rails', '>= 4.2', '< 6'
-gem 'pry'
-gem 'pry-byebug'
-gem 'sqlite3', '~> 1.3.11'
+gem 'bundler', '~> 1.0'
+gem 'm'
 gem 'minitest', '~> 5.0'
 gem 'minitest-reporters', '~> 1.0'
-gem 'm'
+gem 'mry'
+gem 'pry-byebug'
+gem 'rubocop'
+gem 'snowglobe'
+gem 'warnings_logger'

data/README.md

@@ -1,26 +1,28 @@
-# Shoulda [![Gem Version][version-badge]][rubygems] [![Build Status][travis-badge]][travis] ![Downloads][downloads-badge]
+# Shoulda [![Gem Version][version-badge]][rubygems] [![Build Status][travis-badge]][travis] ![Downloads][downloads-badge] [![Hound][hound-badge]][hound]
 
 [version-badge]: http://img.shields.io/gem/v/shoulda.svg
 [rubygems]: http://rubygems.org/gems/shoulda
 [travis-badge]: http://img.shields.io/travis/thoughtbot/shoulda/master.svg
 [travis]: http://travis-ci.org/thoughtbot/shoulda
 [downloads-badge]: http://img.shields.io/gem/dtv/shoulda.svg
+[hound-badge]: https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg
+[hound]: https://houndci.com
 
 Shoulda helps you write more understandable, maintainable Rails-specific tests
-using Minitest.
+under Minitest.
 
-The `shoulda` gem doesn't contain any code of its own; it actually brings
-behavior from two other gems:
+## Overview
+
+As a meta gem, the `shoulda` gem doesn't contain any code of its own but rather
+brings in behavior from two other gems:
 
 * [Shoulda Context]
 * [Shoulda Matchers]
 
-See the READMEs for these projects for more information.
-
 [Shoulda Context]: https://github.com/thoughtbot/shoulda-context
 [Shoulda Matchers]: https://github.com/thoughtbot/shoulda-matchers
 
-## Overview
+For instance:
 
 ```ruby
 require "test_helper"
@@ -48,41 +50,46 @@ end
 Here, the `context` and `should` methods come from Shoulda Context; matchers
 (e.g. `have_many`, `allow_value`) come from Shoulda Matchers.
 
+See the READMEs for these projects for more information.
+
 ## Compatibility
 
-Shoulda is tested and supported against Ruby 2.2-2.4, Rails 4.2-5.0, and
-Minitest 5.
+Shoulda Matchers is [tested][travis] and supported against Ruby 2.4+, Rails 5.x,
+Rails 4.2.x, RSpec 3.x, and Minitest 5.x.
 
 ## Contributing
 
 Shoulda is open source, and we are grateful for [everyone][contributors] who's
 contributed so far.
 
+[contributors]: https://github.com/thoughtbot/shoulda/contributors
+
 If you'd like to contribute, please take a look at the
 [instructions](CONTRIBUTING.md) for installing dependencies and crafting a good
 pull request.
 
-[contributors]: https://github.com/thoughtbot/shoulda/contributors
-
 ## Versioning
 
 Shoulda follows Semantic Versioning 2.0 as defined at <http://semver.org>.
 
 ## License
 
-Shoulda is copyright © 2006-2017 [thoughtbot, inc][thoughtbot]. It is free
-software, and may be redistributed under the terms specified in the
-[MIT-LICENSE](MIT-LICENSE) file.
+Shoulda is copyright © 2006-2019 thoughtbot, inc. It is free software, and may
+be redistributed under the terms specified in the [MIT-LICENSE](MIT-LICENSE)
+file.
 
 ## About thoughtbot
 
-[<img src="http://presskit.thoughtbot.com/images/signature.svg" width="250" alt="thoughtbot logo">][thoughtbot]
+![thoughtbot][thoughtbot-logo]
+
+[thoughtbot-logo]: https://thoughtbot.com/brand_assets/93:44.svg
 
 Shoulda is maintained and funded by thoughtbot, inc. The names and logos for
 thoughtbot are trademarks of thoughtbot, inc.
 
-We are passionate about open source software. See [our other
-projects][community]. We are [available for hire][thoughtbot].
+We love open source software! See [our other projects][community] or [hire
+us][hire] to design, develop, and grow your product.
 
 [community]: https://thoughtbot.com/community?utm_source=github
+[hire]: https://thoughtbot.com/hire-us?utm_source=github
 [thoughtbot]: https://thoughtbot.com?utm_source=github