should_not 1.0.0 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 6846b4e1df6ccd2955b9af174dca2d88b036adb2
+  data.tar.gz: 885ed9c210f81cf5ab19bb87f26916ed01e7cec5
+SHA512:
+  metadata.gz: 31735bf17edcb99430701882b001b384a235623ca09a7ac6d0c24cbb8be83cd3410e43560bc12ad5da14ad99b222b972071908cfbfc46a1a4900b63f93a6a47e
+  data.tar.gz: 6b2e23108db276a38219c74217f564feca3818535af476a538ae5c8fcfa3ec064e566efbcab4e0d77d00f8e06886ca1893de294e5fb724820d4163a9e0fdadbc

data/README.md

@@ -48,6 +48,12 @@ Once it's ready, I'll be happy to add your port as a repo under the [`should-not
 If you'd like to contribute to the Ruby version `should_not`, we could use support for more testing frameworks.
 Just make sure that you have integration test coverage before you open a pull request.
 
+## Related Projects
+
+* The [should_clean gem](https://github.com/siyelo/should_clean) from @siyelo is a utility that changes `'it "should do something"'` to `'it "does something"'`
+* [BetterSpecs](http://betterspecs.org/#should) currently recommends not beginning your specs with "should."
+There is good discussion about this topic at their [GitHub issue](https://github.com/andreareginato/betterspecs/issues/15) about not starting with "should."
+
 ## License
 
 Available under the terms of the MIT license.

data/Rakefile

@@ -23,7 +23,7 @@ task :minitest do
   ruby = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
   output = `#{ruby} #{integration_file('minitest')}`
 
-  assert_contains!(output, '6 tests')
+  assert_contains!(output, '6 runs')
   assert_contains!(output, '2 failures')
   puts "MiniTest integration spec passed"
 end

data/integration/rspec.rb

@@ -2,24 +2,24 @@ require 'should_not/rspec'
 
 describe RSpec do
   it 'should fail when the string starts with should' do
-    1.should == 1
+    expect(1).to eq(1)
   end
 
   it 'can pass a normal test' do
-    1.should == 1
+    expect(1).to eq(1)
   end
 
   it 'does not mind if "should" is in the middle of a string' do
-    1.should == 1
+    expect(1).to eq(1)
   end
 
   describe 'a nested context' do
     it 'should also fail when the string starts with should' do
-      1.should == 1
+      expect(1).to eq(1)
     end
 
     it 'can also pass a normal test' do
-      1.should == 1
+      expect(1).to eq(1)
     end
   end
 end

data/lib/should_not/minitest.rb

@@ -2,6 +2,6 @@ require 'minitest/spec'
 require 'should_not/constants'
 
 MiniTest::Spec.before do |spec|
-  name = spec.__name__.to_s.gsub(ShouldNot::MINITEST_DESCRIPTION_PREFIX, '')
+  name = spec.name.to_s.gsub(ShouldNot::MINITEST_DESCRIPTION_PREFIX, '')
   flunk(ShouldNot::FAILURE_MESSAGE) if name.match(ShouldNot::STARTS_WITH_SHOULD)
 end

data/lib/should_not/rspec.rb

@@ -2,7 +2,7 @@ require 'rspec/core'
 require 'should_not/constants'
 
 RSpec.configure do |config|
-  config.before(:each) do
+  config.before(:each) do |example|
     # Not sure that last is correct here -- is the array ever larger than one element?
     description = example.metadata[:description_args].last.to_s
     fail(ShouldNot::FAILURE_MESSAGE) if description.match(ShouldNot::STARTS_WITH_SHOULD)

data/lib/should_not/version.rb

@@ -1,3 +1,3 @@
 module ShouldNot
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/should_not.gemspec

@@ -27,6 +27,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency 'minitest', '~> 5.0'
+  spec.add_development_dependency "rspec", '~> 3.0'
 end

data/spec/should_not_spec.rb

@@ -4,7 +4,7 @@ require 'should_not/rspec'
 
 describe ShouldNot do
   it 'has a version number' do
-    ShouldNot::VERSION.should_not be_nil
+    expect(ShouldNot::VERSION).to_not be_nil
   end
 
   describe 'constants' do
@@ -12,41 +12,42 @@ describe ShouldNot do
       subject { ShouldNot::STARTS_WITH_SHOULD }
 
       it 'matches the whole word "should" at the beginning of the string' do
-        'should foo bar'.should match(subject)
+        expect('should foo bar').to match(subject)
       end
 
       it 'matches when "should" is capitalized' do
-        'Should foo bar'.should match(subject)
+        expect('Should foo bar').to match(subject)
       end
 
       it 'does not match the word "should" in the middle of a string' do
-        'foo should bar'.should_not match(subject)
+        expect('foo should bar').to_not match(subject)
       end
 
       it "matches shouldn't at the beggining" do
-        "shouldn't foo bar".should match(subject)
+        expect("shouldn't foo bar").to match(subject)
       end
 
       it "does not match shouldn't in the middle" do
-        "foo shouldn't bar".should_not match(subject)
+        expect("foo shouldn't bar").to_not match(subject)
       end
 
       it 'does not other words starting with should' do
-        'shoulders are nice to have'.should_not match(subject)
-        'shoulda is a helpful library for testing Rails'.should_not match(subject)
+        expect('shoulders are nice to have').to_not match(subject)
+        expect('shoulda is a helpful library for testing Rails').to_not match(subject)
       end
     end
+
     describe 'MINITEST_DESCRIPTION_PREFIX' do
       subject { ShouldNot::MINITEST_DESCRIPTION_PREFIX }
 
       it 'matches the irrelevant part of the test method name' do
         stripped = 'test_0000_foo bar'.gsub(subject, '')
-        stripped.should == 'foo bar'
+        expect(stripped).to eq('foo bar')
       end
 
       it 'handles when there are more than 10k tests' do
         stripped = 'test_12345_foo bar'.gsub(subject, '')
-        stripped.should == 'foo bar'
+        expect(stripped).to eq('foo bar')
       end
     end
   end

metadata

@@ -1,93 +1,87 @@
 --- !ruby/object:Gem::Specification
 name: should_not
 version: !ruby/object:Gem::Version
-  version: 1.0.0
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Mark Rushakoff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-14 00:00:00.000000000 Z
+date: 2014-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: ! "  You should_not start your specs with the string \"should\".\n  If
-  every spec starts with \"should\", then it's redundant everywhere.\n\n  Instead,
-  write in an active tone:\n  `it \"should ignore nil elements\"` - BAD\n  `it \"ignores
-  nil elements\"` - GOOD\n"
+        version: '3.0'
+description: |2
+    You should_not start your specs with the string "should".
+    If every spec starts with "should", then it's redundant everywhere.
+
+    Instead, write in an active tone:
+    `it "should ignore nil elements"` - BAD
+    `it "ignores nil elements"` - GOOD
 email:
 - mark.rushakoff@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.MIT
 - README.md
@@ -105,33 +99,26 @@ files:
 homepage: https://github.com/should-not/should_not
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3309651739423284020
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3309651739423284020
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Fail specs that start with should.
 test_files:
 - integration/minitest.rb