short_inspect 0.0.1 → 0.0.2

data/README.md

@@ -6,21 +6,22 @@ Prevent `#inspect` to include unlimited nested instance variables.
 
 ```ruby
 require 'short_inspect'
-ShortInspect.apply_to(ActionDispatch::Routing::RouteSet, ActionController::Base)
+ShortInspect.apply_to(ActionDispatch::Routing::RouteSet)
+
+# or:
+ShortInspect.apply_minimal_to(ActionDispatch::Routing::RouteSet)
 ```
 
-For auto inclusion in common rails classes:
+The normal version will include instance variables on the top level with
+a simple value.
 
-```ruby
-require 'short_inspect/rails'
-```
+The minimal version will only include the class name and object id.
 
-For auto inclusion in all ruby classes:
+
+For auto inclusion in common rails classes:
 
 ```ruby
-require 'short_inspect/all'
+require 'short_inspect/rails'
 ```
 
-You probably shouldn't apply it to all classes.
-
 It's ~450% slower than the built-in `#inspect` method.

data/lib/short_inspect.rb

@@ -1,42 +1,31 @@
 require "short_inspect/version"
 
+
 module ShortInspect
-  class << self
-    attr_accessor :max_nested_inspected_value_length
-  end
-  self.max_nested_inspected_value_length = 50
 
   def self.included(base)
     base.class_eval do
       alias inspect_without_shortening inspect
 
       def inspect
-        s = to_s
-        if s[0..1] == '#<' && s[-1..-1] == '>'
-          "#{s[0..-2]}#{instance_variables_for_inspection}#{s[-1..-1]}"
-        else
-          s
-        end
+        "#<%s:0x%x%s>" % [ self.class.name, object_id << 1, instance_variables_for_short_inspect ]
       end
 
-      def instance_variables_for_inspection
+      def instance_variables_for_short_inspect
         s = instance_variables.map do |name|
-          "#{name}=#{ShortInspect.limit_inspected_value(instance_variable_get(name).inspect)}"
+          "#{name}=#{ShortInspect.basic_inspect(instance_variable_get(name))}"
         end.join(", ")
         s = " #{s}" if s.length != 0
         s
       end
+
     end
   end
 
-  def self.limit_inspected_value(long)
-    if long.length > max_nested_inspected_value_length
-      c3 = 5 # chars to keep at end
-      c2 = 3 # "..."
-      c1 = max_nested_inspected_value_length - c2 - c3
-      "#{long[0..c1-1]}...#{long[-c3..-1]}"
-    else
-      long
+  def self.basic_inspect obj
+    case obj
+    when String, Fixnum, Float, Symbol, Bignum then obj.inspect
+    else "#<%s:0x%x>" % [ obj.class.name, obj.object_id << 1 ]
     end
   end
 
@@ -61,13 +50,14 @@ module ShortInspect
     end
   end
 
+
   module Minimal
     def self.included(base)
       base.class_eval do
         alias inspect_without_shortening inspect
 
         def inspect
-          "#<%s:0x%x>" % [ self.class.name, object_id << 1 ]
+          ShortInspect.basic_inspect(self)
         end
       end
     end

data/lib/short_inspect/rails.rb

@@ -1,5 +1,8 @@
 require 'short_inspect'
 ShortInspect.apply_minimal_to(
   ActionDispatch::Routing::RouteSet,
-  ActionDispatch::Request
+  ActionDispatch::Request,
+  ActionView::OutputFlow,
+  ActionDispatch::Request,
+  ActionView::LookupContext
 )

data/lib/short_inspect/version.rb

@@ -1,3 +1,3 @@
 module ShortInspect
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/short_inspect_spec.rb

@@ -4,53 +4,33 @@ describe ShortInspect do
   describe "inspect" do
 
     it "doesn't apply automatically" do
-      object = TwoVariables.new(:red, TwoVariables.new(:blue, "extra " * 200))
-      object.inspect.length.should > 100
+      object = TestObject.new(:red, TestObject.new(:blue))
+      object.inspect.should include 'blue'
     end
 
     context "when applied" do
       before(:each){ ShortInspect.apply_to(Object) }
       after(:each){ ShortInspect.remove_from(Object) }
 
-      it "it limits the size of long instance variables" do
-        object = TwoVariables.new(:red, TwoVariables.new(:blue, "extra " * 200))
-        object.inspect.length.should < 100
-        object = TwoVariables.new(:red, "extra " * 20)
-        object.inspect.length.should < 100
-      end
-
-      it "is the same as the original when it's short" do
-        object = NoVariables.new
-        object.inspect.should == object.inspect_without_shortening
-
-        object = TwoVariables.new(:red, :medium)
-        object.inspect.should == object.inspect_without_shortening
+      it "it only includes instance variables on the top level" do
+        object = TestObject.new(:red, TestObject.new(:blue))
+        object.inspect.should include 'red'
+        object.inspect.should_not include 'blue'
       end
     end
 
   end
 
-  describe ShortInspect::Minimal do
-    describe "inspect" do
 
+  describe "ShortInspect::Minimal" do
+    describe "inspect" do
       context "when applied" do
         before(:each){ ShortInspect.apply_minimal_to(Object) }
         after(:each){ ShortInspect.remove_from(Object) }
 
-        it "is the same as the original when it's short" do
-          object = NoVariables.new
-          object.inspect.should == object.inspect_without_shortening
-        end
-
-        it "includes class name" do
-          object = TwoVariables.new(:red, 'large')
-          object.inspect.should include 'TwoVariables'
-        end
-
-        it "does not include instance variables at all" do
-          object = TwoVariables.new(:red, 'large')
+        it "it doesn't include instance variables at all" do
+          object = TestObject.new(:red)
           object.inspect.should_not include 'red'
-          object.inspect.should_not include 'large'
         end
       end
     end
@@ -58,13 +38,10 @@ describe ShortInspect do
 end
 
 
-class NoVariables
-end
-
-class TwoVariables
-  def initialize color, size
+class TestObject
+  def initialize color, child = nil
     @color = color
-    @size = size
+    @child = child
   end
 end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: short_inspect
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Levente Bagi
@@ -49,7 +49,6 @@ files:
 - Rakefile
 - benchmark/benchmark.rb
 - lib/short_inspect.rb
-- lib/short_inspect/all.rb
 - lib/short_inspect/rails.rb
 - lib/short_inspect/version.rb
 - short_inspect.gemspec

data/lib/short_inspect/all.rb

@@ -1,3 +0,0 @@
-require 'short_inspect'
-ShortInspect.apply_to(Object)
-