shopify_app 21.4.0 → 21.4.1

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f8bffcbbd9262af14d8b5d0c0333b2a17f4de563ad4c40134dec7b838eaf789b
4
- data.tar.gz: 0ba89c4f9ff64b366c3d368b70abcfdf2e02f1e0f66c796f5b16a6a5fafdcd07
3
+ metadata.gz: e65d60a59d8ea51db704069c1d982e4c527339768f7c4e759e50a23ebe4fdb09
4
+ data.tar.gz: b5aff8a08f5c91093d3114ff7bc88b43894b5be2e6011a3cdc28a7dc3ab670c6
5
5
  SHA512:
6
- metadata.gz: bc4dc9ccd6267a2eb7ff1d22e54f1527c0ab32cb61b83841bc71cc4bb79b14a33aa4021e13494e3167d0a7d20aeea86f9af9dd478ebff8400ec4b33ac1426417
7
- data.tar.gz: c2154db900a3fb4321be1d224c8d44987fdce714984b3004b87b4dd5301717832fa11b907fe88b261020da82b4c3255256d4e4ba4dd5800262a8e3daa4778f91
6
+ metadata.gz: 157fd8fe0c4ec1cb541cbbd1816ce4f950d4bde8cb5f71e37400fcf251de1928cc0954b28cfe2e9bf67d403b0746b0570a47b3891566df2eb2188c82ccf9de9f
7
+ data.tar.gz: 7025fa973e9e89e0b1ef93713fa6e831a33e401043b6627745617f51a6fe007673307911e5b72cabedd82a6cfc5cbbcdfdc00525b560728d6aff1fac7064147c
data/CHANGELOG.md CHANGED
@@ -1,6 +1,10 @@
1
1
  Unreleased
2
2
  ----------
3
3
 
4
+ 21.4.1 (Feb 21, 2023)
5
+ ----------
6
+ * Fixed bug where authentication redirect could still happen even though `reauth_on_access_scope_changes` is set to `false` [#1639](https://github.com/Shopify/shopify_app/pull/1639)
7
+
4
8
  21.4.0 (Jan 5, 2023)
5
9
  ----------
6
10
  * Updated shopify_api to 12.4.0 [#1633](https://github.com/Shopify/shopify_app/pull/1633)
data/CONTRIBUTING.md CHANGED
@@ -61,7 +61,7 @@ If you have a suggestion for the Shopify App gem or a feature request, provide t
61
61
 
62
62
  The process described here has several goals:
63
63
 
64
- * Maintain the Shopify App gem's quality
64
+ * Maintain the Shopify App gem's quality (does the change you're making have a test?)
65
65
  * Fix problems that are important to app developers
66
66
  * Enable a sustainable system for the Shopify App gem's maintainers to review contributions
67
67
 
@@ -74,7 +74,22 @@ Please follow these steps to have your contribution considered by the maintainer
74
74
 
75
75
  While the prerequisites above must be satisfied prior to having your pull request reviewed, the reviewer(s) may ask you to complete additional design work, tests, or other changes before your pull request can be ultimately accepted.
76
76
  </details>
77
-
77
+
78
+ ### Running tests
79
+
80
+ #### Test Environment Requirements
81
+
82
+ To run tests, you'll need to make sure that your development environment is setup correctly. You'll need:
83
+
84
+ * Ruby 3+ is installed on your system
85
+ * Install dependencies with `bundle install`
86
+
87
+ #### Executing Tests
88
+
89
+ * To run all tests: `bundle exec rake test`
90
+ * To run a specific test file: `bundle exec rake test TEST=test/controllers/callback_controller_test.rb`
91
+ * To run a single test: `bundle exec rake test TEST=test/controllers/callback_controller_test.rb:50` where `50` is the line number on or inside the test case.
92
+
78
93
  ### App Bridge client
79
94
 
80
95
  This gem ships with a UMD version of the App Bridge client. It lives inside the assets folder: `app/assets/javascripts/shopify_app/`. To update the client, simply download the UMD build from [unpkg.com](https://unpkg.com/@shopify/app-bridge) and save it into the folder.
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- shopify_app (21.4.0)
4
+ shopify_app (21.4.1)
5
5
  activeresource
6
6
  addressable (~> 2.7)
7
7
  browser_sniffer (~> 2.0)
@@ -30,7 +30,8 @@ module ShopifyApp
30
30
  return redirect_to_login
31
31
  end
32
32
 
33
- unless ShopifyApp.configuration.user_access_scopes_strategy.covers_scopes?(current_shopify_session)
33
+ if ShopifyApp.configuration.reauth_on_access_scope_changes &&
34
+ !ShopifyApp.configuration.user_access_scopes_strategy.covers_scopes?(current_shopify_session)
34
35
  clear_shopify_session
35
36
  return redirect_to_login
36
37
  end
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module ShopifyApp
4
- VERSION = "21.4.0"
4
+ VERSION = "21.4.1"
5
5
  end
data/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "shopify_app",
3
- "version": "21.4.0",
3
+ "version": "21.4.1",
4
4
  "repository": "git@github.com:Shopify/shopify_app.git",
5
5
  "author": "Shopify",
6
6
  "license": "MIT",
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: shopify_app
3
3
  version: !ruby/object:Gem::Version
4
- version: 21.4.0
4
+ version: 21.4.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Shopify
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2023-01-05 00:00:00.000000000 Z
11
+ date: 2023-02-21 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activeresource