shopify_api_bruv 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8119277813ab65392ec1a963097cd264dc4f610c00ae3e31c8cfaeaaf9b735e
-  data.tar.gz: 834626e70982174fb36b0bd7451e6e6318ea13c213a05d295262039287aea7c3
+  metadata.gz: 0c0d6c9a757b1c4164d65adcd704201932875e5451b7fc452206fce010847f16
+  data.tar.gz: 5139a1b215e2d4985857577edc2727e398edae28b068bc20744ec31b57052d81
 SHA512:
-  metadata.gz: e119e67234a23b633eca37f5370054b951669cd9c9363c0d99d215bbfd288c235ffabda5f8456fb43213222c6910092182717c63ff2f0e93211ecf859ba504d7
-  data.tar.gz: ff88c2d8b7a888a310cd14594d34ffe26c19506913ee1d91e232da4058bed4b3b42be46a3495f6cce6b096d48fc9f70db705875b289a7d35615316b191ee700f
+  metadata.gz: 82222f2e7665f99ea63e8c17a7c0445a01e61504ed37ac4c69aaac93704a576e55a813be22e8f4b89e45d85e66e87eea40e7f141f7b8f205f5380bddc89f7dfd
+  data.tar.gz: 19f07ef9290a43606159963d7eef46fc135376f90b9a58aad4e51209aca20950aa37dcea68bdf2bf5e269bffaf251bb0be17450fd771a42556f6057701af440f

data/.env.template

@@ -2,6 +2,3 @@ API_DOMAIN="{API_DOMAIN}"
 API_VERSION="{API_VERSION}"
 API_ACCESS_TOKEN="{API_ACCESS_TOKEN}"
 SHOPIFY_API_BRUV_LOGGER_ENABLED="true"
-SHOPIFY_API_BRUV_REQUEST_MAX_TRIES="3"
-SHOPIFY_API_BRUV_REQUEST_SLEEP_TIMER="4"
-SHOPIFY_API_BRUV_REQUEST_MINIMUM_CREDIT_LEFT="4"

data/CHANGELOG.md

@@ -1,9 +1,13 @@
 ## [Unreleased]
 
+## [0.3.1] - 2023-12-10
+
+- Adds error handling for http requests
+
 ## [0.3.0] - 2023-12-10
 
-- Refactor resource classes
-- Update docs
+- Refactors resource classes
+- Updates docs
 
 ## [0.2.7] - 2023-12-09
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify_api_bruv (0.3.0)
+    shopify_api_bruv (0.3.1)
       httparty
       logger
 

data/lib/shopify_api_bruv/clients/http_request.rb

@@ -5,6 +5,13 @@ module ShopifyApiBruv
     class HttpRequest
       attr_reader :api, :method, :path, :body, :content_type, :query, :headers
 
+      VALID_METHODS = [
+        :get,
+        :delete,
+        :put,
+        :post
+      ].freeze
+
       def initialize(api:, method:, path:, body:, content_type:, query: nil, headers:)
         @api = api
         @method = method
@@ -14,11 +21,27 @@ module ShopifyApiBruv
         @query = query
         @headers = headers
 
+        validate
+
         ShopifyApiBruv.logger(
           method: :info,
           message: "Shopify API Request (Method: #{method}):\nPath:\n#{path}\n\nBody:\n#{body}"
         )
       end
+
+      private
+
+      def validate
+        raise Errors::HttpRequestError,
+          "Invalid method #{method}, valid methods are: #{VALID_METHODS}" unless VALID_METHODS.include?(method)
+
+        raise Errors::HttpRequestError,
+          'Content-Type missing' if !body.nil? && content_type.nil?
+
+        return unless [:put, :post].include?(method)
+
+        raise Errors::HttpRequestError, "Body is required for method #{method}" if body.nil?
+      end
     end
   end
 end

data/lib/shopify_api_bruv/clients/http_response.rb

@@ -10,12 +10,12 @@ module ShopifyApiBruv
         @headers = headers
         @body = body
 
+        validate
+
         ShopifyApiBruv.logger(
           method: :info,
           message: "Shopify API Response (Code: #{code}):\nHeaders:\n#{headers}\n\nBody:\n#{body}"
         )
-
-        validate
       end
 
       private

data/lib/shopify_api_bruv/errors/http_request_error.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module ShopifyApiBruv
+  module Errors
+    class HttpRequestError < StandardError
+    end
+  end
+end

data/lib/shopify_api_bruv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ShopifyApiBruv
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api_bruv
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Idjent
@@ -127,6 +127,7 @@ files:
 - lib/shopify_api_bruv/clients/rest/client.rb
 - lib/shopify_api_bruv/clients/rest/http_response.rb
 - lib/shopify_api_bruv/errors/http_client_error.rb
+- lib/shopify_api_bruv/errors/http_request_error.rb
 - lib/shopify_api_bruv/errors/http_response_error.rb
 - lib/shopify_api_bruv/errors/resource_error.rb
 - lib/shopify_api_bruv/logger.rb