shopify_api 5.2.2 → 5.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b24e62339306bcf90e50246ef4e98f4ffa46c6a885d5859b14969f3aa1e62c9c
-  data.tar.gz: 7e57071a073cb0e5e2bda965a1ef4cef3cc42a968905b407df9184757a04ec3b
+  metadata.gz: e75163182c1fb7b35dd1812beb6a3a13da3d41ecb4f26c0af4677204442db127
+  data.tar.gz: 8ed57602229d2399ab17c5609941f6fe111cb5146282f76b518c42851edb0b95
 SHA512:
-  metadata.gz: 5224d787f4cc65f3174fa894098af11b7342059510c916fc4359ab2285793053e97bfb8eee318e136410fe6fd67626f7146f7f7727f8dba4e5bcc1b32867d597
-  data.tar.gz: 54c9dfed163c44b51fd811ba38efcf4c157ffdcaad5b5cc7f064e035ad0c890d9580b20ed316b75f99cac6368eb19e17e19c1a2da1bb556eb49562dd3f947a72
+  metadata.gz: acf3ef0aed4a68b6d339d8594d41f47c89b14322b557b5e4d7d0b90a1214f7f06f4fce3d7cc78e5d03ace2b01b747cef4572a427e933d504734e15e6f61ed7b4
+  data.tar.gz: 20ac9414d8d480332c07cd184b190cb67ca3ca1a27918c0091d356ee7c8f4d27946673335d3d7462f15c355e5fce0405059644975f42de735b447fc86f22bcee

data/CHANGELOG

@@ -1,3 +1,7 @@
+== Version 5.2.3
+
+* Update delivery confirmation resource to delivery confirmation details resource.
+
 == Version 5.2.2
 
 * Add delivery confirmation endpoint to Ping resources.

data/lib/shopify_api/resources/ping/conversation.rb

@@ -15,31 +15,28 @@ module ShopifyAPI
       end
 
       def successful_delivery(message_id:, delivery_timestamp:)
-        delivery_details = ShopifyAPI::Ping::DeliveryConfirmation.new(
-          conversation_id: id,
-          message_id: message_id,
-          delivery_confirmation_details: {
-            delivered: true,
-            confirmation_timestamp: delivery_timestamp,
-          }
+        delivery_details = ShopifyAPI::Ping::DeliveryConfirmationDetails.new(
+          delivery_attrs(message_id, delivery_timestamp).merge(delivered: true)
         )
         delivery_details.save
         delivery_details
       end
 
       def failed_delivery(message_id:, delivery_timestamp:, details:)
-        delivery_details = ShopifyAPI::Ping::DeliveryConfirmation.new(
-          conversation_id: id,
-          message_id: message_id,
-          delivery_confirmation_details: {
-            delivered: false,
-            confirmation_timestamp: delivery_timestamp,
-            details: details,
-          }
+        delivery_details = ShopifyAPI::Ping::DeliveryConfirmationDetails.new(
+          delivery_attrs(message_id, delivery_timestamp).merge(delivered: false, details: details)
         )
         delivery_details.save
         delivery_details
       end
+
+      def delivery_attrs(message_id, delivery_timestamp)
+        {
+          conversation_id: id,
+          message_id: message_id,
+          confirmation_timestamp: delivery_timestamp,
+        }
+      end
     end
   end
 end

data/lib/shopify_api/resources/ping/{delivery_confirmation.rb → delivery_confirmation_details.rb}

@@ -2,7 +2,7 @@
 
 module ShopifyAPI
   module Ping
-    class DeliveryConfirmation < Base
+    class DeliveryConfirmationDetails < Base
       self.prefix = "/admin/api/ping-api/v1/conversations/:conversation_id/messages/:message_id/"
       self.collection_name = "delivery_confirmation"
     end

data/lib/shopify_api/version.rb

@@ -1,3 +1,3 @@
 module ShopifyAPI
-  VERSION = "5.2.2"
+  VERSION = "5.2.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api
 version: !ruby/object:Gem::Version
-  version: 5.2.2
+  version: 5.2.3
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -250,7 +250,7 @@ files:
 - lib/shopify_api/resources/payment_details.rb
 - lib/shopify_api/resources/ping.rb
 - lib/shopify_api/resources/ping/conversation.rb
-- lib/shopify_api/resources/ping/delivery_confirmation.rb
+- lib/shopify_api/resources/ping/delivery_confirmation_details.rb
 - lib/shopify_api/resources/ping/message.rb
 - lib/shopify_api/resources/policy.rb
 - lib/shopify_api/resources/price_rule.rb