shopify_api 4.7.0 → 4.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b372c851db7445d6687816c3d008810155b61504
-  data.tar.gz: 488e2b61967bed7464f0ebf24cec6554e0f961da
+  metadata.gz: fd02395f105ed2a9d1c738643c5e2ce33f2b7107
+  data.tar.gz: 31e993b794581c144dc83ce3fb023aa92cf3904f
 SHA512:
-  metadata.gz: 1b6e947edf820c32391fc11e8c4f4c4b2acb4899db0a174fa25b456ec0e23a221b27c5442ad98a33b2361ecd0d2db87615af59051c9412b837c4264ed99e329c
-  data.tar.gz: '099a49bff83d8115709f24b5a48afd90f3bef9e7fe35448a4ab5341785b1fc9bb64dbce1f7c31b3e8fb5d7eaeb6cb26fea44ae129bcbea8309666535012e3f8d'
+  metadata.gz: 5d6325e60332700d5902c83cc8883ddc5cf6c751408f0784aefa50ea646613a8e9c0ae1211009649edd9bc3fd031571f0d45842aa72c2aedc931765c1e2fc5b8
+  data.tar.gz: b177c8c1c42d318ec9fb935d2dc6aa198fa973bbc6766dcad3412503c3254727a321ecb5f0cd0a94af260dfa373a759166065e497cddbccc4b6e10103e9bca09

data/CHANGELOG

@@ -1,3 +1,8 @@
+== Version 4.7.1
+
+* Added support for URL parameter (e.g. limit & page) to ShopifyAPI::Metafields
+* Added support for URL parameter (e.g. limit & page) to metafield operator in ShopifyAPI::Shop
+
 == Version 4.7.0
 
 * Removed the mandatory `application_id` parameter from `ShopifyAPI::ProductListing` and `ShopifyAPI::CollectionListing`

data/lib/shopify_api/metafields.rb

@@ -1,7 +1,9 @@
 module ShopifyAPI
   module Metafields
-    def metafields
-      Metafield.find(:all, :params => {:resource => self.class.collection_name, :resource_id => id})
+    def metafields(**options)
+      options.merge! resource: self.class.collection_name, resource_id: id
+
+      Metafield.find :all, params: options
     end
 
     def add_metafield(metafield)

data/lib/shopify_api/resources/shop.rb

@@ -6,10 +6,10 @@ module ShopifyAPI
       find(:one, options.merge({from: "/admin/shop.#{format.extension}"}))
     end
 
-    def metafields
-      Metafield.find(:all)
+    def metafields(**options)
+      Metafield.find :all, params: options
     end
-    
+
     def add_metafield(metafield)
       raise ArgumentError, "You can only add metafields to resource that has been saved" if new?      
       metafield.save

data/lib/shopify_api/version.rb

@@ -1,3 +1,3 @@
 module ShopifyAPI
-  VERSION = "4.7.0"
+  VERSION = "4.7.1"
 end

data/test/draft_order_test.rb

@@ -103,15 +103,27 @@ class DraftOrderTest < Test::Unit::TestCase
     assert_equal '123@example.com', field.value
   end
 
-  def test_get_metafields_for_draft_order
+  def test_get_all_metafields_for_draft_order
     fake 'draft_orders/517119332/metafields', body: load_fixture('metafields')
 
     metafields = @draft_order.metafields
 
-    assert_equal 2, metafields.length
+    assert_equal 3, metafields.length
     assert metafields.all? { |m| m.is_a?(ShopifyAPI::Metafield) }
   end
 
+  def test_get_2_metafields_for_draft_order
+    body = ActiveSupport::JSON.decode load_fixture 'metafields'
+    body['metafields'].slice! 2, 1
+
+    fake 'draft_orders/517119332/metafields.json?limit=2', body: body.to_json, extension: false
+
+    metafields = @draft_order.metafields limit: 2
+
+    assert_equal 2, metafields.length
+    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+  end
+
   def test_complete_draft_order_with_no_params
     completed_fixture = load_fixture('draft_order_completed')
     completed_draft = ActiveSupport::JSON.decode(completed_fixture)['draft_order']

data/test/fixtures/metafields.json

@@ -19,6 +19,16 @@
       "description": null,
       "key": "phone",
       "value_type": "string"
+    },
+    {
+      "created_at": "2017-04-24T20:14:24.031-04:00",
+      "updated_at": "2017-04-24T20:14:24.031-04:00",
+      "namespace": "contact",
+      "id": "72544103001",
+      "value": "Ottawa",
+      "description": null,
+      "key": "City",
+      "value_type": "string"
     }
   ]
 }

data/test/product_test.rb

@@ -19,13 +19,25 @@ class ProductTest < Test::Unit::TestCase
     assert_equal "123@example.com", field.value
   end
 
-  def test_get_metafields_for_product
+  def test_get_all_metafields_for_product
     fake "products/632910392/metafields", :body => load_fixture('metafields')
 
     metafields = @product.metafields
 
+    assert_equal 3, metafields.length
+    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+  end
+
+  def test_get_2_metafields_for_product
+    body = ActiveSupport::JSON.decode load_fixture 'metafields'
+    body['metafields'].slice! 2, 1
+
+    fake 'products/632910392/metafields.json?limit=2', body: body.to_json, extension: false
+
+    metafields = @product.metafields limit: 2
+
     assert_equal 2, metafields.length
-    assert metafields.all?{|m| m.is_a?(ShopifyAPI::Metafield)}
+    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
   end
 
   def test_update_loaded_variant

data/test/shop_test.rb

@@ -25,15 +25,27 @@ class ShopTest < Test::Unit::TestCase
     assert_equal "apple.myshopify.com", @shop.myshopify_domain
   end
 
-  def test_get_metafields_for_shop
+  def test_get_all_metafields_for_shop
     fake "metafields"
 
     metafields = @shop.metafields
 
-    assert_equal 2, metafields.length
+    assert_equal 3, metafields.length
     assert metafields.all?{|m| m.is_a?(ShopifyAPI::Metafield)}
   end
 
+  def test_get_2_metafields_for_shop
+    body = ActiveSupport::JSON.decode load_fixture 'metafields'
+    body['metafields'].slice! 2, 1
+
+    fake 'metafields.json?limit=2', body: body.to_json, extension: false
+
+    metafields = @shop.metafields limit: 2
+
+    assert_equal 2, metafields.length
+    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+  end
+
   def test_add_metafield
     fake "metafields", :method => :post, :status => 201, :body =>load_fixture('metafield')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.7.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-27 00:00:00.000000000 Z
+date: 2017-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource