shopify_api 3.2.4 → 3.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44b479654f7e155948ddabfca018f78047fe7a63
-  data.tar.gz: 4d1b0b744941f6e4a1cc68de93fe6e663fd60619
+  metadata.gz: 1febe6e195154bd62771f2b8fc00410db6af76d9
+  data.tar.gz: 922a39a6929f9f451d377d9c4133134dc1f6bea2
 SHA512:
-  metadata.gz: 144c870d4d8a1b892990f2f282933cf693a673f2ec0e6434ecce66e67d4303e9d343f9a8fcaff6c3efe57d8fea7820599f17f80ac369fd2b6bec53bc1acbb9c7
-  data.tar.gz: 8d483b74a646f1cb71123df54806fd67c9e51a490b8d2d583556ceabcd10417a732971ddb9e61e16faf10a64a9536daec12fbe373e929fd4322a6fd214752f2d
+  metadata.gz: f7e8850c60cc4dafe98276923dd472db045db886bd07498fbde719ca0e2f5ff2cb224c0023bc36058e600821a74010927e7e6c07c14fb6134e68ece14d13b5ad
+  data.tar.gz: 7518d576598f7056e3e637256448a4599f6b753a9e9d8ad3af67ed10223bc9d22bb65efe6da5e99e43eab28defd25291c8b3c44bed249f2f6a1d146502a6ca47

data/CHANGELOG

@@ -1,3 +1,12 @@
+== Version 3.2.5
+
+* More useful error messages for activating nil sessions
+* Add tests for commonly deleted objects, and metafield tests, fix naming error in order_risk_test.rb
+
+== Version 3.2.4
+
+* No API changes
+
 == Version 3.2.3
 
 * Added pry to the CLI

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify_api (3.2.4)
+    shopify_api (3.2.5)
       activeresource (>= 3.0.0)
       pry (>= 0.9.12.6)
       thor (~> 0.18.1)

data/lib/shopify_api/resources/base.rb

@@ -2,6 +2,7 @@ require 'shopify_api/version'
 
 module ShopifyAPI
   class Base < ActiveResource::Base
+    class InvalidSessionError < StandardError; end
     extend Countable
     self.include_root_in_json = false
     self.headers['User-Agent'] = ["ShopifyAPI/#{ShopifyAPI::VERSION}",
@@ -49,6 +50,7 @@ module ShopifyAPI
       end
 
       def activate_session(session)
+        raise InvalidSessionError.new("Session cannot be nil") if session.nil?
         self.site = session.site
         self.headers.merge!('X-Shopify-Access-Token' => session.token)
       end

data/lib/shopify_api/version.rb

@@ -1,3 +1,3 @@
 module ShopifyAPI
-  VERSION = "3.2.4"
+  VERSION = "3.2.5"
 end

data/shipit.rubygems.yml

@@ -1,15 +1 @@
-dependencies:
-  override:
-    - bundle install --path=./data/bundler
-
-deploy:
-  override:
-    - |
-      BUILD=`bundle exec rake build`
-      if [ $? != 0 ]; then
-        echo $BUILD;
-        exit 1;
-      fi
-      PKG=`echo $BUILD | cut -d" " -f5 | sed -e s/\.$//`;
-      VERSION=`echo $BUILD | cut -d" " -f2`;
-      gem push $PKG
+# using the default shipit config

data/test/base_test.rb

@@ -51,6 +51,12 @@ class BaseTest < Test::Unit::TestCase
     assert_equal 'token2', ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
   end
 
+  test '#activate_session with nil raises an InvalidSessionError' do
+    assert_raises ShopifyAPI::Base::InvalidSessionError do
+      ShopifyAPI::Base.activate_session nil
+    end
+  end
+
   test "#delete should send custom headers with request" do
     ShopifyAPI::Base.activate_session @session1
     ShopifyAPI::Base.headers['X-Custom'] = 'abc'

data/test/image_test.rb

@@ -23,4 +23,17 @@ class ImageTest < Test::Unit::TestCase
     image = ShopifyAPI::Image.find(850703190, :params => {:product_id => 632910392})
     assert_equal 850703190, image.id
   end
+
+  def test_delete_image
+    fake "products/632910392/images/850703190", :method => :get, :body => load_fixture('image')
+    fake "products/632910392/images/850703190", :method => :delete, :body => "destroyed"
+    image = ShopifyAPI::Image.find(850703190, :params => {:product_id => 632910392})
+    assert image.destroy
+  end
+
+  def test_delete_image_without_fetching
+    fake "products/632910392/images/850703190", :method => :delete, :body => "destroyed"
+    image = ShopifyAPI::Image.new(product_id: 632910392, id: 850703190)
+    assert image.destroy
+  end
 end

data/test/metafield_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'
+
+class MetafieldTest < Test::Unit::TestCase
+  def test_get_metafields
+    fake "metafields", :method => :get, :body => load_fixture('metafields')
+    metafields = ShopifyAPI::Metafield.find(:all)
+  end
+
+  def test_get_metafield
+    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
+    assert ShopifyAPI::Metafield.find(721389482)
+  end
+
+  def test_get_metafield_of_a_blog
+    fake "blogs/1008414260/metafields/721389482", :method => :get, :body => load_fixture('metafield')
+    metafield = ShopifyAPI::Metafield.find(721389482, :params => {:resource => "blogs", :resource_id => 1008414260})
+    assert_equal 1008414260, metafield.prefix_options[:resource_id]
+  end
+
+  def test_create_metafield_for_a_blog
+    fake "blogs/1008414260", :method => :get, :body => load_fixture('blog')
+    fake "blogs/1008414260/metafields", :method => :post, :status => 201, :body => load_fixture('metafield')
+
+    blog = ShopifyAPI::Blog.find(1008414260)
+    metafield = blog.add_metafield(ShopifyAPI::Metafield.new(:namespace => "summaries", :key => "First Summary", :value => "Make commerce better", :value_type => "string"))
+
+    assert_equal ActiveSupport::JSON.decode('{"metafield":{"namespace":"summaries","key":"First Summary","value":"Make commerce better","value_type":"string"}}'), ActiveSupport::JSON.decode(FakeWeb.last_request.body)
+    assert !metafield.new_record?
+  end
+
+  def test_update_metafield
+    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
+    fake "metafields/721389482", :method => :put, :status => 200, :body => load_fixture('metafield')
+    metafield = ShopifyAPI::Metafield.find(721389482)
+    metafield.namespace = "teaser"
+    assert metafield.save
+  end
+
+  def test_delete_metafield
+    fake "metafields/721389482", :method => :get, :body => load_fixture('metafield')
+    fake "metafields/721389482", :method => :delete, :body => 'destroyed'
+    metafield = ShopifyAPI::Metafield.find(721389482)
+    assert metafield.destroy
+  end
+end
+

data/test/order_risk_test.rb

@@ -35,7 +35,7 @@ class OrderRiskTest < Test::Unit::TestCase
     assert v.destroy
   end
 
-  def test_delete_order_risk
+  def test_update_order_risk
     fake "orders/450789469/risks/284138680", :method => :get, :body => load_fixture('order_risk')
     fake "orders/450789469/risks/284138680", :method => :put, :body => load_fixture('order_risk')
 

data/test/order_test.rb

@@ -28,5 +28,12 @@ class OrderTest < Test::Unit::TestCase
     order.save
     assert_equal "Test note", order.note
   end
+
+  test "delete should delete an order" do
+    fake 'orders/450789469', :method => :get, :status => 200, :body => load_fixture('order')
+    fake 'orders/450789469', :method => :delete, :body => 'destroyed'
+    order = ShopifyAPI::Order.find(450789469)
+    assert order.destroy
+  end
 end
 

data/test/variant_test.rb

@@ -33,4 +33,11 @@ class VariantTest < Test::Unit::TestCase
     v = ShopifyAPI::Variant.find(808950810)
     assert_equal 632910392, v.product_id
   end
+
+  def test_delete_variant
+    fake "products/632910392/variants/808950810", :method => :get, :body => load_fixture('variant')
+    fake "products/632910392/variants/808950810", :method => :delete, :body => 'destroyed'
+    v = ShopifyAPI::Variant.find(808950810, :params => {:product_id => 632910392})
+    assert v.destroy
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api
 version: !ruby/object:Gem::Version
-  version: 3.2.4
+  version: 3.2.5
 platform: ruby
 authors:
 - Shopify
@@ -30,7 +30,7 @@ cert_chain:
   fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
   TConQSX2BnZdhIEYW+cKzEC/bLc=
   -----END CERTIFICATE-----
-date: 2014-05-20 00:00:00.000000000 Z
+date: 2014-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -275,6 +275,7 @@ files:
 - test/fulfillment_test.rb
 - test/image_test.rb
 - test/limits_test.rb
+- test/metafield_test.rb
 - test/order_risk_test.rb
 - test/order_test.rb
 - test/product_test.rb
@@ -307,7 +308,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: ShopifyAPI is a lightweight gem for accessing the Shopify admin REST web