shopify-sinatra-app 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f14854ae0081a9b642032ba7eaa40ae85a5b22e0
-  data.tar.gz: c8157d64a372e0b1ad339898a920312beee32b4a
+  metadata.gz: e5c6280877cb5f262f0f68438da82e68fd553968
+  data.tar.gz: 29f093aaf57542798dbdd0ecfa5fdc0823bc0ae0
 SHA512:
-  metadata.gz: 50a4cd567b685d6a09eba34a43f014b535ab7f6b6ffb9c26eebc34dd7989f7b74494a894253b445426452711c031dc21a9b045a26a832fddba24b34578a5b0a9
-  data.tar.gz: 789e5772cdb0dc839c5b9d53da1fe912fba53e78e9dee35bde4719490a1aaca8da44c4c7083d739d9f2d28df34e2410019739e2c8a3d60a7ea70c5f121a87cfa
+  metadata.gz: 9aab213ea3f6f4dfaaf54a1c5009dd90e3db70a726dd056562159b78d2925daabaeac46d0394bd028685f81917aa4534b2eacd0749a5794a6fdd94d7fd81e9f9
+  data.tar.gz: 7adc98d77829296d23f09a130ca61a02762912606628c5570ae0a93487c862c00d1100b2e067da02bcea419f9dd7b5978fa573b52282f4dc6abc5bc0650cfb9b

data/README.md

@@ -127,15 +127,19 @@ note - a flash must be followed by a redirect or it won't work!
 
 Developing
 ----------
+You can set the application url in the [Shopify Partner area](https://app.shopify.com/services/partners/api_clients) to be `http://localhost:4567/` which will allow you to install your app on a live shop while running it locally.
+
+When developing locally you'll need to enable unsafe javascripts in your browser for the Embedded App SDK to function. Read more [here](http://docs.shopify.com/embedded-app-sdk/getting-started).
+
 To run the app locally we use `foreman` which comes with the [Heroku Toolbelt](https://devcenter.heroku.com/articles/quickstart). Foreman handles running our application and setting our credentials as environment variables. To run the application type:
 
 ```
-foreman start -p 4567
+foreman run bundle exec rackup config.ru
 ```
 
-Debugging ...
+Note - we use `foreman run ...` not foreman start because we only want to start the single process that is our app. This means if you add a debugger in your app it will trigger properly in the command line when the debugger is hit. If you don't have any debuggers feel free to use `foreman start -p 4567`.
 
-You can set the application url in the [Shopify Partner area](https://app.shopify.com/services/partners/api_clients) to be `http://localhost:4567/` which will allow you to install your app on a live shop while running it locally.
+To debug your app simply add `require 'byebug'` at the top and then type `byebug` where you would like to drop into an interactive session. You may also want to try out Pry.
 
 While running the app locally you'll be able to test the install and other routes because your browser is aware of your local application but if you want to test a route that listens to a webhook this will not work because Shopify cannot talk to your local web application. You could expose your local application to the web but an easier solution is to use a tool called [Ngrok](https://ngrok.com/). Download Ngrok and run it on port 4567 (or whichever port you  are using):
 
@@ -145,8 +149,6 @@ While running the app locally you'll be able to test the install and other route
 
 Ngrok will report what address your app is available at, leave Ngrok running and then create your webhook to point to the ngrok url plus your route e.g. `<ngrok url>/webhook_test.json`. Now trigger the webhook you are testing and it will get forwarded through ngrok to your local web application allowing you to use debuggers and repls to complete your code.
 
-When developing locally you'll need to enable unsafe javascripts in your browser for the Embedded App SDK to function. Read more [here](http://docs.shopify.com/embedded-app-sdk/getting-started).
-
 
 Deploying
 ---------

data/bin/shopify-sinatra-app-generator

@@ -15,6 +15,9 @@ else
   app_name = ARGV[1]
   app_dir = working_dir + "/" + app_name
 
+  puts "Generating new app: #{app_name}"
+  puts "fullpath: #{app_dir}"
+
   begin
     Dir.mkdir(app_dir)
 

data/lib/generator/lib/app.rb

@@ -33,8 +33,6 @@ class SinatraApp < Sinatra::Base
   # inside here.
   def install
     shopify_session do
-      params = YAML.load(File.read("config/app.yml"))
-
       # create an uninstall webhook, this webhook gets sent
       # when your app is uninstalled from a shop. It is good
       # practice to clean up any data from a shop when they

data/shopify-sinatra-app.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'shopify-sinatra-app'
-  s.version = '0.0.4'
+  s.version = '0.0.5'
 
   s.summary     = "A classy shopify app"
   s.description = "A Sinatra extension for building Shopify Apps. Akin to the shopify_app gem but for Sinatra"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify-sinatra-app
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Kevin Hughes