shopify-routes 0.0.4 → 0.0.5

data/lib/shopify-routes.rb

@@ -172,7 +172,7 @@ module ShopifyAPI
       if include?(:admin)
         # route to a shop's admin path
         r.match "*shop/admin" => r.redirect { |p,r|
-            "https://#{shop_domain[:shop]}/admin"
+            "https://#{shop_domain(p[:shop])}/admin"
           },
           as: "admin"
       end

data/script/console

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+pry -r ./lib/shopify-routes -r ./spec/support/rails_app

data/shopify-routes.gemspec

@@ -12,9 +12,11 @@ Gem::Specification.new do |gem|
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = "shopify-routes"
   gem.require_paths = ["lib"]
-  gem.version       = "0.0.4"
+  gem.version       = "0.0.5"
 
-  gem.add_runtime_dependency      "rails",                            ">= 3.0.0"
-  gem.add_runtime_dependency      "shopify_api",                      ">= 3.0.0"
-  gem.add_development_dependency  "rspec-rails",                      "~> 2.9.0"
+  gem.add_development_dependency  "rspec-rails",                     "~> 2.9.0"
+  gem.add_development_dependency  "pry",                             "~>0.9.9.4"
+
+  gem.add_runtime_dependency      "rails",                           ">= 3.0.0"
+  gem.add_runtime_dependency      "shopify_api",                     ">= 3.0.0"
 end

data/spec/lib/shopify-routes_spec.rb

@@ -6,203 +6,201 @@ describe "ShopifyAPI.routes" do
     @domain = "domain.myshopify.com"
   end
 
-  def find_route(name)
-    @router.routes.find {|r| r.name == name }
-  end
+  describe "redirect routes" do
 
-  def redirect_for(resource, id = nil)
-    route   = find_route(resource)
-    params  = { :shop => @domain }
-    params[:id] = id unless id.nil?
-    route.app.path(params, nil)
-  end
+    describe "brochure" do
+      subject { redirect_for :brochure }
+      it      { should eq "http://www.shopify.com?ref=referrer" }
+    end
 
-  def path_for(resource, id = nil)
-    path = "https://#{@domain}/admin/#{resource}"
-    path += "/#{id}" unless id.nil?
-    path
-  end
+    describe "signup" do
+      subject { redirect_for :signup }
+      it      { should eq "https://app.shopify.com/services/signup?ref=referrer" }
+    end
 
-  describe "redirect routes" do
+    describe "admin" do
+      subject { redirect_for :admin }
+      it      { should eq "https://#{@domain}/admin" }
+    end
 
     describe "applications" do
-      subject { redirect_for "applications" }
-      it      { should eq path_for "applications" }
+      subject { redirect_for :applications }
+      it      { should eq path_for :applications }
     end
 
     describe "orders" do
-      subject { redirect_for "orders" }
-      it      { should eq path_for "orders" }
+      subject { redirect_for :orders }
+      it      { should eq path_for :orders }
     end
 
     describe "order" do
-      subject { redirect_for "order", "1" }
-      it      { should eq path_for "orders", "1" }
+      subject { redirect_for :order, 1 }
+      it      { should eq path_for :orders, "1" }
     end
 
     describe "customers" do
-      subject { redirect_for "customers" }
-      it      { should eq path_for "customers" }
+      subject { redirect_for :customers }
+      it      { should eq path_for :customers }
     end
 
     describe "customer" do
-      subject { redirect_for "customer", "1" }
-      it      { should eq path_for "customers", "1" }
+      subject { redirect_for :customer, "1" }
+      it      { should eq path_for :customers, "1" }
     end
 
     describe "new_customer" do
-      subject { redirect_for "new_customer" }
-      it      { should eq path_for "customers", "new" }
+      subject { redirect_for :new_customer }
+      it      { should eq path_for :customers, "new" }
     end
 
     describe "products" do
-      subject { redirect_for "products" }
-      it      { should eq path_for "products" }
+      subject { redirect_for :products }
+      it      { should eq path_for :products }
     end
 
     describe "product" do
-      subject { redirect_for "product", "1" }
-      it      { should eq path_for "products", "1" }
+      subject { redirect_for :product, 1 }
+      it      { should eq path_for :products, 1 }
     end
 
     describe "new_product" do
-      subject { redirect_for "new_product" }
-      it      { should eq path_for "products", "new" }
+      subject { redirect_for :new_product }
+      it      { should eq path_for :products, "new" }
     end
 
     describe "custom_collections" do
-      subject { redirect_for "custom_collections" }
-      it      { should eq path_for "custom_collections" }
+      subject { redirect_for :custom_collections }
+      it      { should eq path_for :custom_collections }
     end
 
     describe "custom_collection" do
-      subject { redirect_for "custom_collection", "1" }
-      it      { should eq path_for "custom_collections", "1" }
+      subject { redirect_for :custom_collection, 1 }
+      it      { should eq path_for :custom_collections, "1" }
     end
 
     describe "new_custom_collection" do
-      subject { redirect_for "new_custom_collection" }
-      it      { should eq path_for "custom_collections", "new" }
+      subject { redirect_for :new_custom_collection }
+      it      { should eq path_for :custom_collections, "new" }
     end
 
     describe "smart_collections" do
-      subject { redirect_for "smart_collections" }
-      it      { should eq path_for "smart_collections" }
+      subject { redirect_for :smart_collections }
+      it      { should eq path_for :smart_collections }
     end
 
     describe "smart_collection" do
-      subject { redirect_for "smart_collection", "1" }
-      it      { should eq path_for "smart_collections", "1" }
+      subject { redirect_for :smart_collection, 1 }
+      it      { should eq path_for :smart_collections, "1" }
     end
 
     describe "new_smart_collection" do
-      subject { redirect_for "new_smart_collection" }
-      it      { should eq path_for "smart_collections", "new" }
+      subject { redirect_for :new_smart_collection }
+      it      { should eq path_for :smart_collections, "new" }
     end
 
     describe "pages" do
-      subject { redirect_for "pages" }
-      it      { should eq path_for "pages" }
+      subject { redirect_for :pages }
+      it      { should eq path_for :pages }
     end
 
     describe "page" do
-      subject { redirect_for "page", "1" }
-      it      { should eq path_for "pages", "1" }
+      subject { redirect_for :page, 1 }
+      it      { should eq path_for :pages, "1" }
     end
 
     describe "new_page" do
-      subject { redirect_for "new_page" }
-      it      { should eq path_for "pages", "new" }
+      subject { redirect_for :new_page }
+      it      { should eq path_for :pages, "new" }
     end
 
     describe "blogs" do
-      subject { redirect_for "blogs" }
-      it      { should eq path_for "blogs" }
+      subject { redirect_for :blogs }
+      it      { should eq path_for :blogs }
     end
 
     describe "blog" do
-      subject { redirect_for "blog", "1" }
-      it      { should eq path_for "blogs", "1" }
+      subject { redirect_for :blog, 1 }
+      it      { should eq path_for :blogs, "1" }
     end
 
     describe "new_blog" do
-      subject { redirect_for "new_blog" }
-      it      { should eq path_for "blogs", "new" }
+      subject { redirect_for :new_blog }
+      it      { should eq path_for :blogs, "new" }
     end
 
     describe "navigation" do
-      subject { redirect_for "navigation" }
-      it      { should eq path_for "links" }
+      subject { redirect_for :navigation }
+      it      { should eq path_for :links }
     end
 
     describe "promotions" do
-      subject { redirect_for "promotions" }
-      it      { should eq path_for "marketing" }
+      subject { redirect_for :promotions }
+      it      { should eq path_for :marketing }
     end
 
     describe "themes" do
-      subject { redirect_for "themes" }
-      it      { should eq path_for "themes" }
+      subject { redirect_for :themes }
+      it      { should eq path_for :themes }
     end
 
     describe "theme" do
-      subject { redirect_for "theme", "1" }
-      it      { should eq path_for "themes", "1" }
+      subject { redirect_for :theme, 1 }
+      it      { should eq path_for :themes, "1" }
     end
 
     describe "theme_settings" do
-      subject { redirect_for "theme_settings", "1" }
+      subject { redirect_for :theme_settings, "1" }
       it      { should eq path_for "themes/1/settings" }
     end
 
     describe "general_settings" do
-      subject { redirect_for "general_settings" }
-      it      { should eq path_for "general_preferences" }
+      subject { redirect_for :general_settings }
+      it      { should eq path_for :general_preferences }
     end
 
     describe "regions" do
-      subject { redirect_for "regions" }
-      it      { should eq path_for "countries" }
+      subject { redirect_for :regions }
+      it      { should eq path_for :countries }
     end
 
     describe "checkout_and_payment" do
-      subject { redirect_for "checkout_and_payment" }
-      it      { should eq path_for "payments" }
+      subject { redirect_for :checkout_and_payment }
+      it      { should eq path_for :payments }
     end
 
     describe "shipping_rates" do
-      subject { redirect_for "shipping_rates" }
-      it      { should eq path_for "shipping" }
+      subject { redirect_for :shipping_rates }
+      it      { should eq path_for :shipping }
     end
 
     describe "weight_based_shipping_rate" do
-      subject { redirect_for "weight_based_shipping_rate", "1" }
-      it      { should eq path_for "weight_based_shipping_rates", "1" }
+      subject { redirect_for :weight_based_shipping_rate, 1 }
+      it      { should eq path_for :weight_based_shipping_rates, "1" }
     end
 
     describe "price_based_shipping_rate" do
-      subject { redirect_for "price_based_shipping_rate", "1" }
-      it      { should eq path_for "price_based_shipping_rates", "1" }
+      subject { redirect_for :price_based_shipping_rate, 1 }
+      it      { should eq path_for :price_based_shipping_rates, "1" }
     end
 
     describe "fulfillment_services" do
-      subject { redirect_for "fulfillment_services" }
-      it      { should eq path_for "fulfillment_services" }
+      subject { redirect_for :fulfillment_services }
+      it      { should eq path_for :fulfillment_services }
     end
 
     describe "notifications" do
-      subject { redirect_for "notifications" }
-      it      { should eq path_for "notifications" }
+      subject { redirect_for :notifications }
+      it      { should eq path_for :notifications }
     end
 
     describe "notification" do
-      subject { redirect_for "notification", "1" }
-      it      { should eq path_for "notifications", "1" }
+      subject { redirect_for :notification, 1 }
+      it      { should eq path_for :notifications, "1" }
     end
 
     describe "domains" do
-      subject { redirect_for "domains" }
-      it      { should eq path_for "domains" }
+      subject { redirect_for :domains }
+      it      { should eq path_for :domains }
     end
   end
 end

data/spec/routes_helper_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe "route helper methods" do
+  before do
+    @router = RailsApp::Application.routes
+    @domain = "domain.myshopify.com"
+  end
+
+  describe "#find_route" do
+    context "with a valid name" do
+      it "should return a Journey::Route" do
+        @router.routes.should_receive(:find).and_return(@router.routes.first)
+        # NOTE: the name is not important here, since it's mocked
+        find_route("brochure").should be_a Journey::Route
+      end
+    end
+
+    context "with an invalid name" do
+      it "should return nil" do
+        find_route("haveyouevernoticedthatweirdalandkennyghavethesamehaircut").should be_nil
+      end
+    end
+  end
+
+  describe "#redirect_for" do
+    context "without an id" do
+      subject { redirect_for :brochure }
+      it      { should eq "http://www.shopify.com?ref=referrer" }
+    end
+
+    context "with an id" do
+      subject { redirect_for :products, 1 }
+      it      { should eq "https://#{@domain}/admin/products/1" }
+    end
+  end
+
+  describe "#path_for" do
+    context "without an id" do
+      subject { path_for :a_resource }
+      it      { should be_a String }
+      it      { should =~ /https:\/\/#{@domain}\/admin\// }
+      it      { should =~ /a_resource/ }
+      it      { should_not =~ /a_resource\// }
+    end
+    context "with an id" do
+      subject { path_for :a_resource, "with_an_id" }
+      it      { should be_a String }
+      it      { should =~ /https:\/\/#{@domain}\/admin\// }
+      it      { should =~ /a_resource\// }
+      it      { should =~ /with_an_id/ }
+    end
+  end
+
+end

data/spec/support/rails_app.rb

@@ -17,5 +17,5 @@ Rails.env = 'test'
 RailsApp::Application.initialize!
 
 RailsApp::Application.routes.draw do
-  ShopifyAPI.routes(self)
+  ShopifyAPI.routes self, :referrer => 'referrer'
 end

data/spec/support/routes_helper.rb

@@ -0,0 +1,16 @@
+def find_route(name)
+  @router.routes.find {|r| r.name == name.to_s }
+end
+
+def redirect_for(resource, id = nil)
+  route   = find_route(resource)
+  params  = { :shop => @domain }
+  params[:id] = id unless id.nil?
+  route.app.path(params, nil)
+end
+
+def path_for(resource, id = nil)
+  path = "https://#{@domain}/admin/#{resource.to_s}"
+  path += "/#{id}" unless id.nil?
+  path
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify-routes
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -12,19 +12,30 @@ cert_chain: []
 date: 2012-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
-  requirement: &25042380 !ruby/object:Gem::Requirement
+  name: rspec-rails
+  requirement: &14499120 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
+        version: 2.9.0
+  type: :development
   prerelease: false
-  version_requirements: *25042380
+  version_requirements: *14499120
 - !ruby/object:Gem::Dependency
-  name: shopify_api
-  requirement: &25058280 !ruby/object:Gem::Requirement
+  name: pry
+  requirement: &14498440 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.9.9.4
+  type: :development
+  prerelease: false
+  version_requirements: *14498440
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: &14497780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,18 +43,18 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *25058280
+  version_requirements: *14497780
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: &25057820 !ruby/object:Gem::Requirement
+  name: shopify_api
+  requirement: &14497320 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.9.0
-  type: :development
+        version: 3.0.0
+  type: :runtime
   prerelease: false
-  version_requirements: *25057820
+  version_requirements: *14497320
 description: Provides routes that redirect back to Shopify pages.
 email:
 - travis.j.haynes@gmail.com
@@ -59,10 +70,13 @@ files:
 - README.md
 - Rakefile
 - lib/shopify-routes.rb
+- script/console
 - shopify-routes.gemspec
 - spec/lib/shopify-routes_spec.rb
+- spec/routes_helper_spec.rb
 - spec/spec_helper.rb
 - spec/support/rails_app.rb
+- spec/support/routes_helper.rb
 homepage: ''
 licenses: []
 post_install_message: