shopify-money 4.1.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cadc7891cca0acc6f6128c570b259a5c1bead3a6a87175ebe3def93d9a618afb
-  data.tar.gz: 3fcc02abc7af2a86aba449ed135361a1024a18975430c8075f4b36d36d70c72a
+  metadata.gz: 7657b4f32cc093849fc1e4b9cc35cbe0792ec41750b08df424e5e37f5cc0ef6c
+  data.tar.gz: 688ba3c4195453a8dafd5c099d7daf42c5cddd2cb34b39cdc6b6c11bc8289a52
 SHA512:
-  metadata.gz: 982ccb02e8ad20c3ad3ba9d217e0a53531d370cf32e7664947d859997ee2bc493614908f722fd1dc1ee0f234e114cb4c7e3552c85401d978afac4d462e35344c
-  data.tar.gz: 4a5e188fb292ad0ca2afdc2ba3dbcde89507a352d34ac7b7964870fc1584c0f9fd10d1036bd5b78a1971649d107b89f549f3b38a4f9bad823e829ac0c60d29ea
+  metadata.gz: 3c304e8b46c7a8be5bf71a635ec31d17f9bcf952e971d99b231814deaeb4959bcbe423c9d80c6a61dbfd1cbfdca7a8f7701ae747c5bbb23c356f1e529cd6da7d
+  data.tar.gz: 1192d7dc8f9315ca4b9bfe7420ac5023f18cfe189751b82123153c2c833a0b8b9f631f77d2971bf1a7c3cf4a29ed1f1ed1cc853e23cd9847cf7eea9656d9fa6a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify-money (4.1.0)
+    shopify-money (4.1.1)
       bigdecimal (>= 3.0)
 
 GEM

data/lib/money/allocator.rb

@@ -66,9 +66,7 @@ class Money
 
       strategy ||= Money::Config.current.default_allocation_strategy
 
-      # Float#to_r preserves float imprecision (0.98.to_r != 98/100).
-      # Rationalize gives the clean fraction (0.98.rationalize == 49/50).
-      splits.map!(&:rationalize)
+      splits.map! { |split| rationalize(split) }
       allocations = splits.inject(0, :+)
 
       if (allocations - ONE) > Float::EPSILON
@@ -185,5 +183,12 @@ class Money
     def rank_by_nearest(amounts)
       amounts.each_with_index.sort_by { |amount, _i| 1 - amount[:fractional_subunits] }.map(&:last)
     end
+
+    def rationalize(number)
+      return number if number.is_a?(Rational)
+
+      # Float#to_r preserves float imprecision (0.98.to_r != 49/50).
+      number.to_s.to_r
+    end
   end
 end

data/lib/money/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Money
-  VERSION = "4.1.0"
+  VERSION = "4.1.1"
 end

data/rbs_collection.lock.yaml

@@ -301,6 +301,10 @@ gems:
   version: '0'
   source:
     type: stdlib
+- name: prism
+  version: 1.9.0
+  source:
+    type: rubygems
 - name: pstore
   version: '0'
   source:

data/sig/money/allocator.rbs

@@ -27,5 +27,6 @@ class Money
     def amounts_from_splits: (Numeric allocations, Array[Numeric] splits, ?Integer subunits_to_split) -> [Array[Hash[Symbol, Numeric]], Integer]
     def all_rational?: (Array[Numeric] splits) -> bool
     def rank_by_nearest: (Array[Hash[Symbol, Numeric]] amounts) -> Array[Integer]
+    def rationalize: (Numeric number) -> Rational
   end
 end

data/spec/allocator_spec.rb

@@ -57,6 +57,22 @@ RSpec.describe "Allocator" do
       expect { new_allocator(1).allocate([rate, 1 - rate]) }.not_to raise_error
     end
 
+    specify "#allocate handles BigDecimal splits" do
+      splits = [BigDecimal("0.25"), BigDecimal("0.75")]
+      expect(new_allocator(10).allocate(splits)).to eq([Money.new(2.50), Money.new(7.50)])
+    end
+
+    specify "#allocate handles Float splits" do
+      splits = [0.25, 0.75]
+      expect(new_allocator(10).allocate(splits)).to eq([Money.new(2.50), Money.new(7.50)])
+    end
+
+    specify "#allocate handles Rational splits" do
+      splits = [Rational(1, 4), Rational(3, 4)]
+      expect(new_allocator(10).allocate(splits)).to eq([Money.new(2.50), Money.new(7.50)])
+    end
+
+
     specify "#allocate raise ArgumentError when invalid strategy is provided" do
       expect { new_allocator(0.03).allocate([0.5, 0.5], :bad_strategy_name) }.to raise_error(ArgumentError, "Invalid strategy. Valid options: :roundrobin, :roundrobin_reverse, :nearest")
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.1
 platform: ruby
 authors:
 - Shopify Inc
@@ -252,7 +252,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.11
 specification_version: 4
 summary: Shopify's money gem
 test_files: []