shopify-money 3.2.5 → 3.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da7880db33de1bba4ca71e5fa179fd09c200419af6d8ff9f44ca8fcd610fda11
-  data.tar.gz: 8e423388158e2c3e8a26b51b15ad4aef414d391550736fa1f03da3e1d1eb8bfb
+  metadata.gz: 418b16ca343e15afec56dbfade82d9b8995efc241d4b82d3173c77c81f7ea3fc
+  data.tar.gz: 11d4b57794ac31518398361f1fd2c11f39fa5ba6f75baea4c2ed798ddca753c5
 SHA512:
-  metadata.gz: a6e74800a95e3d5ab5d79551a1ffae9e45ef72ad82b229c070bb7d909f4d522f1fe4c191eb570b03c21676909c965beb31d90f63658300b522cf5c991827dbd8
-  data.tar.gz: 39c15b0575f1343526d509506ee510ecc1f76f6dea463db446de01ab902455dbb91bedc28a07a368950329d04711d1a5ac470ce1926bf1889dbf410f0ab24fde
+  metadata.gz: 1f7417f5dde55d548afe45cccd10fe16118daf3af28dc83ed543b8ae52149bd88e069f519e63fb5c19aa0734397aef8f264d39ce4f8c4daab7ffcd8005e1b845
+  data.tar.gz: 6c3be9a047b8926991416d4b99a53602171d83457f6dac0d53e90ed4cf0e2ee0cb345c4282eae512d40ede474f0c4eaea3ccc02304ec1346211bdbd65e20e3ac

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify-money (3.2.5)
+    shopify-money (3.2.6)
       bigdecimal (>= 3.0)
 
 GEM

data/lib/money/money.rb

@@ -135,6 +135,10 @@ class Money
 
   def initialize(value, currency)
     raise ArgumentError if value.nan?
+    if value.infinite?
+      Money.deprecate("Initializing Money with infinity is deprecated and will raise an ArgumentError in v4")
+    end
+
     @currency = Helpers.value_to_currency(currency)
     @value = BigDecimal(value.round(@currency.minor_units))
     freeze
@@ -162,9 +166,14 @@ class Money
   end
 
   def <=>(other)
-    return unless other.respond_to?(:to_money)
-    arithmetic(other) do |money|
-      value <=> money.value
+    if other.is_a?(Numeric)
+      return value <=> other
+    end
+
+    if other.respond_to?(:to_money)
+      arithmetic(other) do |money|
+        value <=> money.value
+      end
     end
   end
 

data/lib/money/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Money
-  VERSION = "3.2.5"
+  VERSION = "3.2.6"
 end

data/spec/money_spec.rb

@@ -493,6 +493,16 @@ RSpec.describe "Money" do
     expect { Money.new( 0.0 / 0) }.to raise_error(ArgumentError)
   end
 
+  it "raises when constructed with positive infinity" do
+    expect(Money).to receive(:deprecate).once
+    Money.new(Float::INFINITY)
+  end
+
+  it "raises when constructed with negative infinity" do
+    expect(Money).to receive(:deprecate).once
+    Money.new(-Float::INFINITY)
+  end
+
   it "is comparable with non-money objects" do
     expect(money).not_to eq(nil)
   end
@@ -585,6 +595,7 @@ RSpec.describe "Money" do
     let (:nil_10) { Money.new(10.00, Money::NULL_CURRENCY) }
     let (:nil_20) { Money.new(20.00, Money::NULL_CURRENCY) }
     let (:usd_10) { Money.new(10.00, 'USD') }
+    let (:jpy_10) { Money.new(10, 'JPY') }
 
     it "<=> can compare with and without currency" do
       expect(Money.new(1000, Money::NULL_CURRENCY) <=> Money.new(2000, 'JPY')).to eq(-1)
@@ -746,6 +757,32 @@ RSpec.describe "Money" do
       it { expect { cad_10 <= nil }.to(raise_error(ArgumentError)) }
       it { expect { cad_10 <  nil }.to(raise_error(ArgumentError)) }
     end
+
+    describe('infinity comparisons') do
+      it { expect(cad_10 <=> Float::INFINITY).to(eq(-1)) }
+      it { expect(cad_10 <  Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 <= Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 >  Float::INFINITY).to(eq(false)) }
+      it { expect(cad_10 >= Float::INFINITY).to(eq(false)) }
+
+      it { expect(cad_10 <=> -Float::INFINITY).to(eq(1)) }
+      it { expect(cad_10 >  -Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 >= -Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 <  -Float::INFINITY).to(eq(false)) }
+      it { expect(cad_10 <= -Float::INFINITY).to(eq(false)) }
+
+      it { expect(jpy_10 <=> Float::INFINITY).to(eq(-1)) }
+      it { expect(jpy_10 <  Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 <= Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 >  Float::INFINITY).to(eq(false)) }
+      it { expect(jpy_10 >= Float::INFINITY).to(eq(false)) }
+
+      it { expect(jpy_10 <=> -Float::INFINITY).to(eq(1)) }
+      it { expect(jpy_10 >  -Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 >= -Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 <  -Float::INFINITY).to(eq(false)) }
+      it { expect(jpy_10 <= -Float::INFINITY).to(eq(false)) }
+    end
   end
 
   describe "#subunits" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 3.2.5
+  version: 3.2.6
 platform: ruby
 authors:
 - Shopify Inc
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.1
+rubygems_version: 4.0.4
 specification_version: 4
 summary: Shopify's money gem
 test_files: []