shopify-money 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75140fb176288187177a79f673b9741b69a4ae96e02b314139318d7ff817b8b9
-  data.tar.gz: d98030d40029dbb686b83b090ab11e43628a194bd2902ba130f5161e860dc839
+  metadata.gz: afe8dd7e74692587c2a65622a5ee6f1703ef9c0af100c0b0940f225399f2391f
+  data.tar.gz: e925f921795d0317f06d9d01c88f981560f353a5746e6d293e103a309600f881
 SHA512:
-  metadata.gz: 3e140de24fea5b7c90b5044f4b9732e013187a6cad34c7ea6bd9d8119cd118907c7faeb934ed533085389e3e55f7ba0649697e7563ec87380c6fc62ff9a1c935
-  data.tar.gz: 5a1d77f26c7886fc1a96edee8a920df4262385fce001209d640c9427e986e9d95d2d9a8232fca17a670758f45a7bc219d728386c080606d1f8bc348cb71ba0a3
+  metadata.gz: 99b9dccc03de12fd78021c9af07b26fe1897395f7762d0b14d0397064cbffc64eeb96e1e504a91591703c1e1d04c681416fbf51f60fff839939915e600a9bfe9
+  data.tar.gz: 062a4c38ce1fff9b93df7a33d19323e995ebd3a0b74cae3882f8f3f34654febc19bfb761cdb3092838db738868b475ef7fe84002f9c04c8736d49b7484742f85

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify-money (2.2.1)
+    shopify-money (2.2.2)
 
 GEM
   remote: https://rubygems.org/

data/lib/money/core_extensions.rb

@@ -14,14 +14,26 @@ end
 #   '100.37'.to_money => #<Money @cents=10037>
 class String
   def to_money(currency = nil)
-    if Money.config.legacy_deprecations
-      Money::Parser::Fuzzy.parse(self, currency).tap do |money|
-        message = "`#{self}.to_money` will behave like `Money.new` and raise on the next release. " \
-          "To parse user input, do so on the browser and use the user's locale."
-        Money.deprecate(message) if money.value != BigDecimal(self, exception: false)
+    currency = Money::Helpers.value_to_currency(currency)
+
+    unless Money.config.legacy_deprecations
+      return Money.new(self, currency)
+    end
+
+    Money::Parser::Fuzzy.parse(self, currency).tap do |money|
+      new_value = BigDecimal(self, exception: false)&.round(currency.minor_units)
+      old_value = money.value
+
+      if new_value != old_value
+        message = "`\"#{self}\".to_money` will soon behave like `Money.new(\"#{self}\")` and "
+        message +=
+          if new_value.nil?
+            "raise an ArgumentError exception. Use the browser's locale to parse money strings."
+          else
+            "return #{new_value} instead of #{old_value}."
+          end
+        Money.deprecate(message)
       end
-    else
-      Money.new(self, currency)
     end
   end
 end

data/lib/money/money.rb

@@ -116,7 +116,7 @@ class Money
         return amount
       end
 
-      msg = "Money.new is attempting to change currency of an existing money object"
+      msg = "Money.new(Money.new(amount, #{amount.currency}), #{currency}) is changing the currency of an existing money object"
       if Money.config.legacy_deprecations
         Money.deprecate("#{msg}. A Money::IncompatibleCurrencyError will raise in the next major release")
         return Money.new(amount.value, currency)

data/lib/money/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 class Money
-  VERSION = "2.2.1"
+  VERSION = "2.2.2"
 end

data/spec/core_extensions_spec.rb

@@ -61,6 +61,14 @@ RSpec.describe String do
     end
   end
 
+  it "#to_money does not warn when it already behaves like Money.new" do
+  configure(legacy_deprecations: true) do
+    expect(Money).to receive(:deprecate).never
+    expect("71.94999999999999".to_money("USD")).to eq(Money.new("71.95", "USD"))
+    expect("0.001".to_money("USD")).to eq(Money.new("0", "USD"))
+  end
+end
+
   it "#to_money should behave like Money.new with three decimal places amounts" do
     expect("29.000".to_money("USD")).to eq(Money.new("29.00", "USD"))
   end

data/spec/money_spec.rb

@@ -99,7 +99,7 @@ RSpec.describe "Money" do
 
   it "legacy_deprecations constructor with money used the constructor currency" do
     configure(legacy_deprecations: true) do
-     expect(Money).to receive(:deprecate).with(match(/Money.new is attempting to change currency of an existing money object/)).once
+     expect(Money).to receive(:deprecate).with(match(/Money.new\(Money.new\(amount, USD\), CAD\) is changing the currency of an existing money object/)).once
       expect(Money.new(Money.new(1, 'USD'), 'CAD')).to eq(Money.new(1, 'CAD'))
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-25 00:00:00.000000000 Z
+date: 2024-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler