shopify-money 0.11.6 → 0.11.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c122266eee7c568beac30f07b25eb000fec13b3b516f64d86b2a2a7fe0e062cb
-  data.tar.gz: 9462466de4c1d0d1fbaadbc4ad84bb26a53bbc2559369442c54c50aba6287fe6
+  metadata.gz: 47f4b881badba413ac46f65f7aff7457c2ec502f4ab743467393fe8b9e51b5d7
+  data.tar.gz: 5333ce81e4360e10349a2cb22966794a21cfca24ab3158c0376af374105062fe
 SHA512:
-  metadata.gz: a2972d4815fb48705773b50a0561e2cd4c662c53e42f05627220def37d01a25de850234c965c4b25fd47a8d3980b173c5ebc17724671bbb95c278bf1cfe52b14
-  data.tar.gz: 00d5a604adf5bd570378e424238a3977f3602b276a3c1d84bff2670853bd59eb27d9db2cac5e39b0208fb91e11f163b18e2ab2d40a90b86d656511e1ce9421d8
+  metadata.gz: 19d044e6aaa05b55fd3067eb7a51ba2fb140baf1eb221fcd2e3b7eb594e9025f45e0ff4bd0a490452b168e0211da85171493f11664a62ececb30f73b80850c73
+  data.tar.gz: df0d59334c90dd06236873fa42def1bb92b2657418a137a3d8a501e15b88d8c9ca325cdb92f0cd74d1af81eefb114993c5f6f0cab93d3b9ed20afa8a8ee4c412

data/dev.yml

@@ -3,7 +3,7 @@
 ---
 name: money
 up:
-- ruby: 2.3.3
+- ruby: 2.5.3
 - bundler
 commands:
   test: bundle exec rspec

data/lib/money/money.rb

@@ -340,14 +340,32 @@ class Money
   # @example
   #   Money.new(100, "USD").split(3) #=> [Money.new(34), Money.new(33), Money.new(33)]
   def split(num)
+    calculate_splits(num).sum { |value, count| Array.new(count, value) }
+  end
+
+  # Calculate the splits evenly without losing pennies.
+  # Returns the number of high and low splits and the value of the high and low splits.
+  # Where high represents the Money value with the extra penny
+  # and low a Money without the extra penny.
+  #
+  # @param [2] number of parties.
+  #
+  # @return [Hash<Money, Integer>]
+  #
+  # @example
+  #   Money.new(100, "USD").calculate_splits(3) #=> {Money.new(34) => 1, Money.new(33) => 2}
+  def calculate_splits(num)
     raise ArgumentError, "need at least one party" if num < 1
     subunits = self.subunits
     low = Money.from_subunits(subunits / num, currency)
     high = Money.from_subunits(low.subunits + 1, currency)
 
-    remainder = subunits % num
+    num_high = subunits % num
 
-    return Array.new(remainder, high) + Array.new(num - remainder, low)
+    {}.tap do |result|
+      result[high] = num_high if num_high > 0
+      result[low] = num - num_high
+    end
   end
 
   # Clamps the value to be within the specified minimum and maximum. Returns

data/lib/money/version.rb

@@ -1,3 +1,3 @@
 class Money
-  VERSION = "0.11.6"
+  VERSION = "0.11.7"
 end

data/money.gemspec

@@ -17,8 +17,8 @@ Gem::Specification.new do |s|
   s.add_development_dependency("rails", "~> 5.0")
   s.add_development_dependency("rspec", "~> 3.2")
   s.add_development_dependency("database_cleaner", "~> 1.6")
-  s.add_development_dependency("sqlite3", "~> 1.3")
-  s.add_development_dependency("bigdecimal", ">= 1.3.2")
+  s.add_development_dependency("sqlite3", "~> 1.3.6")
+  s.add_development_dependency("bigdecimal", "~> 1.3.2")
 
   s.files = `git ls-files`.split($/)
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }

data/spec/money_spec.rb

@@ -618,6 +618,25 @@ RSpec.describe "Money" do
     end
   end
 
+  describe "calculate_splits" do
+    specify "#calculate_splits gives 1 cent to both people if we start with 2" do
+      actual = Money.new(0.02, 'CAD').calculate_splits(2)
+
+      expect(actual).to eq({
+        Money.new(0.01, 'CAD') => 2,
+      })
+    end
+
+    specify "#calculate_splits gives an extra penny to one" do
+      actual = Money.new(0.04, 'CAD').calculate_splits(3)
+
+      expect(actual).to eq({
+        Money.new(0.02, 'CAD') => 1,
+        Money.new(0.01, 'CAD') => 2,
+      })
+    end
+  end
+
   describe "fraction" do
     specify "#fraction needs a positive rate" do
       expect {Money.new(1).fraction(-0.5)}.to raise_error(ArgumentError)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.11.6
+  version: 0.11.7
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-20 00:00:00.000000000 Z
+date: 2019-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,26 +86,26 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.3.6
 - !ruby/object:Gem::Dependency
   name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.2
 description: Manage money in Shopify with a class that wont lose pennies during division!