shopify-money 0.11.5 → 0.11.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9441b8dab64b7077e0d960f6a81dc069c283ac90
-  data.tar.gz: 3fddaf1c805956ee9ca67c9295047698dfeb19f3
+SHA256:
+  metadata.gz: c122266eee7c568beac30f07b25eb000fec13b3b516f64d86b2a2a7fe0e062cb
+  data.tar.gz: 9462466de4c1d0d1fbaadbc4ad84bb26a53bbc2559369442c54c50aba6287fe6
 SHA512:
-  metadata.gz: d3c7e5ff1f9ac0a66bbcf0097f5cfdc5c7fa2b202d499850ab5c6620dcece9d96936c3b1e9a8abd6c387be910b8c92d7ef42263755752b4766dcedbac187546e
-  data.tar.gz: 36ac7078e3b1960f91d399517c468c29c62744a1068525c23263c4401ab075aae0be8c6e7f166e64050be2a1d6d78dfdcb3f26daab97000a97493a2e3bf41464
+  metadata.gz: a2972d4815fb48705773b50a0561e2cd4c662c53e42f05627220def37d01a25de850234c965c4b25fd47a8d3980b173c5ebc17724671bbb95c278bf1cfe52b14
+  data.tar.gz: 00d5a604adf5bd570378e424238a3977f3602b276a3c1d84bff2670853bd59eb27d9db2cac5e39b0208fb91e11f163b18e2ab2d40a90b86d656511e1ce9421d8

data/.github/probots.yml

@@ -0,0 +1,2 @@
+enabled:
+  - cla

data/lib/money/money.rb

@@ -346,13 +346,8 @@ class Money
     high = Money.from_subunits(low.subunits + 1, currency)
 
     remainder = subunits % num
-    result = []
 
-    num.times do |index|
-      result[index] = index < remainder ? high : low
-    end
-
-    return result
+    return Array.new(remainder, high) + Array.new(num - remainder, low)
   end
 
   # Clamps the value to be within the specified minimum and maximum. Returns

data/lib/money/version.rb

@@ -1,3 +1,3 @@
 class Money
-  VERSION = "0.11.5"
+  VERSION = "0.11.6"
 end

data/lib/money_column/active_record_hooks.rb

@@ -54,13 +54,16 @@ module MoneyColumn
         return self[column] = Money.new(money, currency_raw_source).value
       end
 
-      currency_source = currency_raw_source ? Money::Helpers.value_to_currency(currency_raw_source) : Money::NULL_CURRENCY
-      unless currency_source.compatible?(money.currency)
-        Money.deprecate("[money_column] currency mismatch between #{currency_source} and #{money.currency}.")
+      if options[:currency_read_only]
+        currency_source = Money::Helpers.value_to_currency(currency_raw_source)
+        if currency_raw_source && !money.currency.compatible?(currency_source)
+          Money.deprecate("[money_column] currency mismatch between #{currency_source} and #{money.currency}.")
+        end
+      else
+        self[options[:currency_column]] = money.currency.to_s unless money.no_currency?
       end
 
       self[column] = money.value
-      self[options[:currency_column]] = money.currency.to_s unless options[:currency_read_only] || money.no_currency?
     end
 
     module ClassMethods

data/spec/money_column_spec.rb

@@ -139,9 +139,8 @@ RSpec.describe 'MoneyColumn' do
     expect(record.currency.to_s).to eq('EUR')
   end
 
-  it 'does overwrite a currency if changed but will show a deprecation notice' do
+  it 'does overwrite a currency' do
     expect(record.currency.to_s).to eq('EUR')
-    expect(Money).to receive(:deprecate).once
     record.update(price: Money.new(4, 'JPY'))
     expect(record.currency.to_s).to eq('JPY')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.11.5
+  version: 0.11.6
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-18 00:00:00.000000000 Z
+date: 2018-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -116,6 +116,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".document"
+- ".github/probots.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -178,7 +179,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Shopify's money gem