shopify-money 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 964eb834ae37a4f224f6ce79f5dcd75ae544d8a6
-  data.tar.gz: 400e4c5737f8960c44ebb8d89b78f8fcc7506db2
+  metadata.gz: 3c62660129723a9f481f8221721c4da317b576a9
+  data.tar.gz: c70fd044ea5a5a1631c24b3725615fed02cf74b8
 SHA512:
-  metadata.gz: 11c8e67a85e4709618df2f7443bd6102929e12883339fa8ad55ea7c9a2b2c3b951fe980250ef421b0b7d8066770eac6bad9fe6ea74493095722b00d610ae2b28
-  data.tar.gz: 2b4abc9631217467ac967254cd41e5921635acacc351fd69d949fb51e342a6fe8bcf437a0c75d01b078dc5182bd598c157e5c7a1b3089df128832f648e93d4a6
+  metadata.gz: 8f8a19b78a2c33b5b0952d433e9d9d88f55fd7105c054478e51656a6137d935a92bf220309116960f08ac56392d3ff0fcf4dafdaafcb7d614874d3e442953bc2
+  data.tar.gz: 37f28f245c3ba5f4f1833f60981b1c0075f6391f2a88dbdae73ac489b37fdd4dc8c88c12f1ff25292489e58a065f25c29956ee58c7d61d4b5bf3fc85ba02b23c

data/lib/money/version.rb

@@ -1,3 +1,3 @@
 class Money
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/lib/money_column/active_record_hooks.rb

@@ -122,6 +122,11 @@ module MoneyColumn
           super(value)
         end
       end
+
+      def inherited(subclass)
+        subclass.instance_variable_set('@money_column_options', money_column_options.dup) if money_column_options
+        super
+      end
     end
   end
 end

data/spec/money_column_spec.rb

@@ -49,6 +49,15 @@ class MoneyWithCustomAccessors < ActiveRecord::Base
   end
 end
 
+class MoneyClassInheritance < MoneyWithCustomAccessors
+  money_column :prix, currency_column: 'currency'
+end
+
+class MoneyClassInheritance2 < MoneyWithCustomAccessors
+  money_column :price, currency: 'CAD'
+  money_column :price_usd, currency: 'USD'
+end
+
 RSpec.describe 'MoneyColumn' do
   let(:amount) { 1.23 }
   let(:currency) { 'EUR' }
@@ -321,4 +330,24 @@ RSpec.describe 'MoneyColumn' do
       expect(object.instance_variable_get(:@money_column_cache)['price']).to eql(amount + 1)
     end
   end
+
+  describe 'class inheritance' do
+    it 'shares money columns declared on the parent class' do
+      expect(MoneyClassInheritance.instance_variable_get(:@money_column_options).dig('price', :currency_column)).to eq('currency')
+      expect(MoneyClassInheritance.instance_variable_get(:@money_column_options).dig('price', :currency)).to eq(nil)
+      expect(MoneyClassInheritance.new(price: Money.new(1, 'USD')).price).to eq(Money.new(2, 'USD'))
+    end
+
+    it 'subclass can define extra money columns' do
+      expect(MoneyClassInheritance.instance_variable_get(:@money_column_options).keys).to include('prix')
+      expect(MoneyClassInheritance.instance_variable_get(:@money_column_options).keys).to_not include('price_usd')
+      expect(MoneyClassInheritance.new(prix: Money.new(1, 'USD')).prix).to eq(Money.new(1, 'USD'))
+    end
+
+    it 'subclass can redefine money columns from parent' do
+      expect(MoneyClassInheritance2.instance_variable_get(:@money_column_options).dig('price', :currency)).to eq('CAD')
+      expect(MoneyClassInheritance2.instance_variable_get(:@money_column_options).dig('price', :currency_column)).to eq(nil)
+      expect(MoneyClassInheritance2.instance_variable_get(:@money_column_options).keys).to_not include('prix')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-20 00:00:00.000000000 Z
+date: 2018-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler